From: "wangjianjian (C)" <wangjianjian3@huawei.com>
To: "musl@lists.openwall.com" <musl@lists.openwall.com>
Subject: Re: [PATCH 1/1] ungetc: Cast to unsigned char before push
Date: Sun, 20 Oct 2019 04:37:59 +0000 [thread overview]
Message-ID: <0ed5cfc952cd417097c17af55a839549@huawei.com> (raw)
Thanks for review. I will send a v2.
>> I believe this is actually a functional change, and a needed one for
>> conformance (to ISO C, not specific to POSIX). The issue it seems to
Yes, I check ISO C standard. It also requires returning the character
pushed back after conversion.
>> solve, which is what the change needs to be documented as, is the
>> return value when a negative value not equal to EOF is passed to
I don't quite understand. Do you mean we need document this change?
If so, where should I put it? Please tell me.
BR,
Wang Jianjian
reply other threads:[~2019-10-20 4:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ed5cfc952cd417097c17af55a839549@huawei.com \
--to=wangjianjian3@huawei.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).