From: Jens Gustedt <jens.gustedt@inria.fr>
To: musl@lists.openwall.com
Subject: Re: guard bug for strerror_r
Date: Fri, 08 Feb 2013 20:53:51 +0100 [thread overview]
Message-ID: <1360353231.2983.382.camel@eris.loria.fr> (raw)
In-Reply-To: <20130208185918.GJ20323@brightrain.aerifal.cx>
[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]
Hello
Am Freitag, den 08.02.2013, 13:59 -0500 schrieb Rich Felker:
> > #if defined(__GLIBC__) && defined(__USE_GNU)
the __GLIBC__ thing seems to work for my case, now. strerror_r seems
to be the only interface where they use the same name with a different
interface, so I'll bug something around that.
> I would simply avoid _ever_ using strerror_r on GNU systems. On any
> modern GNU or POSIX 2008 conforming system, you have the vastly
> superior strerror_l function. It does not require you to provide a
> buffer, and it's thread-safe (the buffer returned is either immutable
> static or thread-local). The logic I'd recommend is:
>
> #if _POSIX_VERSION >= 200809L || defined(__GLIBC__)
> /* use strerror_l */
> #else
> /* use strerror_r and assume POSIX version of it */
> #endif
Hm, I have a relatively recent system (ubuntu) and there is no trace
of strerror_l in the documentation, even in their "POSIX" man page.
And I actually use this in P99 to provide the C11 Annex K interface
strerror_s, which is much closer to strerror_r than strerror_l. Well,
we now have
strerror C, POSIX
strerror_r POSIX
strerror_l POSIX
strerror_s C
superbe. Again a case where a liaison between the C committee and the
POSIX could have helped.
Jens
--
:: INRIA Nancy Grand Est :: http://www.loria.fr/~gustedt/ ::
:: AlGorille ::::::::::::::: office Nancy : +33 383593090 ::
:: ICube :::::::::::::: office Strasbourg : +33 368854536 ::
:: ::::::::::::::::::::::::::: gsm France : +33 651400183 ::
:: :::::::::::::::::::: gsm international : +49 15737185122 ::
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-02-08 19:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 16:48 Jens Gustedt
2013-02-08 16:55 ` Szabolcs Nagy
2013-02-08 17:30 ` Jens Gustedt
2013-02-08 18:01 ` Isaac Dunham
2013-02-08 18:59 ` Rich Felker
2013-02-08 19:53 ` Jens Gustedt [this message]
2013-02-08 20:01 ` Rich Felker
2013-02-08 20:31 ` Jens Gustedt
2013-02-08 20:38 ` Rich Felker
2013-02-10 23:08 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360353231.2983.382.camel@eris.loria.fr \
--to=jens.gustedt@inria.fr \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).