From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: guard bug for strerror_r
Date: Fri, 8 Feb 2013 17:55:43 +0100 [thread overview]
Message-ID: <20130208165542.GW6181@port70.net> (raw)
In-Reply-To: <1360342098.2983.360.camel@eris.loria.fr>
* Jens Gustedt <jens.gustedt@inria.fr> [2013-02-08 17:48:18 +0100]:
> The linux man page says
>
> The XSI-compliant version of strerror_r() is provided if:
> (_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && ! _GNU_SOURCE
> Otherwise, the GNU-specific version is provided.
>
> but the musl code has
>
> #if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \
> || defined(_XOPEN_SOURCE) || defined(_GNU_SOURCE) \
> || defined(_BSD_SOURCE)
> ...
> int strerror_r (int, char *, size_t);
> ...
> #endif
>
> So if __GNU_SOURCE is set, glibc chooses their own interface and
> musl choose the POSIX interface.
>
> Why is musl touching __GNU_SOURCE at all?
>
musl provides the posix api when requested
musl provides many gnu specific apis when _GNU_SOURCE is set
but when posix and gnu collides it's always the posix api,
musl never provides broken gnu apis
at least this was the policy so far
next prev parent reply other threads:[~2013-02-08 16:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 16:48 Jens Gustedt
2013-02-08 16:55 ` Szabolcs Nagy [this message]
2013-02-08 17:30 ` Jens Gustedt
2013-02-08 18:01 ` Isaac Dunham
2013-02-08 18:59 ` Rich Felker
2013-02-08 19:53 ` Jens Gustedt
2013-02-08 20:01 ` Rich Felker
2013-02-08 20:31 ` Jens Gustedt
2013-02-08 20:38 ` Rich Felker
2013-02-10 23:08 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130208165542.GW6181@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).