mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Jens Gustedt <jens.gustedt@inria.fr>
To: musl@lists.openwall.com
Subject: Re: guard bug for strerror_r
Date: Fri, 08 Feb 2013 21:31:11 +0100	[thread overview]
Message-ID: <1360355471.23424.79.camel@eris.loria.fr> (raw)
In-Reply-To: <20130208200129.GK20323@brightrain.aerifal.cx>

[-- Attachment #1: Type: text/plain, Size: 2564 bytes --]

Am Freitag, den 08.02.2013, 15:01 -0500 schrieb Rich Felker:
> It's part of the "xlocale" set of interfaces that seem to have
> originated with glibc or maybe Sun, and later made it into POSIX 2008.
> It allows you to pass a locale_t argument to get the results in a
> non-default locale, but you can instead just request the current
> locale.

really bizarre that they didn't estimate it necessary to document it

> > And I actually use this in P99 to provide the C11 Annex K interface
> > strerror_s, which is much closer to strerror_r than strerror_l. Well,
> > we now have
> 
> Are you sure this is the best interface to provide to applications?

the best I don't know, but it is now a standard and provides
runtime-constraint handlers, and basic function parameter checking,
which are nice features. (Just forget about the official title "Bounds
checking interfaces".)

> I'd instead provide a thread-safe interface with an interface
> identical to strerror, since that's by far the easiest to use.
> 
> If on the other hand you want to provide Annex K in principle,

I do

> that's
> another matter, but there's a fairly large portion of it that can't be
> provided portably on top of an existing libc (mainly the scanf or
> printf stuff, I think).

yes, these don't work and since P99 isn't a library but only wrappers
I can't provide that. But for the most of it the wrappers are quite
simple and provided by P99.

> > strerror    C, POSIX
> > strerror_r  POSIX
> > strerror_l  POSIX
> > strerror_s  C
> > 
> > superbe. Again a case where a liaison between the C committee and the
> > POSIX could have helped.
> 
> The problem seems to be just that C didn't have threads (and thus no
> need for strerror_r or strerror_l) until C11.

But now they have threads, and so at the same moment of introducing
them they could have equipped them with a semantic (POSIX comes into
mind :) and used other interfaces from POSIX that already exist.

And, also I think that even before the _r version would have been a
good thing. I think the _r stands for reentrant, and for a function
that you would typically like to use in error or signal handlers, this
is a nice feature.

Jens

-- 
:: INRIA Nancy Grand Est :: http://www.loria.fr/~gustedt/   ::
:: AlGorille ::::::::::::::: office Nancy : +33 383593090   ::
:: ICube :::::::::::::: office Strasbourg : +33 368854536   ::
:: ::::::::::::::::::::::::::: gsm France : +33 651400183   ::
:: :::::::::::::::::::: gsm international : +49 15737185122 ::



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2013-02-08 20:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-08 16:48 Jens Gustedt
2013-02-08 16:55 ` Szabolcs Nagy
2013-02-08 17:30   ` Jens Gustedt
2013-02-08 18:01     ` Isaac Dunham
2013-02-08 18:59       ` Rich Felker
2013-02-08 19:53         ` Jens Gustedt
2013-02-08 20:01           ` Rich Felker
2013-02-08 20:31             ` Jens Gustedt [this message]
2013-02-08 20:38               ` Rich Felker
2013-02-10 23:08     ` Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360355471.23424.79.camel@eris.loria.fr \
    --to=jens.gustedt@inria.fr \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).