From: Petr Vorel <petr.vorel@gmail.com>
To: musl@lists.openwall.com
Subject: Re: [PATCH 2/2] define mt_fileno and mt_fileno struct mtget members as mt_blkno
Date: Fri, 7 Jun 2019 07:42:15 +0200 [thread overview]
Message-ID: <20190607054214.GA7177@x230> (raw)
In-Reply-To: <20190607053102.GP1506@brightrain.aerifal.cx>
Hi Rich,
...
> > +++ b/include/sys/mtio.h
> > @@ -54,8 +54,8 @@ struct mtget {
> > long mt_dsreg;
> > long mt_gstat;
> > long mt_erreg;
> > - int mt_fileno;
> > - int mt_blkno;
> > + daddr_t mt_fileno;
> > + daddr_t mt_blkno;
...
> Can you explain what problem this is supposed to fix? It definitely
> needs further discussion to determine what the right way is, but
> that's impossible without knowing the problem you're trying to solve.
Thanks for review. Not a problem for me actually. I've noticed, that glibc (and
thus uclibc-ng) and bionic follow kernel sources, which defines it long for mips
(and for sparc, but musl doesn't support it). Default is int [2]. Drop this
patch if this is not an issue.
> Rich
Kind regards,
Petr
[1] https://elixir.bootlin.com/linux/latest/source/arch/mips/include/uapi/asm/posix_types.h#L21
[2] https://elixir.bootlin.com/linux/latest/source/include/uapi/asm-generic/posix_types.h#L45
next prev parent reply other threads:[~2019-06-07 5:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 5:14 [PATCH 1/2] define daddr_t type Petr Vorel
2019-06-07 5:14 ` [PATCH 2/2] define mt_fileno and mt_fileno struct mtget members as mt_blkno Petr Vorel
2019-06-07 5:31 ` Rich Felker
2019-06-07 5:42 ` Petr Vorel [this message]
2019-06-07 5:50 ` Rich Felker
2019-06-07 5:58 ` Petr Vorel
2019-06-07 6:01 ` Rich Felker
2019-06-07 5:28 ` [PATCH 1/2] define daddr_t type Rich Felker
2019-06-07 5:53 ` Petr Vorel
2019-06-07 5:58 ` Rich Felker
2019-06-07 6:06 ` Petr Vorel
2019-06-07 6:18 ` Rich Felker
2019-06-07 6:28 ` Petr Vorel
2019-06-07 7:22 ` Florian Weimer
2019-06-07 7:48 ` Petr Vorel
2019-06-07 9:21 ` Petr Vorel
2019-06-07 12:52 ` Leah Neukirchen
2019-06-07 15:25 ` Rich Felker
2019-06-10 20:30 ` Rich Felker
2019-06-07 20:57 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607054214.GA7177@x230 \
--to=petr.vorel@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).