From: Leah Neukirchen <leah@vuxu.org>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com
Subject: Re: [PATCH 1/2] define daddr_t type
Date: Fri, 07 Jun 2019 14:52:07 +0200 [thread overview]
Message-ID: <874l518snc.fsf@vuxu.org> (raw)
In-Reply-To: <20190607055849.GR1506@brightrain.aerifal.cx> (Rich Felker's message of "Fri, 7 Jun 2019 01:58:49 -0400")
Rich Felker <dalias@libc.org> writes:
> On Fri, Jun 07, 2019 at 07:53:29AM +0200, Petr Vorel wrote:
>> Hi Rich,
>>
>> ....
>> > > +++ b/include/sys/types.h
>> > > @@ -29,6 +29,7 @@ extern "C" {
>> > > #define __NEED_clock_t
>> > > #define __NEED_suseconds_t
>> > > #define __NEED_blksize_t
>> > > +#define __NEED_daddr_t
>> ....
>>
>> > daddr_t is not a standard type, so can't be exposed by default here
>> > (aside from the dubious "*_t is always reserved" rule), and it's only
>> So should it be wrapped by #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE) ?
>>
>> > proposed to be used in one header, so it doesn't belong in alltypes.h
>> > either.
>> Where should it be then? Shell I create bits/types.h for it?
>> The goal is to be loadable from <sys/types.h>
>
> Why? It's not a reasonable type for any application to use -- we've
> never gotten a report that something failed to build because of its
> absence, and even if we did, it would almost surely be a case of "fix
> the application".
FWIW, Void patches four packages that use daddr_t:
- gpart
- kpartx
- libtirpc
- sleuthkit
Additionally, five packages use caddr_t:
- ifenslave
- lwipv6
- macchanger
- sbcl
- virtuoso
--
Leah Neukirchen <leah@vuxu.org> http://leahneukirchen.org/
next prev parent reply other threads:[~2019-06-07 12:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 5:14 Petr Vorel
2019-06-07 5:14 ` [PATCH 2/2] define mt_fileno and mt_fileno struct mtget members as mt_blkno Petr Vorel
2019-06-07 5:31 ` Rich Felker
2019-06-07 5:42 ` Petr Vorel
2019-06-07 5:50 ` Rich Felker
2019-06-07 5:58 ` Petr Vorel
2019-06-07 6:01 ` Rich Felker
2019-06-07 5:28 ` [PATCH 1/2] define daddr_t type Rich Felker
2019-06-07 5:53 ` Petr Vorel
2019-06-07 5:58 ` Rich Felker
2019-06-07 6:06 ` Petr Vorel
2019-06-07 6:18 ` Rich Felker
2019-06-07 6:28 ` Petr Vorel
2019-06-07 7:22 ` Florian Weimer
2019-06-07 7:48 ` Petr Vorel
2019-06-07 9:21 ` Petr Vorel
2019-06-07 12:52 ` Leah Neukirchen [this message]
2019-06-07 15:25 ` Rich Felker
2019-06-10 20:30 ` Rich Felker
2019-06-07 20:57 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874l518snc.fsf@vuxu.org \
--to=leah@vuxu.org \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).