From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: [PATCH v2] remove riscv64 user_regs_struct
Date: Tue, 6 Aug 2019 13:50:06 -0400 [thread overview]
Message-ID: <20190806175006.GZ9017@brightrain.aerifal.cx> (raw)
In-Reply-To: <e217dcc2434a9559f25455111b694e47deffe6e2.1565113649.git.baruch@tkos.co.il>
On Tue, Aug 06, 2019 at 08:47:29PM +0300, Baruch Siach wrote:
> user_regs_struct removal fixes possible conflict with the kernel
> definition of the same struct in asm/ptrace.h. glibc does not define
> user_regs_struct for riscv either.
> ---
> v2: Remove user_regs_struct entirely following feedback from Rich and
> Szabolcs
> ---
> arch/riscv64/bits/user.h | 35 -----------------------------------
> 1 file changed, 35 deletions(-)
>
> diff --git a/arch/riscv64/bits/user.h b/arch/riscv64/bits/user.h
> index bd0f0fc7027f..d2e383b24e53 100644
> --- a/arch/riscv64/bits/user.h
> +++ b/arch/riscv64/bits/user.h
> @@ -1,38 +1,3 @@
> -struct user_regs_struct {
> - unsigned long pc;
> - unsigned long ra;
> - unsigned long sp;
> - unsigned long gp;
> - unsigned long tp;
> - unsigned long t0;
> - unsigned long t1;
> - unsigned long t2;
> - unsigned long s0;
> - unsigned long s1;
> - unsigned long a0;
> - unsigned long a1;
> - unsigned long a2;
> - unsigned long a3;
> - unsigned long a4;
> - unsigned long a5;
> - unsigned long a6;
> - unsigned long a7;
> - unsigned long s2;
> - unsigned long s3;
> - unsigned long s4;
> - unsigned long s5;
> - unsigned long s6;
> - unsigned long s7;
> - unsigned long s8;
> - unsigned long s9;
> - unsigned long s10;
> - unsigned long s11;
> - unsigned long t3;
> - unsigned long t4;
> - unsigned long t5;
> - unsigned long t6;
> -};
> -
> struct user_fpregs_struct {
> double f[32];
> unsigned int fcsr;
> --
> 2.20.1
It's not just that struct but the whole file. I've got the removal
already committed here though, pending push with a queue of stuff from
the list. Thanks.
Rich
prev parent reply other threads:[~2019-08-06 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 17:47 Baruch Siach
2019-08-06 17:50 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806175006.GZ9017@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).