* [PATCH v2] remove riscv64 user_regs_struct
@ 2019-08-06 17:47 Baruch Siach
2019-08-06 17:50 ` Rich Felker
0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2019-08-06 17:47 UTC (permalink / raw)
To: Rich Felker; +Cc: musl, Baruch Siach
user_regs_struct removal fixes possible conflict with the kernel
definition of the same struct in asm/ptrace.h. glibc does not define
user_regs_struct for riscv either.
---
v2: Remove user_regs_struct entirely following feedback from Rich and
Szabolcs
---
arch/riscv64/bits/user.h | 35 -----------------------------------
1 file changed, 35 deletions(-)
diff --git a/arch/riscv64/bits/user.h b/arch/riscv64/bits/user.h
index bd0f0fc7027f..d2e383b24e53 100644
--- a/arch/riscv64/bits/user.h
+++ b/arch/riscv64/bits/user.h
@@ -1,38 +1,3 @@
-struct user_regs_struct {
- unsigned long pc;
- unsigned long ra;
- unsigned long sp;
- unsigned long gp;
- unsigned long tp;
- unsigned long t0;
- unsigned long t1;
- unsigned long t2;
- unsigned long s0;
- unsigned long s1;
- unsigned long a0;
- unsigned long a1;
- unsigned long a2;
- unsigned long a3;
- unsigned long a4;
- unsigned long a5;
- unsigned long a6;
- unsigned long a7;
- unsigned long s2;
- unsigned long s3;
- unsigned long s4;
- unsigned long s5;
- unsigned long s6;
- unsigned long s7;
- unsigned long s8;
- unsigned long s9;
- unsigned long s10;
- unsigned long s11;
- unsigned long t3;
- unsigned long t4;
- unsigned long t5;
- unsigned long t6;
-};
-
struct user_fpregs_struct {
double f[32];
unsigned int fcsr;
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] remove riscv64 user_regs_struct
2019-08-06 17:47 [PATCH v2] remove riscv64 user_regs_struct Baruch Siach
@ 2019-08-06 17:50 ` Rich Felker
0 siblings, 0 replies; 2+ messages in thread
From: Rich Felker @ 2019-08-06 17:50 UTC (permalink / raw)
To: musl
On Tue, Aug 06, 2019 at 08:47:29PM +0300, Baruch Siach wrote:
> user_regs_struct removal fixes possible conflict with the kernel
> definition of the same struct in asm/ptrace.h. glibc does not define
> user_regs_struct for riscv either.
> ---
> v2: Remove user_regs_struct entirely following feedback from Rich and
> Szabolcs
> ---
> arch/riscv64/bits/user.h | 35 -----------------------------------
> 1 file changed, 35 deletions(-)
>
> diff --git a/arch/riscv64/bits/user.h b/arch/riscv64/bits/user.h
> index bd0f0fc7027f..d2e383b24e53 100644
> --- a/arch/riscv64/bits/user.h
> +++ b/arch/riscv64/bits/user.h
> @@ -1,38 +1,3 @@
> -struct user_regs_struct {
> - unsigned long pc;
> - unsigned long ra;
> - unsigned long sp;
> - unsigned long gp;
> - unsigned long tp;
> - unsigned long t0;
> - unsigned long t1;
> - unsigned long t2;
> - unsigned long s0;
> - unsigned long s1;
> - unsigned long a0;
> - unsigned long a1;
> - unsigned long a2;
> - unsigned long a3;
> - unsigned long a4;
> - unsigned long a5;
> - unsigned long a6;
> - unsigned long a7;
> - unsigned long s2;
> - unsigned long s3;
> - unsigned long s4;
> - unsigned long s5;
> - unsigned long s6;
> - unsigned long s7;
> - unsigned long s8;
> - unsigned long s9;
> - unsigned long s10;
> - unsigned long s11;
> - unsigned long t3;
> - unsigned long t4;
> - unsigned long t5;
> - unsigned long t6;
> -};
> -
> struct user_fpregs_struct {
> double f[32];
> unsigned int fcsr;
> --
> 2.20.1
It's not just that struct but the whole file. I've got the removal
already committed here though, pending push with a queue of stuff from
the list. Thanks.
Rich
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-06 17:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-06 17:47 [PATCH v2] remove riscv64 user_regs_struct Baruch Siach
2019-08-06 17:50 ` Rich Felker
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).