From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [musl] [PATCH 2/2] Add big-endian support to ARM assembler memcpy
Date: Wed, 15 Jan 2020 10:45:53 -0500 [thread overview]
Message-ID: <20200115154553.GH30412@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAJ86T=VEswD5oSoNhLK_S5wdB9dcv6X2yPfFCdWcc6SfMWRM=A@mail.gmail.com>
On Fri, Sep 13, 2019 at 01:38:34PM -0700, Andre McCurdy wrote:
> On Fri, Sep 13, 2019 at 11:59 AM Rich Felker <dalias@libc.org> wrote:
> >
> > On Fri, Sep 13, 2019 at 11:44:32AM -0700, Andre McCurdy wrote:
> > > Allow the existing ARM assembler memcpy implementation to be used for
> > > both big and little endian targets.
> >
> > Nice. I don't want to merge this just before release, but as long as
> > it looks ok I should be able to review and merge it afterward.
> >
> > Note that I'd really like to replace this giant file with C using
> > inline asm just for the inner block copies and C for all the flow
> > control, but I don't mind merging this first as long as it's correct.
>
> Sounds good. I'll wait for your feedback after the upcoming release.
Sorry this dropped off my radar. I'd like to merge at least the thumb
part since it's simple enough to review quickly and users have
actually complained about memcpy being slow on armv7 with -mthumb as
default.
Rich
next prev parent reply other threads:[~2020-01-15 15:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 18:44 [PATCH 1/2] Add Thumb2 " Andre McCurdy
2019-09-13 18:44 ` [PATCH 2/2] Add big-endian " Andre McCurdy
2019-09-13 18:59 ` Rich Felker
2019-09-13 20:38 ` Andre McCurdy
2020-01-15 15:45 ` Rich Felker [this message]
2020-01-15 18:41 ` [musl] " Andre McCurdy
2020-01-15 19:22 ` Rich Felker
2020-01-15 20:54 ` Andre McCurdy
2020-01-16 15:21 ` Natanael Copa
2020-01-15 16:35 ` [musl] [PATCH 1/2] Add Thumb2 " Rich Felker
2020-01-15 18:49 ` Andre McCurdy
2020-01-15 19:24 ` Rich Felker
2020-01-15 20:20 ` Andre McCurdy
2020-01-15 20:38 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115154553.GH30412@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).