mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: musl@lists.openwall.com, Michael Forney <mforney@mforney.org>,
	ALSA Development Mailing List <alsa-devel@alsa-project.org>,
	Takashi Iwai <tiwai@suse.com>,
	Baolin Wang <baolin.wang@linaro.org>,
	y2038 Mailman List <y2038@lists.linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Baolin Wang <baolin.wang7@gmail.com>
Subject: Re: [musl] Re: [alsa-devel] [PATCH v7 8/9] ALSA: add new 32-bit layout for snd_pcm_mmap_status/control
Date: Fri, 8 Oct 2021 13:20:10 -0400	[thread overview]
Message-ID: <20211008172010.GG7074@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAK8P3a2=X5tPppmcV4x9=pyodiPfoq=tA5jVKuMwA1nKJe=_bA@mail.gmail.com>

On Fri, Oct 08, 2021 at 02:37:12PM +0200, Arnd Bergmann wrote:
> On Fri, Oct 8, 2021 at 2:06 PM Rich Felker <dalias@libc.org> wrote:
> > On Fri, Oct 08, 2021 at 11:24:39AM +0200, Arnd Bergmann wrote:
> > >
> > > I've tried to understand this part of musl's convert_ioctl_struct(), but I just
> > > can't figure out whether it does the conversion based the on the layout that
> > > is currently used in the kernel, or based on the layout we should have been
> > > using, and would use with the above fix. Rich, can you help me here?
> >
> > If the attempted 64-bit ioctl is missing (ENOTTY), it does the
> > conversion to the legacy 32-bit one and retries with that, then
> > converts the results back to the 64-bit form.
> 
> I understand that it tries to do that.
> 
> The part that I'm not sure about is which of the two possible
> 64-bit forms it's using -- the broken one we have defined in the
> kernel headers, or the one we were trying to define but failed.

It's attempting to convert the intended format, not the one that the
uapi headers defined. That is, it's taking padded-to-64-bit values at
offsets 0 and 8 in __snd_pcm_mmap_control64, putting them at offsets 0
and 4 in the 32-bit struct, and padding them back to 64-bit in the
result.

Since applications would have been compiled with the buggy
(unintended) version of the uapi headers, this will not match the
application's layout of the struct. I haven't worked through what all
the consequences of that are, but I think some fix is needed here in
musl regardless of what happens on the kernel side.

Rich

      reply	other threads:[~2021-10-08 17:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191211212025.1981822-1-arnd@arndb.de>
     [not found] ` <20191211212025.1981822-9-arnd@arndb.de>
     [not found]   ` <29QBMJU8DE71E.2YZSH8IHT5HMH@mforney.org>
     [not found]     ` <s5hpmsh9kdx.wl-tiwai@suse.de>
     [not found]       ` <CAK8P3a0K3XtjiszC3XWgG0L8+AgO+xUGr_KEAnb9a5GmyecoUQ@mail.gmail.com>
     [not found]         ` <s5hee8x9f92.wl-tiwai@suse.de>
2021-10-07 13:11           ` Arnd Bergmann
2021-10-07 15:33             ` Takashi Iwai
2021-10-07 16:06               ` Rich Felker
2021-10-07 16:18                 ` Takashi Iwai
2021-10-07 16:51                   ` Rich Felker
2021-10-08  8:43                     ` Takashi Iwai
2021-10-08  8:44                       ` Takashi Iwai
2021-10-08  9:24                       ` Arnd Bergmann
2021-10-08 11:11                         ` Takashi Iwai
2021-10-08 11:45                           ` Arnd Bergmann
2021-10-08 11:53                             ` Takashi Iwai
2021-10-08 12:13                               ` Arnd Bergmann
2021-10-08 12:07                           ` Rich Felker
2021-10-10  7:53                             ` Takashi Iwai
2021-10-18 14:43                               ` Rich Felker
2021-10-18 14:58                                 ` Takashi Iwai
2021-10-18 15:08                                   ` Rich Felker
2021-10-18 15:26                                     ` Arnd Bergmann
2021-10-18 20:42                                       ` Rich Felker
2021-10-19 14:16                                         ` Rich Felker
2021-10-19 14:23                                           ` Arnd Bergmann
2021-10-08 12:06                         ` Rich Felker
2021-10-08 12:37                           ` Arnd Bergmann
2021-10-08 17:20                             ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211008172010.GG7074@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=baolin.wang7@gmail.com \
    --cc=baolin.wang@linaro.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mforney@mforney.org \
    --cc=musl@lists.openwall.com \
    --cc=tiwai@suse.com \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).