From: John Spencer <maillist-musl@barfooze.de>
To: musl@lists.openwall.com
Subject: Re: [PATCH] Add support for mkostemp, mkstemps and mkostemps
Date: Sat, 02 Feb 2013 20:59:21 +0100 [thread overview]
Message-ID: <510D7019.3070907@barfooze.de> (raw)
In-Reply-To: <510D6E30.60206@barfooze.de>
[-- Attachment #1: Type: text/plain, Size: 115 bytes --]
On 02/02/2013 08:51 PM, John Spencer wrote:
> here's my version:
>
>
oops, forgot to pass O_RDWR, here's a fixup
[-- Attachment #2: 0001-fix-O_RDWR-not-being-passed-to-mkostemps.patch --]
[-- Type: text/x-patch, Size: 1147 bytes --]
From ebdecbd45156c5525fe2483982c77fab484bb946 Mon Sep 17 00:00:00 2001
From: rofl0r <retnyg@gmx.net>
Date: Sat, 2 Feb 2013 20:58:32 +0100
Subject: [PATCH] fix O_RDWR not being passed to mkostemps
---
src/temp/mkstemp.c | 3 ++-
src/temp/mkstemps.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/temp/mkstemp.c b/src/temp/mkstemp.c
index 07ec4d7..17bfcbb 100644
--- a/src/temp/mkstemp.c
+++ b/src/temp/mkstemp.c
@@ -1,10 +1,11 @@
#include "libc.h"
+#include <fcntl.h>
int __mkostemps (char *template, int suffixlen, int flags);
int mkstemp(char *template)
{
- return __mkostemps(template, 0, 0);
+ return __mkostemps(template, 0, O_RDWR);
}
LFS64(mkstemp);
diff --git a/src/temp/mkstemps.c b/src/temp/mkstemps.c
index 6d16d9c..caad441 100644
--- a/src/temp/mkstemps.c
+++ b/src/temp/mkstemps.c
@@ -1,10 +1,11 @@
+#include <fcntl.h>
#include "libc.h"
int __mkostemps (char *template, int suffixlen, int flags);
int mkstemps (char *template, int suffixlen)
{
- return __mkostemps(template, suffixlen, 0);
+ return __mkostemps(template, suffixlen, O_RDWR);
}
LFS64(mkstemps);
--
1.7.3.4
next prev parent reply other threads:[~2013-02-02 19:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-02 18:45 Anthony G. Basile
2013-02-02 19:51 ` John Spencer
2013-02-02 19:59 ` John Spencer [this message]
2013-02-02 22:11 ` Szabolcs Nagy
2013-02-02 20:14 ` Szabolcs Nagy
2013-02-02 20:38 ` Anthony G. Basile
2013-02-02 22:22 ` Szabolcs Nagy
-- strict thread matches above, loose matches on Subject: below --
2013-02-02 21:15 Anthony G. Basile
2013-02-02 21:17 ` Anthony G. Basile
2013-02-03 3:30 ` Rich Felker
2013-01-28 5:06 Anthony G. Basile
2013-01-28 8:47 ` John Spencer
2013-01-28 9:37 ` Szabolcs Nagy
2013-01-28 17:33 ` Szabolcs Nagy
2013-01-29 23:16 ` Anthony G. Basile
2013-01-30 7:21 ` Rich Felker
2013-01-30 7:59 ` Hardy Falk
2013-01-30 13:45 ` Szabolcs Nagy
2013-01-30 16:51 ` Rich Felker
2013-01-30 19:12 ` Szabolcs Nagy
2013-01-30 19:22 ` Rich Felker
2013-01-31 0:28 ` Szabolcs Nagy
2013-01-28 16:33 ` Rich Felker
2013-02-02 3:48 ` Rich Felker
2013-02-02 18:46 ` Anthony G. Basile
2013-01-28 2:36 Anthony G. Basile
2013-01-28 5:01 ` Anthony G. Basile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510D7019.3070907@barfooze.de \
--to=maillist-musl@barfooze.de \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).