From: "Anthony G. Basile" <basile@opensource.dyc.edu>
To: musl@lists.openwall.com
Subject: Re: [PATCH] Add support for mkostemp, mkstemps and mkostemps
Date: Sat, 02 Feb 2013 16:17:36 -0500 [thread overview]
Message-ID: <510D8270.5060808@opensource.dyc.edu> (raw)
In-Reply-To: <1359839705-25965-1-git-send-email-basile@opensource.dyc.edu>
Okay a few points about my last patch.
1. I removed lots of unnecessary headers.
2. I tested using:
strcpy(t, "aaaXXXXXX");
mktemp(t);
printf("mktemp = %s\n", t);
strcpy(t, "aaaXXXXXX");
fd = mkstemp(t);
printf("mkstemp = %s\n", t);
report_close(fd);
//unlink(t);
strcpy(t, "aaaXXXXXX");
fd = mkostemp(t, O_WRONLY|O_CLOEXEC);
printf("mkostemp = %s\n", t);
report_close(fd);
//unlink(t);
strcpy(t, "aaaXXXXXXzzz");
fd = mkstemps(t, 3);
printf("mkstemps = %s\n", t);
report_close(fd);
//unlink(t);
strcpy(t, "aaaXXXXXXzzz");
fd = mkostemps(t, 3, O_WRONLY|O_CLOEXEC);
printf("mkostemps = %s\n", t);
report_close(fd);
//unlink(t);
3. I went with Szabolcs' function to generate entropy:
for (i=0; i<6; i++, r>>=5)
template[i] = 'A'+(r&15)+(r&16)*2;
I think we can commit this (baring any other problems) and think about
improving it in the future. As I said before, uclibc/glibc give
filenames which include:
static const char letters[] =
"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
while 'A'+(r&15)+(r&16)*2 gives A-P a-p. So the space of names for the
former is 62^6 while for the latter is 32^6.
--
Anthony G. Basile, Ph. D.
Chair of Information Technology
D'Youville College
Buffalo, NY 14201
(716) 829-8197
next prev parent reply other threads:[~2013-02-02 21:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-02 21:15 Anthony G. Basile
2013-02-02 21:17 ` Anthony G. Basile [this message]
2013-02-03 3:30 ` Rich Felker
-- strict thread matches above, loose matches on Subject: below --
2013-02-02 18:45 Anthony G. Basile
2013-02-02 19:51 ` John Spencer
2013-02-02 19:59 ` John Spencer
2013-02-02 22:11 ` Szabolcs Nagy
2013-02-02 20:14 ` Szabolcs Nagy
2013-02-02 20:38 ` Anthony G. Basile
2013-02-02 22:22 ` Szabolcs Nagy
2013-01-28 5:06 Anthony G. Basile
2013-01-28 8:47 ` John Spencer
2013-01-28 9:37 ` Szabolcs Nagy
2013-01-28 17:33 ` Szabolcs Nagy
2013-01-29 23:16 ` Anthony G. Basile
2013-01-30 7:21 ` Rich Felker
2013-01-30 7:59 ` Hardy Falk
2013-01-30 13:45 ` Szabolcs Nagy
2013-01-30 16:51 ` Rich Felker
2013-01-30 19:12 ` Szabolcs Nagy
2013-01-30 19:22 ` Rich Felker
2013-01-31 0:28 ` Szabolcs Nagy
2013-01-28 16:33 ` Rich Felker
2013-02-02 3:48 ` Rich Felker
2013-02-02 18:46 ` Anthony G. Basile
2013-01-28 2:36 Anthony G. Basile
2013-01-28 5:01 ` Anthony G. Basile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510D8270.5060808@opensource.dyc.edu \
--to=basile@opensource.dyc.edu \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).