From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: linux-api@vger.kernel.org, musl@lists.openwall.com,
libc-dev@lists.llvm.org, linuxppc-dev@lists.ozlabs.org,
Nicholas Piggin <npiggin@gmail.com>
Subject: [musl] Re: [PATCH 2/2] powerpc/64s: system call support for scv/rfscv instructions
Date: Fri, 24 Jul 2020 20:45:36 +1000 [thread overview]
Message-ID: <87v9idp4xb.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20200723184814.Horde.pk5BO9iFqyGX5D4TW5wqmg1@messagerie.si.c-s.fr>
Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Michael Ellerman <mpe@ellerman.id.au> a écrit :
>
>> Nicholas Piggin <npiggin@gmail.com> writes:
>>> diff --git a/arch/powerpc/include/asm/ppc-opcode.h
>>> b/arch/powerpc/include/asm/ppc-opcode.h
>>> index 2a39c716c343..b2bdc4de1292 100644
>>> --- a/arch/powerpc/include/asm/ppc-opcode.h
>>> +++ b/arch/powerpc/include/asm/ppc-opcode.h
>>> @@ -257,6 +257,7 @@
>>> #define PPC_INST_MFVSRD 0x7c000066
>>> #define PPC_INST_MTVSRD 0x7c000166
>>> #define PPC_INST_SC 0x44000002
>>> +#define PPC_INST_SCV 0x44000001
>> ...
>>> @@ -411,6 +412,7 @@
>> ...
>>> +#define __PPC_LEV(l) (((l) & 0x7f) << 5)
>>
>> These conflicted and didn't seem to be used so I dropped them.
>>
>>> diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c
>>> index 5abe98216dc2..161bfccbc309 100644
>>> --- a/arch/powerpc/lib/sstep.c
>>> +++ b/arch/powerpc/lib/sstep.c
>>> @@ -3378,6 +3382,16 @@ int emulate_step(struct pt_regs *regs,
>>> struct ppc_inst instr)
>>> regs->msr = MSR_KERNEL;
>>> return 1;
>>>
>>> + case SYSCALL_VECTORED_0: /* scv 0 */
>>> + regs->gpr[9] = regs->gpr[13];
>>> + regs->gpr[10] = MSR_KERNEL;
>>> + regs->gpr[11] = regs->nip + 4;
>>> + regs->gpr[12] = regs->msr & MSR_MASK;
>>> + regs->gpr[13] = (unsigned long) get_paca();
>>> + regs->nip = (unsigned long) &system_call_vectored_emulate;
>>> + regs->msr = MSR_KERNEL;
>>> + return 1;
>>> +
>>
>> This broke the ppc64e build:
>>
>> ld: arch/powerpc/lib/sstep.o:(.toc+0x0): undefined reference to
>> `system_call_vectored_emulate'
>> make[1]: *** [/home/michael/linux/Makefile:1139: vmlinux] Error 1
>>
>> I wrapped it in #ifdef CONFIG_PPC64_BOOK3S.
>
> You mean CONFIG_PPC_BOOK3S_64 ?
I hope so ...
#### ## ####.
Will send a fixup. Thanks for noticing.
cheers
next prev parent reply other threads:[~2020-07-24 11:06 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 8:12 [musl] Linux powerpc new system call instruction and ABI Nicholas Piggin
2020-06-11 8:12 ` [musl] [PATCH 1/2] powerpc/64s/exception: treat NIA below __end_interrupts as soft-masked Nicholas Piggin
2020-07-24 13:25 ` [musl] " Michael Ellerman
2020-06-11 8:12 ` [musl] [PATCH 2/2] powerpc/64s: system call support for scv/rfscv instructions Nicholas Piggin
2020-07-23 6:47 ` [musl] " Michael Ellerman
2020-07-23 16:48 ` Christophe Leroy
2020-07-24 10:45 ` Michael Ellerman [this message]
2020-06-11 21:02 ` [musl] Re: Linux powerpc new system call instruction and ABI Segher Boessenkool
2020-06-14 9:26 ` Nicholas Piggin
2021-05-18 23:13 ` Dmitry V. Levin
2021-05-19 2:50 ` Nicholas Piggin
2021-05-19 5:01 ` Nicholas Piggin
2021-05-21 19:40 ` Matheus Castanho
2021-05-21 19:52 ` Florian Weimer
2021-05-21 20:00 ` Matheus Castanho
2021-05-21 20:52 ` Dmitry V. Levin
2021-05-24 12:11 ` Matheus Castanho
2021-05-24 20:33 ` Matheus Castanho
2021-05-19 10:24 ` Dmitry V. Levin
2021-05-19 10:59 ` Nicholas Piggin
2021-05-19 12:39 ` Tulio Magno Quites Machado Filho
2021-05-19 13:26 ` Dmitry V. Levin
2021-05-19 22:51 ` Nicholas Piggin
2021-05-19 23:27 ` Dmitry V. Levin
2021-05-20 2:40 ` Nicholas Piggin
2021-05-20 3:06 ` Dmitry V. Levin
2021-05-20 5:12 ` Nicholas Piggin
2021-05-19 7:33 ` Joakim Tjernlund
2021-05-19 7:55 ` Nicholas Piggin
2021-05-19 8:08 ` Joakim Tjernlund
2021-05-19 8:42 ` Nicholas Piggin
2021-05-19 11:12 ` Nicholas Piggin
2021-05-19 14:38 ` Segher Boessenkool
2021-05-19 15:06 ` Joakim Tjernlund
2021-05-19 15:22 ` Segher Boessenkool
2021-05-19 15:36 ` Rich Felker
2021-05-19 18:09 ` Joakim Tjernlund
2021-05-19 23:48 ` Rich Felker
2021-05-20 1:06 ` Dmitry V. Levin
2021-05-20 2:45 ` Nicholas Piggin
2021-05-20 2:59 ` Dmitry V. Levin
2021-05-20 7:20 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9idp4xb.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=christophe.leroy@csgroup.eu \
--cc=libc-dev@lists.llvm.org \
--cc=linux-api@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=musl@lists.openwall.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).