From: "Matthias Görgens" <matthias.goergens@gmail.com>
To: musl@lists.openwall.com
Subject: Re: [musl] [PATCH v3] Fix UB in getmntent_r on extremely long lines
Date: Tue, 11 Apr 2023 22:38:57 +0800 [thread overview]
Message-ID: <CA+X7ob_BeAOWb_sb_7C9s+ap7fi3oYYG86qNMsaD8Urdim2ovA@mail.gmail.com> (raw)
In-Reply-To: <20230411143231.GL4163@brightrain.aerifal.cx>
[-- Attachment #1: Type: text/plain, Size: 761 bytes --]
On Tue, 11 Apr 2023, 22:32 Rich Felker, <dalias@libc.org> wrote:
> Can you do this as a one-line change to restart the loop like I
> suggested? I know the resulting code arguably isn't as pretty to folks
> with an allergy to gotos, but the more important aspect is that the
> change history is clear and obvious to anyone who wants to read it, to
> see that no change except the one described is being made by the
> patch.
>
Thanks for the quick response on the channel!
Sure, I can use the goto, if you prefer that.
Btw, I agree that the diff with the loop looks a bit big in the email. But
when you look at it with `git show --ignore-all-space` it's about the same
size of diff as the goto. (And that's how I typically review history of a
repository.)
>
[-- Attachment #2: Type: text/html, Size: 1356 bytes --]
prev parent reply other threads:[~2023-04-11 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 5:08 Matthias Goergens
2023-04-11 14:32 ` Rich Felker
2023-04-11 14:38 ` Matthias Görgens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+X7ob_BeAOWb_sb_7C9s+ap7fi3oYYG86qNMsaD8Urdim2ovA@mail.gmail.com \
--to=matthias.goergens@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).