From: "Érico Nogueira" <ericonr@disroot.org>
To: <musl@lists.openwall.com>
Cc: <monk@unboiled.info>
Subject: Re: [musl] $ORIGIN rpath expansion without /proc: code looks wrong
Date: Thu, 18 Nov 2021 16:21:13 -0300 [thread overview]
Message-ID: <CFT5E45O9EIZ.B4QEQ40XC711@mussels> (raw)
In-Reply-To: <CAH8yC8kMGYxwNeYWDnRF3Qv-P9Oa-34B2sCAhCC+v8SshUms-w@mail.gmail.com>
On Wed Nov 17, 2021 at 5:01 PM -03, Jeffrey Walton wrote:
> On Wed, Nov 17, 2021 at 12:09 PM Érico Nogueira <ericonr@disroot.org>
> wrote:
> >
> > On Wed Nov 17, 2021 at 11:04 AM -03, Alexander Sosedkin wrote:
> > > ...
> > > Could somebody take a look at this and double-check that
> > > this codepath makes sense?
> >
> > It does, but it might not be as robust as you wish. fixup_rpath() treats
> > the RPATH entry as a single string, and does all $ORIGIN substitutions
> > in one go (what splits the string by ":" is open_path()). This means
> > that the entire RPATH entry containing $ORIGIN will be ignored if
> > /proc/self/exe can't be accessed, despite one or more of them not
> > depending on $ORIGIN.
>
> This has come up before on the list. It is different behavior from
> libc, and it may be CVE worthy if a down-level library is used when an
> updated library is available but lost because the RPATH/RUNPATH is
> discarded.
I would file such a CVE on the distro packaging or system administration
rather than musl. The binaries you need to run so /proc is mounted
shouldn't be the sort that depend on dynamic RPATH using ${ORIGIN}
(rather than a static one or no RPATH at all), and any security fix
should be confirmed to actually work before being deployed...
Furthermore, I don't think an unprivileged user should be able to
unmount /proc unless they have called prctl(PR_SET_NO_NEW_PRIVS, 1), no?
Which would make any "attacks" be directed at themselves.
>
> Jeff
next prev parent reply other threads:[~2021-11-18 19:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 14:04 Alexander Sosedkin
2021-11-17 17:00 ` Érico Nogueira
2021-11-17 19:25 ` Alexander Sosedkin
2021-11-18 19:15 ` Érico Nogueira
2021-11-17 20:01 ` Jeffrey Walton
2021-11-18 19:21 ` Érico Nogueira [this message]
2021-11-18 19:41 ` Alexander Sosedkin
2021-11-18 19:42 ` Jeffrey Walton
2021-11-18 20:30 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CFT5E45O9EIZ.B4QEQ40XC711@mussels \
--to=ericonr@disroot.org \
--cc=monk@unboiled.info \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).