Changed behavior from \convertnumber{arabicdecimals}{..} as a textcommand for note

Changed behavior from \convertnumber{arabicdecimals}{..} as a textcommand for note

[musa furber via ntg-context]

[-- Attachment #1.1: Type: text/plain, Size: 876 bytes --]

This week I updated ConTeXt minimals. Before then, I used the following
code so that footnotes to Arabic passages would have parenthesis around
them and use the digits used in Arabic texts in the Middle East (e.g.
٠١٢٣٤٥٦٧٨٩).

\setupnote [arfootnote] [
  headstyle={\switchtobodyfont[kitab]},
  textcommand=\footnotenotenumbercommand,
  alternative=text,
  ]
\define[1]\footnotenotenumbercommand{{\high{(\convertnumber{arabicdecimals}{#1})}}}

Since the update, for the 123rd footnote, I now get `(123arabic)` instead
of `(١٢٣)`.

Elsewhere, I do get the expected output (i.e. `١٢٣٢`) when calling
\convertnumber{arabicdecimals}{1232}

I'm still relatively new to ConTeXt, so I'm unsure if what used really is
correct, or if it was wrong and I now need to find the right way to do it.

Any help would be greatly appreciated.

—Musa

[-- Attachment #1.2: Type: text/html, Size: 1093 bytes --]

[-- Attachment #2: Type: text/plain, Size: 493 bytes --]

___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://context.aanhet.net
archive  : https://bitbucket.org/phg/context-mirror/commits/
wiki     : http://contextgarden.net
___________________________________________________________________________________

Re: Changed behavior from \convertnumber{arabicdecimals}{..} as a textcommand for note

[Hans Hagen via ntg-context]

On 1/15/2022 3:03 AM, musa furber via ntg-context wrote:
> This week I updated ConTeXt minimals. Before then, I used the following 
> code so that footnotes to Arabic passages would have parenthesis around 
> them and use the digits used in Arabic texts in the Middle East (e.g. 
> ٠١٢٣٤٥٦٧٨٩).
> 
> \setupnote [arfootnote] [
>    headstyle={\switchtobodyfont[kitab]},
>    textcommand=\footnotenotenumbercommand,
>    alternative=text,
>    ]
> \define[1]\footnotenotenumbercommand{{\high{(\convertnumber{arabicdecimals}{#1})}}}
> 
> Since the update, for the 123rd footnote, I now get `(123arabic)` 
> instead of `(١٢٣)`.
> 
> Elsewhere, I do get the expected output (i.e. `١٢٣٢`) when calling
> \convertnumber{arabicdecimals}{1232}
> 
> I'm still relatively new to ConTeXt, so I'm unsure if what used really 
> is correct, or if it was wrong and I now need to find the right way to 
> do it.
> 
> Any help would be greatly appreciated.
Next time give a complete MWE with useable fonts

   \setupnotation
     [arfootnote]
      [numberconversion=arabicdecimals]

as in:

\setupbodyfont[dejavu]

\definenote
   [arfootnote]

\setupnotation
   [arfootnote]
   [numberconversion=arabicdecimals]

\setupnote
   [arfootnote]
   [headstyle={\switchtobodyfont[kitab]},
    textcommand=\footnotenotenumbercommand,
    alternative=text]

\protected\def\footnotenotenumbercommand#1{\high{(#1)}}

\starttext
     x\arfootnote{x}
\stoptext

The #1 passed can be anything that renderes the note so the converters 
sees rubish. You can see details with you add

\detokenize{#1}

in your macro.

Hans
-----------------------------------------------------------------
                                           Hans Hagen | PRAGMA ADE
               Ridderstraat 27 | 8061 GH Hasselt | The Netherlands
        tel: 038 477 53 69 | www.pragma-ade.nl | www.pragma-pod.nl
-----------------------------------------------------------------
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://context.aanhet.net
archive  : https://bitbucket.org/phg/context-mirror/commits/
wiki     : http://contextgarden.net
___________________________________________________________________________________

Re: Changed behavior from \convertnumber{arabicdecimals}{..} as a textcommand for note

[musa furber via ntg-context]

[-- Attachment #1.1: Type: text/plain, Size: 2422 bytes --]

Dear Hans,

Thank you for your reply.

Here is the missing MWE. (I will also try to attach it.)

% mwe
% document is an English translation of Arabic text; all annotations are in
English.
%
% concerning footnotes to Arabic text:
%   numbers in body should use Mashriki numbers (e.g. ٠١٢٣٤٥٦٧٨٩), and
appear between parenthesis
%   numbers in footer should use Arabic numbers (e.g. 0123456789), and
without parenthesis
%
% MWE uses dejavu for English and Amiri for and Arabic. Amiri is availble
at https://www.amirifont.org/

\mainlanguage[en-gb]

\setupdirections[bidi=global,method=one]

\starttypescriptcollection [amiri]

    \starttypescript [serif] [amiri]
        \definefontsynonym [Serif] [file:Amiri-Regular.ttf]
[features=arabic]
    \stoptypescript

    \starttypescript [amiri]
       \definetypeface [amiri] [rm] [serif] [amiri] [default]
[fallbacks=latin-fallback]
    \stoptypescript

\stoptypescriptcollection

\define\setarabic{
  \setupalign[r2l] \righttoleft \switchtobodyfont[amiri]
}

\define\setlatin{
  \setupalign[l2r] \lefttoright \switchtobodyfont[dejavu]
}


\setupnotes[footnote][]
\setupnotes[arfootnote][]

\definenote[arfootnote][footnote]
\setupnotation
    [arfootnote]
    [before=\setlatin,
     alternative=text,
    ]

\setupnote
    [arfootnote]
    [headstyle={\switchtobodyfont[amiri]},
     textcommand=\footnotenotenumbercommand,
     alternative=text,
     ]

\protected\def\footnotenotenumbercommand#1{{\high{({\convertnumber{arabicdecimals}{#1}})}}}
% unexpected results
%
\protected\def\footnotenotenumbercommand#1{{\high{({\convertnumber{abjadnumerals}{#1}})}}}
%
\protected\def\footnotenotenumbercommand#1{{\high{({\convertnumber{default}{#1}})}}}
%
% `\detokenize' variations, for comparison...
%
%
\protected\def\footnotenotenumbercommand#1{{\high{(\detokenize{\convertnumber{arabicdecimals}{#1}})}}}
%
\protected\def\footnotenotenumbercommand#1{{\high{(\detokenize{\convertnumber{abjadnumerals}{#1}})}}}
%
\protected\def\footnotenotenumbercommand#1{{\high{(\detokenize{\convertnumber{default}{#1}})}}}

\setupbodyfont[dejavu,11pt]

\starttext
\setarabic

مرحبًا\arfootnote{Annotation text.} % expected footnote `(١)`, got `1arabic`

مرحبًا\arfootnote{Annotation text.} % expected footnote `(٢)`, got `2arabic`


\stoptext

%%% end of mwe

Thanks,
Musa

[-- Attachment #1.2: Type: text/html, Size: 2837 bytes --]

[-- Attachment #2: Type: text/plain, Size: 493 bytes --]

___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://context.aanhet.net
archive  : https://bitbucket.org/phg/context-mirror/commits/
wiki     : http://contextgarden.net
___________________________________________________________________________________