Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] gimp: build with libexecinfo on musl
@ 2019-05-05 18:51 voidlinux-github
  2019-05-05 19:04 ` voidlinux-github
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: voidlinux-github @ 2019-05-05 18:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

There is a new pull request by q66 against master on the void-packages repository

https://github.com/void-ppc64/void-packages gimp
https://github.com/void-linux/void-packages/pull/11521

gimp: build with libexecinfo on musl
Gimp unconditionally includes and uses execinfo.h in its app core library, which is used everywhere in gimp. If not installed, gimp will fail to compile. I'm actually not quite sure how it compiled for musl until now, but somehow it did.

See https://github.com/GNOME/gimp/blob/01f940990260146a860f6956ebd962b45b0fc961/app/core/gimpbacktrace-linux.c#L42

A patch file from https://github.com/void-linux/void-packages/pull/11521.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gimp-11521.patch --]
[-- Type: application/text/x-diff, Size: 1065 bytes --]

From bdc5df36239c1861122d01a0caa04b776db6446f Mon Sep 17 00:00:00 2001
From: q66 <daniel@octaforge.org>
Date: Sun, 5 May 2019 20:45:39 +0200
Subject: [PATCH] gimp: build with libexecinfo on musl

Gimp unconditionally includes and uses execinfo.h in its app
core library, which is used everywhere in gimp. If not installed,
gimp will fail to compile. I'm actually not quite sure how it
compiled for musl until now, but somehow it did.

[ci skip]
---
 srcpkgs/gimp/template | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/srcpkgs/gimp/template b/srcpkgs/gimp/template
index df60f8b6608..ce0a12b8825 100644
--- a/srcpkgs/gimp/template
+++ b/srcpkgs/gimp/template
@@ -21,6 +21,13 @@ distfiles="https://download.gimp.org/pub/gimp/v${version%.*}/gimp-${version}.tar
 checksum=12d1f243265c7aee1f2c6e97883a5c90ddc0b19b4346cf822e24adbb6c998c77
 lib32disabled=yes
 
+case "$XBPS_TARGET_MACHINE" in
+	*-musl)
+		makedepends+=" libexecinfo-devel"
+		LDFLAGS+=" -lexecinfo"
+	;;
+esac
+
 pre_configure() {
 	NOCONFIGURE=1 autoreconf -fi
 	if [ "$CROSS_BUILD" ]; then

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-05 19:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-05 18:51 [PR PATCH] gimp: build with libexecinfo on musl voidlinux-github
2019-05-05 19:04 ` voidlinux-github
2019-05-05 19:10 ` voidlinux-github
2019-05-05 19:19 ` voidlinux-github
2019-05-05 19:25 ` voidlinux-github
2019-05-05 19:25 ` [PR PATCH] [Closed]: " voidlinux-github

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).