[PR PATCH] gimp: build with libexecinfo on musl

[PR PATCH] gimp: build with libexecinfo on musl

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

There is a new pull request by q66 against master on the void-packages repository

https://github.com/void-ppc64/void-packages gimp
https://github.com/void-linux/void-packages/pull/11521

gimp: build with libexecinfo on musl
Gimp unconditionally includes and uses execinfo.h in its app core library, which is used everywhere in gimp. If not installed, gimp will fail to compile. I'm actually not quite sure how it compiled for musl until now, but somehow it did.

See https://github.com/GNOME/gimp/blob/01f940990260146a860f6956ebd962b45b0fc961/app/core/gimpbacktrace-linux.c#L42

A patch file from https://github.com/void-linux/void-packages/pull/11521.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gimp-11521.patch --]
[-- Type: application/text/x-diff, Size: 1065 bytes --]

From bdc5df36239c1861122d01a0caa04b776db6446f Mon Sep 17 00:00:00 2001
From: q66 <daniel@octaforge.org>
Date: Sun, 5 May 2019 20:45:39 +0200
Subject: [PATCH] gimp: build with libexecinfo on musl

Gimp unconditionally includes and uses execinfo.h in its app
core library, which is used everywhere in gimp. If not installed,
gimp will fail to compile. I'm actually not quite sure how it
compiled for musl until now, but somehow it did.

[ci skip]
---
 srcpkgs/gimp/template | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/srcpkgs/gimp/template b/srcpkgs/gimp/template
index df60f8b6608..ce0a12b8825 100644
--- a/srcpkgs/gimp/template
+++ b/srcpkgs/gimp/template
@@ -21,6 +21,13 @@ distfiles="https://download.gimp.org/pub/gimp/v${version%.*}/gimp-${version}.tar
 checksum=12d1f243265c7aee1f2c6e97883a5c90ddc0b19b4346cf822e24adbb6c998c77
 lib32disabled=yes
 
+case "$XBPS_TARGET_MACHINE" in
+	*-musl)
+		makedepends+=" libexecinfo-devel"
+		LDFLAGS+=" -lexecinfo"
+	;;
+esac
+
 pre_configure() {
 	NOCONFIGURE=1 autoreconf -fi
 	if [ "$CROSS_BUILD" ]; then

Re: gimp: build with libexecinfo on musl

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/11521#issuecomment-489454103
Comment:
Looks to me like it's only used on `__gnu_linux__`: https://github.com/GNOME/gimp/blob/01f940990260146a860f6956ebd962b45b0fc961/app/core/gimpbacktrace-backend.h#L25

Re: gimp: build with libexecinfo on musl

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/11521#issuecomment-489454607
Comment:
I see:

```
[q66@/home/q66/void-packages/masterdir-musl /]$ xbps-uhelper arch
ppc64le-musl
[q66@/home/q66/void-packages/masterdir-musl /]$ gcc -dM -E - < /dev/null|grep gnu_linux
#define __gnu_linux__ 1
```

Re: gimp: build with libexecinfo on musl

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/11521#issuecomment-489455286
Comment:
Looks like a problem in gcc specific to ppc64; additionally, this looks like it has been fixed upstream, see https://github.com/gcc-mirror/gcc/commit/cdfc600453447b283157b8bfdb2e9283fde2cead#diff-058e14c90a93b8e94ea4857186800d63 , the `rs6000/sysv4.h` changes.

Re: [PR PATCH] [Closed]: gimp: build with libexecinfo on musl

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

There's a closed pull request on the void-packages repository

gimp: build with libexecinfo on musl
https://github.com/void-linux/void-packages/pull/11521
Description: Gimp unconditionally includes and uses execinfo.h in its app core library, which is used everywhere in gimp. If not installed, gimp will fail to compile. I'm actually not quite sure how it compiled for musl until now, but somehow it did.

See https://github.com/GNOME/gimp/blob/01f940990260146a860f6956ebd962b45b0fc961/app/core/gimpbacktrace-linux.c#L42

Re: gimp: build with libexecinfo on musl

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/11521#issuecomment-489455761
Comment:
I will close this and patch gcc instead.