* [PR PATCH] youtube-dl: add required dependency: phantomjs
@ 2019-06-07 4:37 voidlinux-github
2019-06-07 8:29 ` voidlinux-github
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: voidlinux-github @ 2019-06-07 4:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
There is a new pull request by mustaqimM against master on the void-packages repository
https://github.com/mustaqimM/void-packages update_youtube-dl
https://github.com/void-linux/void-packages/pull/12244
youtube-dl: add required dependency: phantomjs
Some links require `phantomjs` or it will error out with:
```
[ytdl_hook] ERROR: PhantomJS executable not found in PATH, download it from http://phantomjs.org
[ytdl_hook] youtube-dl failed: unexpected error ocurred
Failed to recognize file format.
```
A patch file from https://github.com/void-linux/void-packages/pull/12244.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update_youtube-dl-12244.patch --]
[-- Type: application/text/x-diff, Size: 1056 bytes --]
From ea6e5630fea847d4ed285b4d526d5ccc3d6ffc0c Mon Sep 17 00:00:00 2001
From: mustaqim <mustaqim@pm.me>
Date: Fri, 7 Jun 2019 06:29:08 +0200
Subject: [PATCH] youtube-dl: add required dependency: phantomjs
---
srcpkgs/youtube-dl/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/youtube-dl/template b/srcpkgs/youtube-dl/template
index 3f19382f819..29cc9383785 100644
--- a/srcpkgs/youtube-dl/template
+++ b/srcpkgs/youtube-dl/template
@@ -7,7 +7,7 @@ wrksrc="$pkgname"
build_style=python-module
pycompile_module="youtube_dl"
hostmakedepends="python python3"
-depends="python"
+depends="python phantomjs"
short_desc="CLI program to download videos from YouTube and other sites (Python2)"
maintainer="Juan RP <xtraeme@voidlinux.org>"
license="Unlicense"
@@ -26,7 +26,7 @@ post_install() {
python3-youtube-dl_package() {
archs=noarch
- depends="python3"
+ depends="python3 phantomjs"
pycompile_module="youtube_dl"
alternatives="youtube-dl:youtube-dl:/usr/bin/youtube-dl3"
short_desc="${short_desc/2/3}"
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: youtube-dl: add required dependency: phantomjs
2019-06-07 4:37 [PR PATCH] youtube-dl: add required dependency: phantomjs voidlinux-github
@ 2019-06-07 8:29 ` voidlinux-github
2019-06-07 14:27 ` voidlinux-github
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-06-07 8:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/12244#issuecomment-499802758
Comment:
Hm I would prefer to keep this optional.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: youtube-dl: add required dependency: phantomjs
2019-06-07 4:37 [PR PATCH] youtube-dl: add required dependency: phantomjs voidlinux-github
2019-06-07 8:29 ` voidlinux-github
@ 2019-06-07 14:27 ` voidlinux-github
2019-06-07 14:28 ` voidlinux-github
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-06-07 14:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 146 bytes --]
New comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/12244#issuecomment-499906092
Comment:
me too.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: youtube-dl: add required dependency: phantomjs
2019-06-07 4:37 [PR PATCH] youtube-dl: add required dependency: phantomjs voidlinux-github
2019-06-07 8:29 ` voidlinux-github
2019-06-07 14:27 ` voidlinux-github
@ 2019-06-07 14:28 ` voidlinux-github
2019-06-07 14:29 ` voidlinux-github
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-06-07 14:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
New comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/12244#issuecomment-499906092
Comment:
me too. PhantomJS's development has been suspended and relies on old qt versions.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: youtube-dl: add required dependency: phantomjs
2019-06-07 4:37 [PR PATCH] youtube-dl: add required dependency: phantomjs voidlinux-github
` (2 preceding siblings ...)
2019-06-07 14:28 ` voidlinux-github
@ 2019-06-07 14:29 ` voidlinux-github
2019-06-07 15:33 ` voidlinux-github
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-06-07 14:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 298 bytes --]
New comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/12244#issuecomment-499906092
Comment:
me too. PhantomJS's development has been suspended and relies on old qt versions. youtube-dl on the other hand does work without it - at least for my usecases.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: youtube-dl: add required dependency: phantomjs
2019-06-07 4:37 [PR PATCH] youtube-dl: add required dependency: phantomjs voidlinux-github
` (3 preceding siblings ...)
2019-06-07 14:29 ` voidlinux-github
@ 2019-06-07 15:33 ` voidlinux-github
2019-06-07 15:57 ` [PR PATCH] [Closed]: " voidlinux-github
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-06-07 15:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/12244#issuecomment-499932339
Comment:
Additionally adding phantomjs as a dependency would break any architecture that is currently cross compiled (mainly ARM) since it is nocross.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Closed]: youtube-dl: add required dependency: phantomjs
2019-06-07 4:37 [PR PATCH] youtube-dl: add required dependency: phantomjs voidlinux-github
` (4 preceding siblings ...)
2019-06-07 15:33 ` voidlinux-github
@ 2019-06-07 15:57 ` voidlinux-github
2019-06-07 15:58 ` voidlinux-github
2019-06-07 16:04 ` voidlinux-github
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-06-07 15:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
There's a closed pull request on the void-packages repository
youtube-dl: add required dependency: phantomjs
https://github.com/void-linux/void-packages/pull/12244
Description: Some links require `phantomjs` or it will error out with:
```
[ytdl_hook] ERROR: PhantomJS executable not found in PATH, download it from http://phantomjs.org
[ytdl_hook] youtube-dl failed: unexpected error ocurred
Failed to recognize file format.
```
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: youtube-dl: add required dependency: phantomjs
2019-06-07 4:37 [PR PATCH] youtube-dl: add required dependency: phantomjs voidlinux-github
` (5 preceding siblings ...)
2019-06-07 15:57 ` [PR PATCH] [Closed]: " voidlinux-github
@ 2019-06-07 15:58 ` voidlinux-github
2019-06-07 16:04 ` voidlinux-github
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-06-07 15:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
New comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/12244#issuecomment-499941499
Comment:
Sorry, but we'll keep that optional for now.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: youtube-dl: add required dependency: phantomjs
2019-06-07 4:37 [PR PATCH] youtube-dl: add required dependency: phantomjs voidlinux-github
` (6 preceding siblings ...)
2019-06-07 15:58 ` voidlinux-github
@ 2019-06-07 16:04 ` voidlinux-github
7 siblings, 0 replies; 9+ messages in thread
From: voidlinux-github @ 2019-06-07 16:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/pull/12244#issuecomment-499943587
Comment:
I also agree with @Gottox and @Johnnynator
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-06-07 16:04 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-07 4:37 [PR PATCH] youtube-dl: add required dependency: phantomjs voidlinux-github
2019-06-07 8:29 ` voidlinux-github
2019-06-07 14:27 ` voidlinux-github
2019-06-07 14:28 ` voidlinux-github
2019-06-07 14:29 ` voidlinux-github
2019-06-07 15:33 ` voidlinux-github
2019-06-07 15:57 ` [PR PATCH] [Closed]: " voidlinux-github
2019-06-07 15:58 ` voidlinux-github
2019-06-07 16:04 ` voidlinux-github
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).