* Re: [PR PATCH] [Updated] ddgtk: fixes for recent vte python bindings + other changes
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
@ 2019-06-26 23:14 ` voidlinux-github
2019-06-26 23:14 ` voidlinux-github
` (19 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-26 23:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]
There is an updated pull request by reback00 against master on the void-packages repository
https://github.com/reback00/void-packages ddgtk-v0_1-fix-branch
https://github.com/void-linux/void-packages/pull/12710
ddgtk: fixes for recent vte python bindings + other changes
**Changes:**
1. Added additional dependencies against build warnings [template]
2. Updated for latest meson [patch]
3. Updated for latest python module (instead of deprecated `python3` module, used the new `python` module, according to: [https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types](https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types)) [patch]
4. Fixed breakage of write functionality due to recent changes in Vte python bindings (Explanation here: [https://github.com/Guake/guake/issues/1243#issuecomment-410208659](https://github.com/Guake/guake/issues/1243#issuecomment-410208659)) [patch]
#4 raised an error like this below which has been fixed:
```
Traceback (most recent call last):
File "/usr/local/share/ddgtk/ddgtk/main.py", line 154, in on_confirm_ok_clicked
self.dd()
File "/usr/local/share/ddgtk/ddgtk/main.py", line 125, in dd
self.terminal.feed_child(clear,-1)
TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)
```
A patch file from https://github.com/void-linux/void-packages/pull/12710.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ddgtk-v0_1-fix-branch-12710.patch --]
[-- Type: application/text/x-diff, Size: 3953 bytes --]
From 7491de760335fa96795539b8e0392b127ec812f5 Mon Sep 17 00:00:00 2001
From: reback00 <reback00@protonmail.com>
Date: Thu, 27 Jun 2019 16:35:39 +0600
Subject: [PATCH 1/2] ddgtk: fixes for recent vte python bindings + other
changes
---
.../ddgtk/patches/001-changes-for-v0.1.patch | 33 +++++++++++++++++++
srcpkgs/ddgtk/template | 5 +--
2 files changed, 36 insertions(+), 2 deletions(-)
create mode 100644 srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
diff --git a/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
new file mode 100644
index 00000000000..386b5fe5875
--- /dev/null
+++ b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
@@ -0,0 +1,33 @@
+diff -Naurp0 a/meson.build b/meson.build
+--- a/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/meson.build 2019-06-24 12:48:11.436750620 +0000
+@@ -3 +3 @@ project('ddgtk',
+- meson_version: '>= 0.40.0',
++ meson_version: '>= 0.50.0',
+diff -Naurp0 a/src/main.py b/src/main.py
+--- a/src/main.py 2017-10-15 19:48:45.000000000 +0000
++++ b/src/main.py 2019-06-24 12:50:46.519811815 +0000
+@@ -116 +116 @@ class Application():
+- #self.terminal.feed_child(self.command,-1)
++ #self.terminal.feed_child_binary(self.command.encode("utf-8"))
+@@ -125,4 +125,4 @@ class Application():
+- self.terminal.feed_child(clear,-1)
+- self.terminal.feed_child(wait,-1)
+- self.terminal.feed_child(self.umount,-1)
+- #self.terminal.feed_child(cmd,-1)
++ self.terminal.feed_child_binary(clear.encode("utf-8"))
++ self.terminal.feed_child_binary(wait.encode("utf-8"))
++ self.terminal.feed_child_binary(self.umount.encode("utf-8"))
++ #self.terminal.feed_child_binary(cmd.encode("utf-8"))
+@@ -130 +130 @@ class Application():
+- self.terminal.feed_child(self.command,-1)
++ self.terminal.feed_child_binary(self.command.encode("utf-8"))
+diff -Naurp0 a/src/meson.build b/src/meson.build
+--- a/src/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/src/meson.build 2019-06-24 12:48:51.950244132 +0000
+@@ -12 +12 @@ gnome.compile_resources('ddgtk',
+-python3 = import('python3')
++python3 = import('python')
+@@ -15 +15 @@ conf = configuration_data()
+-conf.set('PYTHON', python3.find_python().path())
++conf.set('PYTHON', python3.find_installation().path())
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index f97c362c1c5..84948070877 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -1,9 +1,10 @@
# Template file for 'ddgtk'
pkgname=ddgtk
version=0.1
-revision=1
+revision=2
build_style=meson
-hostmakedepends="pkg-config glib glib-devel"
+patch_args="-Np1"
+hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
maintainer="reback00 <reback00@protonmail.com>"
From f9cf4bdd7d96ef2b07f4894b05a339b9692a5770 Mon Sep 17 00:00:00 2001
From: reback00 <51861250+reback00@users.noreply.github.com>
Date: Thu, 27 Jun 2019 05:14:40 +0600
Subject: [PATCH 2/2] ddgtk: moved patch_args after checksum
---
srcpkgs/ddgtk/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index 84948070877..d5f27bb4093 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -3,7 +3,6 @@ pkgname=ddgtk
version=0.1
revision=2
build_style=meson
-patch_args="-Np1"
hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
@@ -12,3 +11,4 @@ license="GPL-3.0-or-later"
homepage="https://github.com/gort818/ddgtk"
distfiles="https://github.com/gort818/ddgtk/archive/${version}.tar.gz"
checksum=0386336681b24d648cdce3daa0c2b83c77a69773296e97a8427b67cbd27531ed
+patch_args="-Np1"
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR PATCH] [Updated] ddgtk: fixes for recent vte python bindings + other changes
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
2019-06-26 23:14 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-06-26 23:14 ` voidlinux-github
2019-06-27 8:23 ` voidlinux-github
` (18 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-26 23:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]
There is an updated pull request by reback00 against master on the void-packages repository
https://github.com/reback00/void-packages ddgtk-v0_1-fix-branch
https://github.com/void-linux/void-packages/pull/12710
ddgtk: fixes for recent vte python bindings + other changes
**Changes:**
1. Added additional dependencies against build warnings [template]
2. Updated for latest meson [patch]
3. Updated for latest python module (instead of deprecated `python3` module, used the new `python` module, according to: [https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types](https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types)) [patch]
4. Fixed breakage of write functionality due to recent changes in Vte python bindings (Explanation here: [https://github.com/Guake/guake/issues/1243#issuecomment-410208659](https://github.com/Guake/guake/issues/1243#issuecomment-410208659)) [patch]
#4 raised an error like this below which has been fixed:
```
Traceback (most recent call last):
File "/usr/local/share/ddgtk/ddgtk/main.py", line 154, in on_confirm_ok_clicked
self.dd()
File "/usr/local/share/ddgtk/ddgtk/main.py", line 125, in dd
self.terminal.feed_child(clear,-1)
TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)
```
A patch file from https://github.com/void-linux/void-packages/pull/12710.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ddgtk-v0_1-fix-branch-12710.patch --]
[-- Type: application/text/x-diff, Size: 3953 bytes --]
From 7491de760335fa96795539b8e0392b127ec812f5 Mon Sep 17 00:00:00 2001
From: reback00 <reback00@protonmail.com>
Date: Thu, 27 Jun 2019 16:35:39 +0600
Subject: [PATCH 1/2] ddgtk: fixes for recent vte python bindings + other
changes
---
.../ddgtk/patches/001-changes-for-v0.1.patch | 33 +++++++++++++++++++
srcpkgs/ddgtk/template | 5 +--
2 files changed, 36 insertions(+), 2 deletions(-)
create mode 100644 srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
diff --git a/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
new file mode 100644
index 00000000000..386b5fe5875
--- /dev/null
+++ b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
@@ -0,0 +1,33 @@
+diff -Naurp0 a/meson.build b/meson.build
+--- a/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/meson.build 2019-06-24 12:48:11.436750620 +0000
+@@ -3 +3 @@ project('ddgtk',
+- meson_version: '>= 0.40.0',
++ meson_version: '>= 0.50.0',
+diff -Naurp0 a/src/main.py b/src/main.py
+--- a/src/main.py 2017-10-15 19:48:45.000000000 +0000
++++ b/src/main.py 2019-06-24 12:50:46.519811815 +0000
+@@ -116 +116 @@ class Application():
+- #self.terminal.feed_child(self.command,-1)
++ #self.terminal.feed_child_binary(self.command.encode("utf-8"))
+@@ -125,4 +125,4 @@ class Application():
+- self.terminal.feed_child(clear,-1)
+- self.terminal.feed_child(wait,-1)
+- self.terminal.feed_child(self.umount,-1)
+- #self.terminal.feed_child(cmd,-1)
++ self.terminal.feed_child_binary(clear.encode("utf-8"))
++ self.terminal.feed_child_binary(wait.encode("utf-8"))
++ self.terminal.feed_child_binary(self.umount.encode("utf-8"))
++ #self.terminal.feed_child_binary(cmd.encode("utf-8"))
+@@ -130 +130 @@ class Application():
+- self.terminal.feed_child(self.command,-1)
++ self.terminal.feed_child_binary(self.command.encode("utf-8"))
+diff -Naurp0 a/src/meson.build b/src/meson.build
+--- a/src/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/src/meson.build 2019-06-24 12:48:51.950244132 +0000
+@@ -12 +12 @@ gnome.compile_resources('ddgtk',
+-python3 = import('python3')
++python3 = import('python')
+@@ -15 +15 @@ conf = configuration_data()
+-conf.set('PYTHON', python3.find_python().path())
++conf.set('PYTHON', python3.find_installation().path())
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index f97c362c1c5..84948070877 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -1,9 +1,10 @@
# Template file for 'ddgtk'
pkgname=ddgtk
version=0.1
-revision=1
+revision=2
build_style=meson
-hostmakedepends="pkg-config glib glib-devel"
+patch_args="-Np1"
+hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
maintainer="reback00 <reback00@protonmail.com>"
From f9cf4bdd7d96ef2b07f4894b05a339b9692a5770 Mon Sep 17 00:00:00 2001
From: reback00 <51861250+reback00@users.noreply.github.com>
Date: Thu, 27 Jun 2019 05:14:40 +0600
Subject: [PATCH 2/2] ddgtk: moved patch_args after checksum
---
srcpkgs/ddgtk/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index 84948070877..d5f27bb4093 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -3,7 +3,6 @@ pkgname=ddgtk
version=0.1
revision=2
build_style=meson
-patch_args="-Np1"
hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
@@ -12,3 +11,4 @@ license="GPL-3.0-or-later"
homepage="https://github.com/gort818/ddgtk"
distfiles="https://github.com/gort818/ddgtk/archive/${version}.tar.gz"
checksum=0386336681b24d648cdce3daa0c2b83c77a69773296e97a8427b67cbd27531ed
+patch_args="-Np1"
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: ddgtk: fixes for recent vte python bindings + other changes
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
2019-06-26 23:14 ` [PR PATCH] [Updated] " voidlinux-github
2019-06-26 23:14 ` voidlinux-github
@ 2019-06-27 8:23 ` voidlinux-github
2019-06-27 14:25 ` [PR PATCH] [Updated] " voidlinux-github
` (17 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-27 8:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
New comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/12710#issuecomment-506245929
Comment:
```
... + other changes ...
```
What are those other changes? Please update the commit message :)
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR PATCH] [Updated] ddgtk: fixes for recent vte python bindings + other changes
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (2 preceding siblings ...)
2019-06-27 8:23 ` voidlinux-github
@ 2019-06-27 14:25 ` voidlinux-github
2019-06-27 14:25 ` voidlinux-github
` (16 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-27 14:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]
There is an updated pull request by reback00 against master on the void-packages repository
https://github.com/reback00/void-packages ddgtk-v0_1-fix-branch
https://github.com/void-linux/void-packages/pull/12710
ddgtk: fixes for recent vte python bindings + other changes
**Changes:**
1. Added additional dependencies against build warnings [template]
2. Updated for latest meson [patch]
3. Updated for latest python module (instead of deprecated `python3` module, used the new `python` module, according to: [https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types](https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types)) [patch]
4. Fixed breakage of write functionality due to recent changes in Vte python bindings (Explanation here: [https://github.com/Guake/guake/issues/1243#issuecomment-410208659](https://github.com/Guake/guake/issues/1243#issuecomment-410208659)) [patch]
#4 raised an error like this below which has been fixed:
```
Traceback (most recent call last):
File "/usr/local/share/ddgtk/ddgtk/main.py", line 154, in on_confirm_ok_clicked
self.dd()
File "/usr/local/share/ddgtk/ddgtk/main.py", line 125, in dd
self.terminal.feed_child(clear,-1)
TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)
```
A patch file from https://github.com/void-linux/void-packages/pull/12710.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ddgtk-v0_1-fix-branch-12710.patch --]
[-- Type: application/text/x-diff, Size: 4050 bytes --]
From 7491de760335fa96795539b8e0392b127ec812f5 Mon Sep 17 00:00:00 2001
From: reback00 <reback00@protonmail.com>
Date: Thu, 27 Jun 2019 16:35:39 +0600
Subject: [PATCH 1/2] ddgtk: fixes for recent vte python bindings + other
changes
---
.../ddgtk/patches/001-changes-for-v0.1.patch | 33 +++++++++++++++++++
srcpkgs/ddgtk/template | 5 +--
2 files changed, 36 insertions(+), 2 deletions(-)
create mode 100644 srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
diff --git a/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
new file mode 100644
index 00000000000..386b5fe5875
--- /dev/null
+++ b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
@@ -0,0 +1,33 @@
+diff -Naurp0 a/meson.build b/meson.build
+--- a/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/meson.build 2019-06-24 12:48:11.436750620 +0000
+@@ -3 +3 @@ project('ddgtk',
+- meson_version: '>= 0.40.0',
++ meson_version: '>= 0.50.0',
+diff -Naurp0 a/src/main.py b/src/main.py
+--- a/src/main.py 2017-10-15 19:48:45.000000000 +0000
++++ b/src/main.py 2019-06-24 12:50:46.519811815 +0000
+@@ -116 +116 @@ class Application():
+- #self.terminal.feed_child(self.command,-1)
++ #self.terminal.feed_child_binary(self.command.encode("utf-8"))
+@@ -125,4 +125,4 @@ class Application():
+- self.terminal.feed_child(clear,-1)
+- self.terminal.feed_child(wait,-1)
+- self.terminal.feed_child(self.umount,-1)
+- #self.terminal.feed_child(cmd,-1)
++ self.terminal.feed_child_binary(clear.encode("utf-8"))
++ self.terminal.feed_child_binary(wait.encode("utf-8"))
++ self.terminal.feed_child_binary(self.umount.encode("utf-8"))
++ #self.terminal.feed_child_binary(cmd.encode("utf-8"))
+@@ -130 +130 @@ class Application():
+- self.terminal.feed_child(self.command,-1)
++ self.terminal.feed_child_binary(self.command.encode("utf-8"))
+diff -Naurp0 a/src/meson.build b/src/meson.build
+--- a/src/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/src/meson.build 2019-06-24 12:48:51.950244132 +0000
+@@ -12 +12 @@ gnome.compile_resources('ddgtk',
+-python3 = import('python3')
++python3 = import('python')
+@@ -15 +15 @@ conf = configuration_data()
+-conf.set('PYTHON', python3.find_python().path())
++conf.set('PYTHON', python3.find_installation().path())
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index f97c362c1c5..84948070877 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -1,9 +1,10 @@
# Template file for 'ddgtk'
pkgname=ddgtk
version=0.1
-revision=1
+revision=2
build_style=meson
-hostmakedepends="pkg-config glib glib-devel"
+patch_args="-Np1"
+hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
maintainer="reback00 <reback00@protonmail.com>"
From 8705d7f3a77505aac3db86e793a9ee764d683d0b Mon Sep 17 00:00:00 2001
From: reback00 <51861250+reback00@users.noreply.github.com>
Date: Thu, 27 Jun 2019 05:14:40 +0600
Subject: [PATCH 2/2] ddgtk: added fixes for recent vte python bindings, added
additional deps, updated for latest meson, adjusted to new python module name
---
srcpkgs/ddgtk/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index 84948070877..d5f27bb4093 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -3,7 +3,6 @@ pkgname=ddgtk
version=0.1
revision=2
build_style=meson
-patch_args="-Np1"
hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
@@ -12,3 +11,4 @@ license="GPL-3.0-or-later"
homepage="https://github.com/gort818/ddgtk"
distfiles="https://github.com/gort818/ddgtk/archive/${version}.tar.gz"
checksum=0386336681b24d648cdce3daa0c2b83c77a69773296e97a8427b67cbd27531ed
+patch_args="-Np1"
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR PATCH] [Updated] ddgtk: fixes for recent vte python bindings + other changes
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (3 preceding siblings ...)
2019-06-27 14:25 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-06-27 14:25 ` voidlinux-github
2019-06-27 14:30 ` voidlinux-github
` (15 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-27 14:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]
There is an updated pull request by reback00 against master on the void-packages repository
https://github.com/reback00/void-packages ddgtk-v0_1-fix-branch
https://github.com/void-linux/void-packages/pull/12710
ddgtk: fixes for recent vte python bindings + other changes
**Changes:**
1. Added additional dependencies against build warnings [template]
2. Updated for latest meson [patch]
3. Updated for latest python module (instead of deprecated `python3` module, used the new `python` module, according to: [https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types](https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types)) [patch]
4. Fixed breakage of write functionality due to recent changes in Vte python bindings (Explanation here: [https://github.com/Guake/guake/issues/1243#issuecomment-410208659](https://github.com/Guake/guake/issues/1243#issuecomment-410208659)) [patch]
#4 raised an error like this below which has been fixed:
```
Traceback (most recent call last):
File "/usr/local/share/ddgtk/ddgtk/main.py", line 154, in on_confirm_ok_clicked
self.dd()
File "/usr/local/share/ddgtk/ddgtk/main.py", line 125, in dd
self.terminal.feed_child(clear,-1)
TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)
```
A patch file from https://github.com/void-linux/void-packages/pull/12710.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ddgtk-v0_1-fix-branch-12710.patch --]
[-- Type: application/text/x-diff, Size: 4050 bytes --]
From 7491de760335fa96795539b8e0392b127ec812f5 Mon Sep 17 00:00:00 2001
From: reback00 <reback00@protonmail.com>
Date: Thu, 27 Jun 2019 16:35:39 +0600
Subject: [PATCH 1/2] ddgtk: fixes for recent vte python bindings + other
changes
---
.../ddgtk/patches/001-changes-for-v0.1.patch | 33 +++++++++++++++++++
srcpkgs/ddgtk/template | 5 +--
2 files changed, 36 insertions(+), 2 deletions(-)
create mode 100644 srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
diff --git a/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
new file mode 100644
index 00000000000..386b5fe5875
--- /dev/null
+++ b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
@@ -0,0 +1,33 @@
+diff -Naurp0 a/meson.build b/meson.build
+--- a/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/meson.build 2019-06-24 12:48:11.436750620 +0000
+@@ -3 +3 @@ project('ddgtk',
+- meson_version: '>= 0.40.0',
++ meson_version: '>= 0.50.0',
+diff -Naurp0 a/src/main.py b/src/main.py
+--- a/src/main.py 2017-10-15 19:48:45.000000000 +0000
++++ b/src/main.py 2019-06-24 12:50:46.519811815 +0000
+@@ -116 +116 @@ class Application():
+- #self.terminal.feed_child(self.command,-1)
++ #self.terminal.feed_child_binary(self.command.encode("utf-8"))
+@@ -125,4 +125,4 @@ class Application():
+- self.terminal.feed_child(clear,-1)
+- self.terminal.feed_child(wait,-1)
+- self.terminal.feed_child(self.umount,-1)
+- #self.terminal.feed_child(cmd,-1)
++ self.terminal.feed_child_binary(clear.encode("utf-8"))
++ self.terminal.feed_child_binary(wait.encode("utf-8"))
++ self.terminal.feed_child_binary(self.umount.encode("utf-8"))
++ #self.terminal.feed_child_binary(cmd.encode("utf-8"))
+@@ -130 +130 @@ class Application():
+- self.terminal.feed_child(self.command,-1)
++ self.terminal.feed_child_binary(self.command.encode("utf-8"))
+diff -Naurp0 a/src/meson.build b/src/meson.build
+--- a/src/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/src/meson.build 2019-06-24 12:48:51.950244132 +0000
+@@ -12 +12 @@ gnome.compile_resources('ddgtk',
+-python3 = import('python3')
++python3 = import('python')
+@@ -15 +15 @@ conf = configuration_data()
+-conf.set('PYTHON', python3.find_python().path())
++conf.set('PYTHON', python3.find_installation().path())
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index f97c362c1c5..84948070877 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -1,9 +1,10 @@
# Template file for 'ddgtk'
pkgname=ddgtk
version=0.1
-revision=1
+revision=2
build_style=meson
-hostmakedepends="pkg-config glib glib-devel"
+patch_args="-Np1"
+hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
maintainer="reback00 <reback00@protonmail.com>"
From 8705d7f3a77505aac3db86e793a9ee764d683d0b Mon Sep 17 00:00:00 2001
From: reback00 <51861250+reback00@users.noreply.github.com>
Date: Thu, 27 Jun 2019 05:14:40 +0600
Subject: [PATCH 2/2] ddgtk: added fixes for recent vte python bindings, added
additional deps, updated for latest meson, adjusted to new python module name
---
srcpkgs/ddgtk/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index 84948070877..d5f27bb4093 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -3,7 +3,6 @@ pkgname=ddgtk
version=0.1
revision=2
build_style=meson
-patch_args="-Np1"
hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
@@ -12,3 +11,4 @@ license="GPL-3.0-or-later"
homepage="https://github.com/gort818/ddgtk"
distfiles="https://github.com/gort818/ddgtk/archive/${version}.tar.gz"
checksum=0386336681b24d648cdce3daa0c2b83c77a69773296e97a8427b67cbd27531ed
+patch_args="-Np1"
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: ddgtk: fixes for recent vte python bindings + other changes
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (4 preceding siblings ...)
2019-06-27 14:25 ` voidlinux-github
@ 2019-06-27 14:30 ` voidlinux-github
2019-06-27 14:32 ` voidlinux-github
` (14 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-27 14:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
New comment by reback00 on void-packages repository
https://github.com/void-linux/void-packages/pull/12710#issuecomment-506370909
Comment:
> ```
> ... + other changes ...
> ```
>
> What are those other changes? Please update the commit message :)
Oh! I thought adding all of them would make the commit message bigger. So I added them in the pull request message. No problem, this time I added them in the latest commit message. Hope it works. :)
> ddgtk: fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: ddgtk: fixes for recent vte python bindings + other changes
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (5 preceding siblings ...)
2019-06-27 14:30 ` voidlinux-github
@ 2019-06-27 14:32 ` voidlinux-github
2019-06-27 15:24 ` voidlinux-github
` (13 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-27 14:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
New comment by reback00 on void-packages repository
https://github.com/void-linux/void-packages/pull/12710#issuecomment-506370909
Comment:
> ```
> ... + other changes ...
> ```
>
> What are those other changes? Please update the commit message :)
Oh! I thought adding all of them would make the commit message bigger. So I added them in the pull request message. No problem, this time I added them in the latest commit message. Hope it works. :)
> ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: ddgtk: fixes for recent vte python bindings + other changes
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (6 preceding siblings ...)
2019-06-27 14:32 ` voidlinux-github
@ 2019-06-27 15:24 ` voidlinux-github
2019-06-27 15:26 ` voidlinux-github
` (12 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-27 15:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 694 bytes --]
New comment by reback00 on void-packages repository
https://github.com/void-linux/void-packages/pull/12710#issuecomment-506393122
Comment:
The 2 builds `ARCH=x86_64 BOOTSTRAP=x86_64` and `ARCH=armv7l BOOTSTRAP=x86_64` failed because of a `Bad Gateway` error. I did not change any code in my last commit, so it should've passed. Is it an error on Travis CI's end?
Should I do anything further?
log:
```
=> ddgtk-0.1_2: fetching distfile '0.1.tar.gz'...
https://github.com/gort818/ddgtk/archive/0.1.tar.gz: Bad Gateway
=> ERROR: ddgtk-0.1_2: failed to fetch 0.1.tar.gz.
...
Done. Your build exited with 1.
```
[source](https://travis-ci.org/void-linux/void-packages/jobs/551344151)
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: ddgtk: fixes for recent vte python bindings + other changes
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (7 preceding siblings ...)
2019-06-27 15:24 ` voidlinux-github
@ 2019-06-27 15:26 ` voidlinux-github
2019-06-27 15:26 ` voidlinux-github
` (11 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-27 15:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
New comment by reback00 on void-packages repository
https://github.com/void-linux/void-packages/pull/12710#issuecomment-506393122
Comment:
The 2 builds `ARCH=x86_64 BOOTSTRAP=x86_64` and `ARCH=armv7l BOOTSTRAP=x86_64` failed because of a `Bad Gateway` error. I did not change any code in my last commit, so it should've passed. Is it an error on Travis CI's end?
Should I do anything further?
log:
```
=> ddgtk-0.1_2: fetching distfile '0.1.tar.gz'...
https://github.com/gort818/ddgtk/archive/0.1.tar.gz: Bad Gateway
=> ERROR: ddgtk-0.1_2: failed to fetch 0.1.tar.gz.
...
Done. Your build exited with 1.
```
[source](https://travis-ci.org/void-linux/void-packages/jobs/551344151) [another](https://travis-ci.org/void-linux/void-packages/jobs/551344154)
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: ddgtk: fixes for recent vte python bindings + other changes
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (8 preceding siblings ...)
2019-06-27 15:26 ` voidlinux-github
@ 2019-06-27 15:26 ` voidlinux-github
2019-06-27 16:55 ` ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name voidlinux-github
` (10 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-27 15:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
New comment by reback00 on void-packages repository
https://github.com/void-linux/void-packages/pull/12710#issuecomment-506393122
Comment:
The 2 builds `ARCH=x86_64 BOOTSTRAP=x86_64` and `ARCH=armv7l BOOTSTRAP=x86_64` failed because of a `Bad Gateway` error. I did not change any code in my last commit, so it should've passed. Is it an error on Travis CI's end?
Should I do anything further?
log:
```
=> ddgtk-0.1_2: fetching distfile '0.1.tar.gz'...
https://github.com/gort818/ddgtk/archive/0.1.tar.gz: Bad Gateway
=> ERROR: ddgtk-0.1_2: failed to fetch 0.1.tar.gz.
...
Done. Your build exited with 1.
```
[source](https://travis-ci.org/void-linux/void-packages/jobs/551344151)
[another](https://travis-ci.org/void-linux/void-packages/jobs/551344154)
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (9 preceding siblings ...)
2019-06-27 15:26 ` voidlinux-github
@ 2019-06-27 16:55 ` voidlinux-github
2019-06-27 16:56 ` voidlinux-github
` (9 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-27 16:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
New comment by reback00 on void-packages repository
https://github.com/void-linux/void-packages/pull/12710#issuecomment-506370909
Comment:
> ```
> ... + other changes ...
> ```
>
> What are those other changes? Please update the commit message :)
Oh! I thought adding all of them would make the commit message bigger. So I added them in the pull request message. No problem, this time I added them in the title. Hope it works. :)
> ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (10 preceding siblings ...)
2019-06-27 16:55 ` ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name voidlinux-github
@ 2019-06-27 16:56 ` voidlinux-github
2019-06-27 16:58 ` [PR PATCH] [Updated] " voidlinux-github
` (8 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-27 16:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 583 bytes --]
New comment by reback00 on void-packages repository
https://github.com/void-linux/void-packages/pull/12710#issuecomment-506370909
Comment:
> ```
> ... + other changes ...
> ```
>
> What are those other changes? Please update the commit message :)
Oh! I thought adding all of them would make the commit message/title bigger. So I added them in the pull request message. No problem, this time I added them in the title. Hope it works. :)
> ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR PATCH] [Updated] ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (11 preceding siblings ...)
2019-06-27 16:56 ` voidlinux-github
@ 2019-06-27 16:58 ` voidlinux-github
2019-06-27 16:58 ` voidlinux-github
` (7 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-27 16:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]
There is an updated pull request by reback00 against master on the void-packages repository
https://github.com/reback00/void-packages ddgtk-v0_1-fix-branch
https://github.com/void-linux/void-packages/pull/12710
ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
**Changes:**
1. Added additional dependencies against build warnings [template]
2. Updated for latest meson [patch]
3. Updated for latest python module (instead of deprecated `python3` module, used the new `python` module, according to: [https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types](https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types)) [patch]
4. Fixed breakage of write functionality due to recent changes in Vte python bindings (Explanation here: [https://github.com/Guake/guake/issues/1243#issuecomment-410208659](https://github.com/Guake/guake/issues/1243#issuecomment-410208659)) [patch]
#4 raised an error like this below which has been fixed:
```
Traceback (most recent call last):
File "/usr/local/share/ddgtk/ddgtk/main.py", line 154, in on_confirm_ok_clicked
self.dd()
File "/usr/local/share/ddgtk/ddgtk/main.py", line 125, in dd
self.terminal.feed_child(clear,-1)
TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)
```
A patch file from https://github.com/void-linux/void-packages/pull/12710.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ddgtk-v0_1-fix-branch-12710.patch --]
[-- Type: application/text/x-diff, Size: 3982 bytes --]
From 7491de760335fa96795539b8e0392b127ec812f5 Mon Sep 17 00:00:00 2001
From: reback00 <reback00@protonmail.com>
Date: Thu, 27 Jun 2019 16:35:39 +0600
Subject: [PATCH 1/2] ddgtk: fixes for recent vte python bindings + other
changes
---
.../ddgtk/patches/001-changes-for-v0.1.patch | 33 +++++++++++++++++++
srcpkgs/ddgtk/template | 5 +--
2 files changed, 36 insertions(+), 2 deletions(-)
create mode 100644 srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
diff --git a/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
new file mode 100644
index 00000000000..386b5fe5875
--- /dev/null
+++ b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
@@ -0,0 +1,33 @@
+diff -Naurp0 a/meson.build b/meson.build
+--- a/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/meson.build 2019-06-24 12:48:11.436750620 +0000
+@@ -3 +3 @@ project('ddgtk',
+- meson_version: '>= 0.40.0',
++ meson_version: '>= 0.50.0',
+diff -Naurp0 a/src/main.py b/src/main.py
+--- a/src/main.py 2017-10-15 19:48:45.000000000 +0000
++++ b/src/main.py 2019-06-24 12:50:46.519811815 +0000
+@@ -116 +116 @@ class Application():
+- #self.terminal.feed_child(self.command,-1)
++ #self.terminal.feed_child_binary(self.command.encode("utf-8"))
+@@ -125,4 +125,4 @@ class Application():
+- self.terminal.feed_child(clear,-1)
+- self.terminal.feed_child(wait,-1)
+- self.terminal.feed_child(self.umount,-1)
+- #self.terminal.feed_child(cmd,-1)
++ self.terminal.feed_child_binary(clear.encode("utf-8"))
++ self.terminal.feed_child_binary(wait.encode("utf-8"))
++ self.terminal.feed_child_binary(self.umount.encode("utf-8"))
++ #self.terminal.feed_child_binary(cmd.encode("utf-8"))
+@@ -130 +130 @@ class Application():
+- self.terminal.feed_child(self.command,-1)
++ self.terminal.feed_child_binary(self.command.encode("utf-8"))
+diff -Naurp0 a/src/meson.build b/src/meson.build
+--- a/src/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/src/meson.build 2019-06-24 12:48:51.950244132 +0000
+@@ -12 +12 @@ gnome.compile_resources('ddgtk',
+-python3 = import('python3')
++python3 = import('python')
+@@ -15 +15 @@ conf = configuration_data()
+-conf.set('PYTHON', python3.find_python().path())
++conf.set('PYTHON', python3.find_installation().path())
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index f97c362c1c5..84948070877 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -1,9 +1,10 @@
# Template file for 'ddgtk'
pkgname=ddgtk
version=0.1
-revision=1
+revision=2
build_style=meson
-hostmakedepends="pkg-config glib glib-devel"
+patch_args="-Np1"
+hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
maintainer="reback00 <reback00@protonmail.com>"
From 40eaf84e0101f6ff6384c548236e63bcedceb218 Mon Sep 17 00:00:00 2001
From: reback00 <51861250+reback00@users.noreply.github.com>
Date: Thu, 27 Jun 2019 05:14:40 +0600
Subject: [PATCH 2/2] ddgtk: second dummy commit for solving Travis CI bad
gateway error
---
srcpkgs/ddgtk/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index 84948070877..d5f27bb4093 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -3,7 +3,6 @@ pkgname=ddgtk
version=0.1
revision=2
build_style=meson
-patch_args="-Np1"
hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
@@ -12,3 +11,4 @@ license="GPL-3.0-or-later"
homepage="https://github.com/gort818/ddgtk"
distfiles="https://github.com/gort818/ddgtk/archive/${version}.tar.gz"
checksum=0386336681b24d648cdce3daa0c2b83c77a69773296e97a8427b67cbd27531ed
+patch_args="-Np1"
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR PATCH] [Updated] ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (12 preceding siblings ...)
2019-06-27 16:58 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-06-27 16:58 ` voidlinux-github
2019-06-28 16:17 ` voidlinux-github
` (6 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-27 16:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]
There is an updated pull request by reback00 against master on the void-packages repository
https://github.com/reback00/void-packages ddgtk-v0_1-fix-branch
https://github.com/void-linux/void-packages/pull/12710
ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
**Changes:**
1. Added additional dependencies against build warnings [template]
2. Updated for latest meson [patch]
3. Updated for latest python module (instead of deprecated `python3` module, used the new `python` module, according to: [https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types](https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types)) [patch]
4. Fixed breakage of write functionality due to recent changes in Vte python bindings (Explanation here: [https://github.com/Guake/guake/issues/1243#issuecomment-410208659](https://github.com/Guake/guake/issues/1243#issuecomment-410208659)) [patch]
#4 raised an error like this below which has been fixed:
```
Traceback (most recent call last):
File "/usr/local/share/ddgtk/ddgtk/main.py", line 154, in on_confirm_ok_clicked
self.dd()
File "/usr/local/share/ddgtk/ddgtk/main.py", line 125, in dd
self.terminal.feed_child(clear,-1)
TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)
```
A patch file from https://github.com/void-linux/void-packages/pull/12710.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ddgtk-v0_1-fix-branch-12710.patch --]
[-- Type: application/text/x-diff, Size: 3982 bytes --]
From 7491de760335fa96795539b8e0392b127ec812f5 Mon Sep 17 00:00:00 2001
From: reback00 <reback00@protonmail.com>
Date: Thu, 27 Jun 2019 16:35:39 +0600
Subject: [PATCH 1/2] ddgtk: fixes for recent vte python bindings + other
changes
---
.../ddgtk/patches/001-changes-for-v0.1.patch | 33 +++++++++++++++++++
srcpkgs/ddgtk/template | 5 +--
2 files changed, 36 insertions(+), 2 deletions(-)
create mode 100644 srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
diff --git a/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
new file mode 100644
index 00000000000..386b5fe5875
--- /dev/null
+++ b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
@@ -0,0 +1,33 @@
+diff -Naurp0 a/meson.build b/meson.build
+--- a/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/meson.build 2019-06-24 12:48:11.436750620 +0000
+@@ -3 +3 @@ project('ddgtk',
+- meson_version: '>= 0.40.0',
++ meson_version: '>= 0.50.0',
+diff -Naurp0 a/src/main.py b/src/main.py
+--- a/src/main.py 2017-10-15 19:48:45.000000000 +0000
++++ b/src/main.py 2019-06-24 12:50:46.519811815 +0000
+@@ -116 +116 @@ class Application():
+- #self.terminal.feed_child(self.command,-1)
++ #self.terminal.feed_child_binary(self.command.encode("utf-8"))
+@@ -125,4 +125,4 @@ class Application():
+- self.terminal.feed_child(clear,-1)
+- self.terminal.feed_child(wait,-1)
+- self.terminal.feed_child(self.umount,-1)
+- #self.terminal.feed_child(cmd,-1)
++ self.terminal.feed_child_binary(clear.encode("utf-8"))
++ self.terminal.feed_child_binary(wait.encode("utf-8"))
++ self.terminal.feed_child_binary(self.umount.encode("utf-8"))
++ #self.terminal.feed_child_binary(cmd.encode("utf-8"))
+@@ -130 +130 @@ class Application():
+- self.terminal.feed_child(self.command,-1)
++ self.terminal.feed_child_binary(self.command.encode("utf-8"))
+diff -Naurp0 a/src/meson.build b/src/meson.build
+--- a/src/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/src/meson.build 2019-06-24 12:48:51.950244132 +0000
+@@ -12 +12 @@ gnome.compile_resources('ddgtk',
+-python3 = import('python3')
++python3 = import('python')
+@@ -15 +15 @@ conf = configuration_data()
+-conf.set('PYTHON', python3.find_python().path())
++conf.set('PYTHON', python3.find_installation().path())
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index f97c362c1c5..84948070877 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -1,9 +1,10 @@
# Template file for 'ddgtk'
pkgname=ddgtk
version=0.1
-revision=1
+revision=2
build_style=meson
-hostmakedepends="pkg-config glib glib-devel"
+patch_args="-Np1"
+hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
maintainer="reback00 <reback00@protonmail.com>"
From 40eaf84e0101f6ff6384c548236e63bcedceb218 Mon Sep 17 00:00:00 2001
From: reback00 <51861250+reback00@users.noreply.github.com>
Date: Thu, 27 Jun 2019 05:14:40 +0600
Subject: [PATCH 2/2] ddgtk: second dummy commit for solving Travis CI bad
gateway error
---
srcpkgs/ddgtk/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index 84948070877..d5f27bb4093 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -3,7 +3,6 @@ pkgname=ddgtk
version=0.1
revision=2
build_style=meson
-patch_args="-Np1"
hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
@@ -12,3 +11,4 @@ license="GPL-3.0-or-later"
homepage="https://github.com/gort818/ddgtk"
distfiles="https://github.com/gort818/ddgtk/archive/${version}.tar.gz"
checksum=0386336681b24d648cdce3daa0c2b83c77a69773296e97a8427b67cbd27531ed
+patch_args="-Np1"
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (13 preceding siblings ...)
2019-06-27 16:58 ` voidlinux-github
@ 2019-06-28 16:17 ` voidlinux-github
2019-06-28 21:13 ` [PR PATCH] [Updated] " voidlinux-github
` (5 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-28 16:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 542 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/pull/12710#issuecomment-506792404
Comment:
@Duncaen wanted you to change the commit message, i.e. the title < 72 chars and the details in the message body. The PR title is more or less irrelevant, but should usually match the first line of the commit message.
In short do a `git commit --amend` and fix the title, leave one empty line, and fille body of the message with what's listed in this PR. The do a `git push -f` to your branch.
HTH :)
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR PATCH] [Updated] ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (14 preceding siblings ...)
2019-06-28 16:17 ` voidlinux-github
@ 2019-06-28 21:13 ` voidlinux-github
2019-06-28 21:13 ` voidlinux-github
` (4 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-28 21:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]
There is an updated pull request by reback00 against master on the void-packages repository
https://github.com/reback00/void-packages ddgtk-v0_1-fix-branch
https://github.com/void-linux/void-packages/pull/12710
ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
**Changes:**
1. Added additional dependencies against build warnings [template]
2. Updated for latest meson [patch]
3. Updated for latest python module (instead of deprecated `python3` module, used the new `python` module, according to: [https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types](https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types)) [patch]
4. Fixed breakage of write functionality due to recent changes in Vte python bindings (Explanation here: [https://github.com/Guake/guake/issues/1243#issuecomment-410208659](https://github.com/Guake/guake/issues/1243#issuecomment-410208659)) [patch]
#4 raised an error like this below which has been fixed:
```
Traceback (most recent call last):
File "/usr/local/share/ddgtk/ddgtk/main.py", line 154, in on_confirm_ok_clicked
self.dd()
File "/usr/local/share/ddgtk/ddgtk/main.py", line 125, in dd
self.terminal.feed_child(clear,-1)
TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)
```
A patch file from https://github.com/void-linux/void-packages/pull/12710.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ddgtk-v0_1-fix-branch-12710.patch --]
[-- Type: application/text/x-diff, Size: 4628 bytes --]
From 7491de760335fa96795539b8e0392b127ec812f5 Mon Sep 17 00:00:00 2001
From: reback00 <reback00@protonmail.com>
Date: Thu, 27 Jun 2019 16:35:39 +0600
Subject: [PATCH 1/2] ddgtk: fixes for recent vte python bindings + other
changes
---
.../ddgtk/patches/001-changes-for-v0.1.patch | 33 +++++++++++++++++++
srcpkgs/ddgtk/template | 5 +--
2 files changed, 36 insertions(+), 2 deletions(-)
create mode 100644 srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
diff --git a/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
new file mode 100644
index 00000000000..386b5fe5875
--- /dev/null
+++ b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
@@ -0,0 +1,33 @@
+diff -Naurp0 a/meson.build b/meson.build
+--- a/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/meson.build 2019-06-24 12:48:11.436750620 +0000
+@@ -3 +3 @@ project('ddgtk',
+- meson_version: '>= 0.40.0',
++ meson_version: '>= 0.50.0',
+diff -Naurp0 a/src/main.py b/src/main.py
+--- a/src/main.py 2017-10-15 19:48:45.000000000 +0000
++++ b/src/main.py 2019-06-24 12:50:46.519811815 +0000
+@@ -116 +116 @@ class Application():
+- #self.terminal.feed_child(self.command,-1)
++ #self.terminal.feed_child_binary(self.command.encode("utf-8"))
+@@ -125,4 +125,4 @@ class Application():
+- self.terminal.feed_child(clear,-1)
+- self.terminal.feed_child(wait,-1)
+- self.terminal.feed_child(self.umount,-1)
+- #self.terminal.feed_child(cmd,-1)
++ self.terminal.feed_child_binary(clear.encode("utf-8"))
++ self.terminal.feed_child_binary(wait.encode("utf-8"))
++ self.terminal.feed_child_binary(self.umount.encode("utf-8"))
++ #self.terminal.feed_child_binary(cmd.encode("utf-8"))
+@@ -130 +130 @@ class Application():
+- self.terminal.feed_child(self.command,-1)
++ self.terminal.feed_child_binary(self.command.encode("utf-8"))
+diff -Naurp0 a/src/meson.build b/src/meson.build
+--- a/src/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/src/meson.build 2019-06-24 12:48:51.950244132 +0000
+@@ -12 +12 @@ gnome.compile_resources('ddgtk',
+-python3 = import('python3')
++python3 = import('python')
+@@ -15 +15 @@ conf = configuration_data()
+-conf.set('PYTHON', python3.find_python().path())
++conf.set('PYTHON', python3.find_installation().path())
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index f97c362c1c5..84948070877 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -1,9 +1,10 @@
# Template file for 'ddgtk'
pkgname=ddgtk
version=0.1
-revision=1
+revision=2
build_style=meson
-hostmakedepends="pkg-config glib glib-devel"
+patch_args="-Np1"
+hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
maintainer="reback00 <reback00@protonmail.com>"
From 325ec2a224e86f187ae0a6e4b8efcef4f2391959 Mon Sep 17 00:00:00 2001
From: reback00 <51861250+reback00@users.noreply.github.com>
Date: Thu, 27 Jun 2019 05:14:40 +0600
Subject: [PATCH 2/2] ddgtk: fixes for vte, latest meson, py module name,
additional deps
1. [template] Added additional dependencies against build warnings
2. [patch] Updated for latest meson
3. [patch] Updated for latest python module name (instead of deprecated `python3` module, changed to `python` module, according to: https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types )
4. [patch] Fixed breakage of write functionality due to recent changes in Vte python bindings. Used to raise a `TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)` error which has been fixed. (Explanation here: https://github.com/Guake/guake/issues/1243#issuecomment-410208659 )
---
srcpkgs/ddgtk/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index 84948070877..d5f27bb4093 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -3,7 +3,6 @@ pkgname=ddgtk
version=0.1
revision=2
build_style=meson
-patch_args="-Np1"
hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
@@ -12,3 +11,4 @@ license="GPL-3.0-or-later"
homepage="https://github.com/gort818/ddgtk"
distfiles="https://github.com/gort818/ddgtk/archive/${version}.tar.gz"
checksum=0386336681b24d648cdce3daa0c2b83c77a69773296e97a8427b67cbd27531ed
+patch_args="-Np1"
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR PATCH] [Updated] ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (15 preceding siblings ...)
2019-06-28 21:13 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-06-28 21:13 ` voidlinux-github
2019-06-28 21:22 ` ddgtk: fixes for vte, latest meson, py module name, additional deps voidlinux-github
` (3 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-28 21:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]
There is an updated pull request by reback00 against master on the void-packages repository
https://github.com/reback00/void-packages ddgtk-v0_1-fix-branch
https://github.com/void-linux/void-packages/pull/12710
ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name
**Changes:**
1. Added additional dependencies against build warnings [template]
2. Updated for latest meson [patch]
3. Updated for latest python module (instead of deprecated `python3` module, used the new `python` module, according to: [https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types](https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types)) [patch]
4. Fixed breakage of write functionality due to recent changes in Vte python bindings (Explanation here: [https://github.com/Guake/guake/issues/1243#issuecomment-410208659](https://github.com/Guake/guake/issues/1243#issuecomment-410208659)) [patch]
#4 raised an error like this below which has been fixed:
```
Traceback (most recent call last):
File "/usr/local/share/ddgtk/ddgtk/main.py", line 154, in on_confirm_ok_clicked
self.dd()
File "/usr/local/share/ddgtk/ddgtk/main.py", line 125, in dd
self.terminal.feed_child(clear,-1)
TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)
```
A patch file from https://github.com/void-linux/void-packages/pull/12710.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ddgtk-v0_1-fix-branch-12710.patch --]
[-- Type: application/text/x-diff, Size: 4628 bytes --]
From 7491de760335fa96795539b8e0392b127ec812f5 Mon Sep 17 00:00:00 2001
From: reback00 <reback00@protonmail.com>
Date: Thu, 27 Jun 2019 16:35:39 +0600
Subject: [PATCH 1/2] ddgtk: fixes for recent vte python bindings + other
changes
---
.../ddgtk/patches/001-changes-for-v0.1.patch | 33 +++++++++++++++++++
srcpkgs/ddgtk/template | 5 +--
2 files changed, 36 insertions(+), 2 deletions(-)
create mode 100644 srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
diff --git a/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
new file mode 100644
index 00000000000..386b5fe5875
--- /dev/null
+++ b/srcpkgs/ddgtk/patches/001-changes-for-v0.1.patch
@@ -0,0 +1,33 @@
+diff -Naurp0 a/meson.build b/meson.build
+--- a/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/meson.build 2019-06-24 12:48:11.436750620 +0000
+@@ -3 +3 @@ project('ddgtk',
+- meson_version: '>= 0.40.0',
++ meson_version: '>= 0.50.0',
+diff -Naurp0 a/src/main.py b/src/main.py
+--- a/src/main.py 2017-10-15 19:48:45.000000000 +0000
++++ b/src/main.py 2019-06-24 12:50:46.519811815 +0000
+@@ -116 +116 @@ class Application():
+- #self.terminal.feed_child(self.command,-1)
++ #self.terminal.feed_child_binary(self.command.encode("utf-8"))
+@@ -125,4 +125,4 @@ class Application():
+- self.terminal.feed_child(clear,-1)
+- self.terminal.feed_child(wait,-1)
+- self.terminal.feed_child(self.umount,-1)
+- #self.terminal.feed_child(cmd,-1)
++ self.terminal.feed_child_binary(clear.encode("utf-8"))
++ self.terminal.feed_child_binary(wait.encode("utf-8"))
++ self.terminal.feed_child_binary(self.umount.encode("utf-8"))
++ #self.terminal.feed_child_binary(cmd.encode("utf-8"))
+@@ -130 +130 @@ class Application():
+- self.terminal.feed_child(self.command,-1)
++ self.terminal.feed_child_binary(self.command.encode("utf-8"))
+diff -Naurp0 a/src/meson.build b/src/meson.build
+--- a/src/meson.build 2017-10-15 19:48:45.000000000 +0000
++++ b/src/meson.build 2019-06-24 12:48:51.950244132 +0000
+@@ -12 +12 @@ gnome.compile_resources('ddgtk',
+-python3 = import('python3')
++python3 = import('python')
+@@ -15 +15 @@ conf = configuration_data()
+-conf.set('PYTHON', python3.find_python().path())
++conf.set('PYTHON', python3.find_installation().path())
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index f97c362c1c5..84948070877 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -1,9 +1,10 @@
# Template file for 'ddgtk'
pkgname=ddgtk
version=0.1
-revision=1
+revision=2
build_style=meson
-hostmakedepends="pkg-config glib glib-devel"
+patch_args="-Np1"
+hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
maintainer="reback00 <reback00@protonmail.com>"
From 325ec2a224e86f187ae0a6e4b8efcef4f2391959 Mon Sep 17 00:00:00 2001
From: reback00 <51861250+reback00@users.noreply.github.com>
Date: Thu, 27 Jun 2019 05:14:40 +0600
Subject: [PATCH 2/2] ddgtk: fixes for vte, latest meson, py module name,
additional deps
1. [template] Added additional dependencies against build warnings
2. [patch] Updated for latest meson
3. [patch] Updated for latest python module name (instead of deprecated `python3` module, changed to `python` module, according to: https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types )
4. [patch] Fixed breakage of write functionality due to recent changes in Vte python bindings. Used to raise a `TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)` error which has been fixed. (Explanation here: https://github.com/Guake/guake/issues/1243#issuecomment-410208659 )
---
srcpkgs/ddgtk/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/ddgtk/template b/srcpkgs/ddgtk/template
index 84948070877..d5f27bb4093 100644
--- a/srcpkgs/ddgtk/template
+++ b/srcpkgs/ddgtk/template
@@ -3,7 +3,6 @@ pkgname=ddgtk
version=0.1
revision=2
build_style=meson
-patch_args="-Np1"
hostmakedepends="pkg-config glib glib-devel gettext appstream-glib"
depends="python3 python3-gobject gtk+3"
short_desc="GUI frontend for dd to create bootable ISO images for Linux"
@@ -12,3 +11,4 @@ license="GPL-3.0-or-later"
homepage="https://github.com/gort818/ddgtk"
distfiles="https://github.com/gort818/ddgtk/archive/${version}.tar.gz"
checksum=0386336681b24d648cdce3daa0c2b83c77a69773296e97a8427b67cbd27531ed
+patch_args="-Np1"
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: ddgtk: fixes for vte, latest meson, py module name, additional deps
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (16 preceding siblings ...)
2019-06-28 21:13 ` voidlinux-github
@ 2019-06-28 21:22 ` voidlinux-github
2019-06-30 13:35 ` [PR PATCH] [Merged]: " voidlinux-github
` (2 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-28 21:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
New comment by reback00 on void-packages repository
https://github.com/void-linux/void-packages/pull/12710#issuecomment-506881061
Comment:
@pullmoll Thanks. I think I get it now. I have changed the commit message and added a smaller title and also added the list of changes after a blank line. Also, changed the title of the PR according to the first line of the commit message.
I gotta say, you guys are more helpful than the Arch Linux guys! They like to scream at people for not getting things right and link adamantly to wikis without explaining stuff. Happy to be a part of Void Linux.
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR PATCH] [Merged]: ddgtk: fixes for vte, latest meson, py module name, additional deps
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (17 preceding siblings ...)
2019-06-28 21:22 ` ddgtk: fixes for vte, latest meson, py module name, additional deps voidlinux-github
@ 2019-06-30 13:35 ` voidlinux-github
2019-06-30 13:39 ` voidlinux-github
2019-06-30 14:46 ` voidlinux-github
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-30 13:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1303 bytes --]
There's a merged pull request on the void-packages repository
ddgtk: fixes for vte, latest meson, py module name, additional deps
https://github.com/void-linux/void-packages/pull/12710
Description: **Changes:**
1. Added additional dependencies against build warnings [template]
2. Updated for latest meson [patch]
3. Updated for latest python module (instead of deprecated `python3` module, used the new `python` module, according to: [https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types](https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types)) [patch]
4. Fixed breakage of write functionality due to recent changes in Vte python bindings (Explanation here: [https://github.com/Guake/guake/issues/1243#issuecomment-410208659](https://github.com/Guake/guake/issues/1243#issuecomment-410208659)) [patch]
#4 raised an error like this below which has been fixed:
```
Traceback (most recent call last):
File "/usr/local/share/ddgtk/ddgtk/main.py", line 154, in on_confirm_ok_clicked
self.dd()
File "/usr/local/share/ddgtk/ddgtk/main.py", line 125, in dd
self.terminal.feed_child(clear,-1)
TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)
```
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: ddgtk: fixes for vte, latest meson, py module name, additional deps
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (18 preceding siblings ...)
2019-06-30 13:35 ` [PR PATCH] [Merged]: " voidlinux-github
@ 2019-06-30 13:39 ` voidlinux-github
2019-06-30 14:46 ` voidlinux-github
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-30 13:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/pull/12710#issuecomment-507037203
Comment:
I just now saw there were 2 commits. In the future please squash commits to one per package, i.e. `git rebase -i master` and `squash` or `fixup` the 2nd, 3rd etc. commit depending on whether you want to combine and edit the final commit message or not, then do the `git push -f`. You can always `git commit --amend` the latest commit.
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: ddgtk: fixes for vte, latest meson, py module name, additional deps
2019-06-26 22:51 [PR PATCH] ddgtk: fixes for recent vte python bindings + other changes voidlinux-github
` (19 preceding siblings ...)
2019-06-30 13:39 ` voidlinux-github
@ 2019-06-30 14:46 ` voidlinux-github
20 siblings, 0 replies; 22+ messages in thread
From: voidlinux-github @ 2019-06-30 14:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
New comment by reback00 on void-packages repository
https://github.com/void-linux/void-packages/pull/12710#issuecomment-507042180
Comment:
Ok. Thanks.
^ permalink raw reply [flat|nested] 22+ messages in thread