Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
@ 2019-10-15 16:59 voidlinux-github
  2019-10-15 17:05 ` [PR PATCH] [Updated] " voidlinux-github
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: voidlinux-github @ 2019-10-15 16:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

There is a new pull request by Johnnynator against master on the void-packages repository

https://github.com/Johnnynator/void-packages host_subpkg
https://github.com/void-linux/void-packages/pull/15493

[DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
Currently missing hostmakedepends that are a subpkg are just ignored which leads to failing builds in theses cases if they are needed for cross compiling

e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio

A patch file from https://github.com/void-linux/void-packages/pull/15493.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-host_subpkg-15493.patch --]
[-- Type: text/x-diff, Size: 1043 bytes --]

From 2b3030ebdd7072a90942cc72e20ab8dacfd2b4d7 Mon Sep 17 00:00:00 2001
From: John <johnz@posteo.net>
Date: Tue, 15 Oct 2019 18:58:01 +0200
Subject: [PATCH] common/build_dependencies.sh: don't ingore missing subpkgs in
 hostdeps

---
 common/xbps-src/shutils/build_dependencies.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/common/xbps-src/shutils/build_dependencies.sh b/common/xbps-src/shutils/build_dependencies.sh
index 6d9d727e0d3..bc4211c061a 100644
--- a/common/xbps-src/shutils/build_dependencies.sh
+++ b/common/xbps-src/shutils/build_dependencies.sh
@@ -170,7 +170,8 @@ install_pkg_deps() {
                     fi
                 done
                 if [[ $found -eq 1 ]]; then
-                    echo "   [host] ${_vpkg}: not found (subpkg, ignored)"
+                    echo "   [host] ${_vpkg}: not found (subpkg)"
+                    host_missing_deps+=("$_vpkg")
                 else
                     echo "   [host] ${_vpkg}: not found"
                     host_missing_deps+=("$_vpkg")

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-10-15 18:34 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 16:59 [PR PATCH] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps voidlinux-github
2019-10-15 17:05 ` [PR PATCH] [Updated] " voidlinux-github
2019-10-15 17:05 ` voidlinux-github
2019-10-15 17:08 ` voidlinux-github
2019-10-15 17:08 ` voidlinux-github
2019-10-15 17:19 ` [PR PATCH] [Updated] " voidlinux-github
2019-10-15 17:19 ` voidlinux-github
2019-10-15 17:20 ` voidlinux-github
2019-10-15 17:20 ` voidlinux-github
2019-10-15 18:34 ` [PR PATCH] [Merged]: " voidlinux-github

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).