* [PR PATCH] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
@ 2019-10-15 16:59 voidlinux-github
2019-10-15 17:05 ` [PR PATCH] [Updated] " voidlinux-github
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: voidlinux-github @ 2019-10-15 16:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
There is a new pull request by Johnnynator against master on the void-packages repository
https://github.com/Johnnynator/void-packages host_subpkg
https://github.com/void-linux/void-packages/pull/15493
[DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
Currently missing hostmakedepends that are a subpkg are just ignored which leads to failing builds in theses cases if they are needed for cross compiling
e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
A patch file from https://github.com/void-linux/void-packages/pull/15493.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-host_subpkg-15493.patch --]
[-- Type: text/x-diff, Size: 1043 bytes --]
From 2b3030ebdd7072a90942cc72e20ab8dacfd2b4d7 Mon Sep 17 00:00:00 2001
From: John <johnz@posteo.net>
Date: Tue, 15 Oct 2019 18:58:01 +0200
Subject: [PATCH] common/build_dependencies.sh: don't ingore missing subpkgs in
hostdeps
---
common/xbps-src/shutils/build_dependencies.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/common/xbps-src/shutils/build_dependencies.sh b/common/xbps-src/shutils/build_dependencies.sh
index 6d9d727e0d3..bc4211c061a 100644
--- a/common/xbps-src/shutils/build_dependencies.sh
+++ b/common/xbps-src/shutils/build_dependencies.sh
@@ -170,7 +170,8 @@ install_pkg_deps() {
fi
done
if [[ $found -eq 1 ]]; then
- echo " [host] ${_vpkg}: not found (subpkg, ignored)"
+ echo " [host] ${_vpkg}: not found (subpkg)"
+ host_missing_deps+=("$_vpkg")
else
echo " [host] ${_vpkg}: not found"
host_missing_deps+=("$_vpkg")
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
2019-10-15 16:59 [PR PATCH] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps voidlinux-github
2019-10-15 17:05 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-10-15 17:05 ` voidlinux-github
2019-10-15 17:08 ` voidlinux-github
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-10-15 17:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 657 bytes --]
There is an updated pull request by Johnnynator against master on the void-packages repository
https://github.com/Johnnynator/void-packages host_subpkg
https://github.com/void-linux/void-packages/pull/15493
[DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
Currently missing hostmakedepends that are a subpkg are just ignored which leads to failing builds in theses cases if they are needed for cross compiling
e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
A patch file from https://github.com/void-linux/void-packages/pull/15493.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-host_subpkg-15493.patch --]
[-- Type: text/x-diff, Size: 1392 bytes --]
From cc6c24b04fb7cca7350dd4b0a6aefca249e3c52e Mon Sep 17 00:00:00 2001
From: John <johnz@posteo.net>
Date: Tue, 15 Oct 2019 18:58:01 +0200
Subject: [PATCH] common/build_dependencies.sh: don't ignore subpkgs in host
while cross
compiling, this falls (obviously) apart if it is missing.
See e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
---
common/xbps-src/shutils/build_dependencies.sh | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/common/xbps-src/shutils/build_dependencies.sh b/common/xbps-src/shutils/build_dependencies.sh
index 6d9d727e0d3..f20d8488fa7 100644
--- a/common/xbps-src/shutils/build_dependencies.sh
+++ b/common/xbps-src/shutils/build_dependencies.sh
@@ -170,7 +170,12 @@ install_pkg_deps() {
fi
done
if [[ $found -eq 1 ]]; then
- echo " [host] ${_vpkg}: not found (subpkg, ignored)"
+ if [ "$cross" ]; then
+ echo " [host] ${_vpkg}: not found (subpkg)"
+ host_missing_deps+=("$_vpkg")
+ else
+ echo " [host] ${_vpkg}: not found (subpkg, ignored)"
+ fi
else
echo " [host] ${_vpkg}: not found"
host_missing_deps+=("$_vpkg")
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
2019-10-15 16:59 [PR PATCH] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps voidlinux-github
@ 2019-10-15 17:05 ` voidlinux-github
2019-10-15 17:05 ` voidlinux-github
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-10-15 17:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 657 bytes --]
There is an updated pull request by Johnnynator against master on the void-packages repository
https://github.com/Johnnynator/void-packages host_subpkg
https://github.com/void-linux/void-packages/pull/15493
[DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
Currently missing hostmakedepends that are a subpkg are just ignored which leads to failing builds in theses cases if they are needed for cross compiling
e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
A patch file from https://github.com/void-linux/void-packages/pull/15493.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-host_subpkg-15493.patch --]
[-- Type: text/x-diff, Size: 1392 bytes --]
From cc6c24b04fb7cca7350dd4b0a6aefca249e3c52e Mon Sep 17 00:00:00 2001
From: John <johnz@posteo.net>
Date: Tue, 15 Oct 2019 18:58:01 +0200
Subject: [PATCH] common/build_dependencies.sh: don't ignore subpkgs in host
while cross
compiling, this falls (obviously) apart if it is missing.
See e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
---
common/xbps-src/shutils/build_dependencies.sh | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/common/xbps-src/shutils/build_dependencies.sh b/common/xbps-src/shutils/build_dependencies.sh
index 6d9d727e0d3..f20d8488fa7 100644
--- a/common/xbps-src/shutils/build_dependencies.sh
+++ b/common/xbps-src/shutils/build_dependencies.sh
@@ -170,7 +170,12 @@ install_pkg_deps() {
fi
done
if [[ $found -eq 1 ]]; then
- echo " [host] ${_vpkg}: not found (subpkg, ignored)"
+ if [ "$cross" ]; then
+ echo " [host] ${_vpkg}: not found (subpkg)"
+ host_missing_deps+=("$_vpkg")
+ else
+ echo " [host] ${_vpkg}: not found (subpkg, ignored)"
+ fi
else
echo " [host] ${_vpkg}: not found"
host_missing_deps+=("$_vpkg")
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
2019-10-15 16:59 [PR PATCH] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps voidlinux-github
2019-10-15 17:05 ` [PR PATCH] [Updated] " voidlinux-github
2019-10-15 17:05 ` voidlinux-github
@ 2019-10-15 17:08 ` voidlinux-github
2019-10-15 17:08 ` voidlinux-github
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-10-15 17:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 657 bytes --]
There is an updated pull request by Johnnynator against master on the void-packages repository
https://github.com/Johnnynator/void-packages host_subpkg
https://github.com/void-linux/void-packages/pull/15493
[DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
Currently missing hostmakedepends that are a subpkg are just ignored which leads to failing builds in theses cases if they are needed for cross compiling
e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
A patch file from https://github.com/void-linux/void-packages/pull/15493.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-host_subpkg-15493.patch --]
[-- Type: text/x-diff, Size: 1395 bytes --]
From dea1bf1b6cac1f77b3152beccabd6314dc037898 Mon Sep 17 00:00:00 2001
From: John <johnz@posteo.net>
Date: Tue, 15 Oct 2019 18:58:01 +0200
Subject: [PATCH] common/build_dependencies.sh: don't ignore subpkgs in host
while cross
compiling, this falls (obviously) apart if it is missing.
See e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
---
common/xbps-src/shutils/build_dependencies.sh | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/common/xbps-src/shutils/build_dependencies.sh b/common/xbps-src/shutils/build_dependencies.sh
index 6d9d727e0d3..73505f39c86 100644
--- a/common/xbps-src/shutils/build_dependencies.sh
+++ b/common/xbps-src/shutils/build_dependencies.sh
@@ -170,7 +170,12 @@ install_pkg_deps() {
fi
done
if [[ $found -eq 1 ]]; then
- echo " [host] ${_vpkg}: not found (subpkg, ignored)"
+ if [ -n "$cross" ]; then
+ echo " [host] ${_vpkg}: not found (subpkg)"
+ host_missing_deps+=("$_vpkg")
+ else
+ echo " [host] ${_vpkg}: not found (subpkg, ignored)"
+ fi
else
echo " [host] ${_vpkg}: not found"
host_missing_deps+=("$_vpkg")
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
2019-10-15 16:59 [PR PATCH] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps voidlinux-github
` (2 preceding siblings ...)
2019-10-15 17:08 ` voidlinux-github
@ 2019-10-15 17:08 ` voidlinux-github
2019-10-15 17:19 ` [PR PATCH] [Updated] " voidlinux-github
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-10-15 17:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 657 bytes --]
There is an updated pull request by Johnnynator against master on the void-packages repository
https://github.com/Johnnynator/void-packages host_subpkg
https://github.com/void-linux/void-packages/pull/15493
[DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
Currently missing hostmakedepends that are a subpkg are just ignored which leads to failing builds in theses cases if they are needed for cross compiling
e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
A patch file from https://github.com/void-linux/void-packages/pull/15493.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-host_subpkg-15493.patch --]
[-- Type: text/x-diff, Size: 1395 bytes --]
From dea1bf1b6cac1f77b3152beccabd6314dc037898 Mon Sep 17 00:00:00 2001
From: John <johnz@posteo.net>
Date: Tue, 15 Oct 2019 18:58:01 +0200
Subject: [PATCH] common/build_dependencies.sh: don't ignore subpkgs in host
while cross
compiling, this falls (obviously) apart if it is missing.
See e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
---
common/xbps-src/shutils/build_dependencies.sh | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/common/xbps-src/shutils/build_dependencies.sh b/common/xbps-src/shutils/build_dependencies.sh
index 6d9d727e0d3..73505f39c86 100644
--- a/common/xbps-src/shutils/build_dependencies.sh
+++ b/common/xbps-src/shutils/build_dependencies.sh
@@ -170,7 +170,12 @@ install_pkg_deps() {
fi
done
if [[ $found -eq 1 ]]; then
- echo " [host] ${_vpkg}: not found (subpkg, ignored)"
+ if [ -n "$cross" ]; then
+ echo " [host] ${_vpkg}: not found (subpkg)"
+ host_missing_deps+=("$_vpkg")
+ else
+ echo " [host] ${_vpkg}: not found (subpkg, ignored)"
+ fi
else
echo " [host] ${_vpkg}: not found"
host_missing_deps+=("$_vpkg")
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
2019-10-15 16:59 [PR PATCH] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps voidlinux-github
` (3 preceding siblings ...)
2019-10-15 17:08 ` voidlinux-github
@ 2019-10-15 17:19 ` voidlinux-github
2019-10-15 17:19 ` voidlinux-github
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-10-15 17:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
There is an updated pull request by Johnnynator against master on the void-packages repository
https://github.com/Johnnynator/void-packages host_subpkg
https://github.com/void-linux/void-packages/pull/15493
common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
Currently missing hostmakedepends that are a subpkg are just ignored which leads to failing builds in theses cases if they are needed for cross compiling
e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
A patch file from https://github.com/void-linux/void-packages/pull/15493.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-host_subpkg-15493.patch --]
[-- Type: text/x-diff, Size: 1133 bytes --]
From 130931fdd0a5238d9481d85d1a52d24bde764b44 Mon Sep 17 00:00:00 2001
From: John <johnz@posteo.net>
Date: Tue, 15 Oct 2019 18:58:01 +0200
Subject: [PATCH] common/build_dependencies.sh: don't ignore subpkgs in host
while cross
compiling, this falls (obviously) apart if it is missing.
See e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
---
common/xbps-src/shutils/build_dependencies.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/xbps-src/shutils/build_dependencies.sh b/common/xbps-src/shutils/build_dependencies.sh
index 6d9d727e0d3..f54b7ae4f5a 100644
--- a/common/xbps-src/shutils/build_dependencies.sh
+++ b/common/xbps-src/shutils/build_dependencies.sh
@@ -169,7 +169,7 @@ install_pkg_deps() {
break
fi
done
- if [[ $found -eq 1 ]]; then
+ if [[ $found -eq 1 ]] && [[ -z "$cross" ]] ; then
echo " [host] ${_vpkg}: not found (subpkg, ignored)"
else
echo " [host] ${_vpkg}: not found"
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
2019-10-15 16:59 [PR PATCH] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps voidlinux-github
` (4 preceding siblings ...)
2019-10-15 17:19 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-10-15 17:19 ` voidlinux-github
2019-10-15 17:20 ` voidlinux-github
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-10-15 17:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
There is an updated pull request by Johnnynator against master on the void-packages repository
https://github.com/Johnnynator/void-packages host_subpkg
https://github.com/void-linux/void-packages/pull/15493
common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
Currently missing hostmakedepends that are a subpkg are just ignored which leads to failing builds in theses cases if they are needed for cross compiling
e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
A patch file from https://github.com/void-linux/void-packages/pull/15493.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-host_subpkg-15493.patch --]
[-- Type: text/x-diff, Size: 1133 bytes --]
From 130931fdd0a5238d9481d85d1a52d24bde764b44 Mon Sep 17 00:00:00 2001
From: John <johnz@posteo.net>
Date: Tue, 15 Oct 2019 18:58:01 +0200
Subject: [PATCH] common/build_dependencies.sh: don't ignore subpkgs in host
while cross
compiling, this falls (obviously) apart if it is missing.
See e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
---
common/xbps-src/shutils/build_dependencies.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/xbps-src/shutils/build_dependencies.sh b/common/xbps-src/shutils/build_dependencies.sh
index 6d9d727e0d3..f54b7ae4f5a 100644
--- a/common/xbps-src/shutils/build_dependencies.sh
+++ b/common/xbps-src/shutils/build_dependencies.sh
@@ -169,7 +169,7 @@ install_pkg_deps() {
break
fi
done
- if [[ $found -eq 1 ]]; then
+ if [[ $found -eq 1 ]] && [[ -z "$cross" ]] ; then
echo " [host] ${_vpkg}: not found (subpkg, ignored)"
else
echo " [host] ${_vpkg}: not found"
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
2019-10-15 16:59 [PR PATCH] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps voidlinux-github
` (5 preceding siblings ...)
2019-10-15 17:19 ` voidlinux-github
@ 2019-10-15 17:20 ` voidlinux-github
2019-10-15 17:20 ` voidlinux-github
2019-10-15 18:34 ` [PR PATCH] [Merged]: " voidlinux-github
8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-10-15 17:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
There is an updated pull request by Johnnynator against master on the void-packages repository
https://github.com/Johnnynator/void-packages host_subpkg
https://github.com/void-linux/void-packages/pull/15493
common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
Currently missing hostmakedepends that are a subpkg are just ignored which leads to failing builds in theses cases if they are needed for cross compiling
e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
A patch file from https://github.com/void-linux/void-packages/pull/15493.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-host_subpkg-15493.patch --]
[-- Type: text/x-diff, Size: 1132 bytes --]
From a2bfd4dc34d20e66c11ef56b1763e63bfe389028 Mon Sep 17 00:00:00 2001
From: John <johnz@posteo.net>
Date: Tue, 15 Oct 2019 18:58:01 +0200
Subject: [PATCH] common/build_dependencies.sh: don't ignore subpkgs in host
while cross
compiling, this falls (obviously) apart if it is missing.
See e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
---
common/xbps-src/shutils/build_dependencies.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/xbps-src/shutils/build_dependencies.sh b/common/xbps-src/shutils/build_dependencies.sh
index 6d9d727e0d3..26e24232ad8 100644
--- a/common/xbps-src/shutils/build_dependencies.sh
+++ b/common/xbps-src/shutils/build_dependencies.sh
@@ -169,7 +169,7 @@ install_pkg_deps() {
break
fi
done
- if [[ $found -eq 1 ]]; then
+ if [[ $found -eq 1 ]] && [[ -z "$cross" ]]; then
echo " [host] ${_vpkg}: not found (subpkg, ignored)"
else
echo " [host] ${_vpkg}: not found"
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
2019-10-15 16:59 [PR PATCH] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps voidlinux-github
` (6 preceding siblings ...)
2019-10-15 17:20 ` voidlinux-github
@ 2019-10-15 17:20 ` voidlinux-github
2019-10-15 18:34 ` [PR PATCH] [Merged]: " voidlinux-github
8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-10-15 17:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
There is an updated pull request by Johnnynator against master on the void-packages repository
https://github.com/Johnnynator/void-packages host_subpkg
https://github.com/void-linux/void-packages/pull/15493
common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
Currently missing hostmakedepends that are a subpkg are just ignored which leads to failing builds in theses cases if they are needed for cross compiling
e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
A patch file from https://github.com/void-linux/void-packages/pull/15493.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-host_subpkg-15493.patch --]
[-- Type: text/x-diff, Size: 1132 bytes --]
From a2bfd4dc34d20e66c11ef56b1763e63bfe389028 Mon Sep 17 00:00:00 2001
From: John <johnz@posteo.net>
Date: Tue, 15 Oct 2019 18:58:01 +0200
Subject: [PATCH] common/build_dependencies.sh: don't ignore subpkgs in host
while cross
compiling, this falls (obviously) apart if it is missing.
See e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
---
common/xbps-src/shutils/build_dependencies.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/xbps-src/shutils/build_dependencies.sh b/common/xbps-src/shutils/build_dependencies.sh
index 6d9d727e0d3..26e24232ad8 100644
--- a/common/xbps-src/shutils/build_dependencies.sh
+++ b/common/xbps-src/shutils/build_dependencies.sh
@@ -169,7 +169,7 @@ install_pkg_deps() {
break
fi
done
- if [[ $found -eq 1 ]]; then
+ if [[ $found -eq 1 ]] && [[ -z "$cross" ]]; then
echo " [host] ${_vpkg}: not found (subpkg, ignored)"
else
echo " [host] ${_vpkg}: not found"
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Merged]: common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
2019-10-15 16:59 [PR PATCH] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps voidlinux-github
` (7 preceding siblings ...)
2019-10-15 17:20 ` voidlinux-github
@ 2019-10-15 18:34 ` voidlinux-github
8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-10-15 18:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 459 bytes --]
There's a merged pull request on the void-packages repository
common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps
https://github.com/void-linux/void-packages/pull/15493
Description:
Currently missing hostmakedepends that are a subpkg are just ignored which leads to failing builds in theses cases if they are needed for cross compiling
e.g. https://build.voidlinux.org/builders/aarch64-musl_builder/builds/22678/steps/shell_3/logs/stdio
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-10-15 18:34 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 16:59 [PR PATCH] [DO NOT MERGE THIS IS BROKEN] common/build_dependencies.sh: don't ingore missing subpkgs in hostdeps voidlinux-github
2019-10-15 17:05 ` [PR PATCH] [Updated] " voidlinux-github
2019-10-15 17:05 ` voidlinux-github
2019-10-15 17:08 ` voidlinux-github
2019-10-15 17:08 ` voidlinux-github
2019-10-15 17:19 ` [PR PATCH] [Updated] " voidlinux-github
2019-10-15 17:19 ` voidlinux-github
2019-10-15 17:20 ` voidlinux-github
2019-10-15 17:20 ` voidlinux-github
2019-10-15 18:34 ` [PR PATCH] [Merged]: " voidlinux-github
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).