* [ISSUE] common/hooks/do-fetch/00-distfiles.sh: contents checksum broken
@ 2020-01-06 13:57 voidlinux-github
2020-01-06 14:04 ` voidlinux-github
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-06 13:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]
New issue by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/issues/18070
Description:
With the switch to `bsdtar` the evaluation of contents checksums (i.e. the ones starting with `@`) is broken. One example is `libaom`. Trying to build it gives the error:
```
=> libaom-1.0.0.1_2: verifying contents checksum for distfile 'v1.0.0-errata1.tar.gz'... bsdtar: Can't specify both -t and -x
```
`bsdtar` as opposed to `tar` does not support `-x extract` together with `-t list`, yet the commands are like `$TAR_CMD xf $filename $TAR_CMD_STDOUT`.
I think we need to get rid of the `TAR_CMD_STDOUT="--list"` vs. `TAR_CMD_STDOUT="--to-stdout"` and rather have the type of command (extract or list) for `bsdtar` and `tar` as part of some `TAR_CMD_STDOUT`
For `bsdtar` that could be `TAR_CMD_STDOUT="bsdtar --list"`, and for GNU `tar` that could be `TAR_CMD_STDOUT="tar --extract --to-stdout"`.
For the single case where there is no redirection from the tar output to stdout, in line 98, then `TAR_CMD="bsdtar"` or `TAR_CMD="tar"` should be defined.
I could try to fix that but perhaps @xtraeme knows better how to fix this and beats me to it?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: common/hooks/do-fetch/00-distfiles.sh: contents checksum broken
2020-01-06 13:57 [ISSUE] common/hooks/do-fetch/00-distfiles.sh: contents checksum broken voidlinux-github
@ 2020-01-06 14:04 ` voidlinux-github
2020-01-06 14:05 ` voidlinux-github
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-06 14:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/issues/18070#issuecomment-571149479
Comment:
Err, actually `--list` for `bsdtar` is wrong. We need the entire contents of the tarball's files chained together to feed into `$XBPS_DIGEST_CMD`, so that should be option `-O`!?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: common/hooks/do-fetch/00-distfiles.sh: contents checksum broken
2020-01-06 13:57 [ISSUE] common/hooks/do-fetch/00-distfiles.sh: contents checksum broken voidlinux-github
2020-01-06 14:04 ` voidlinux-github
@ 2020-01-06 14:05 ` voidlinux-github
2020-01-06 14:06 ` voidlinux-github
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-06 14:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/issues/18070#issuecomment-571149851
Comment:
@pullmoll you are right, --list is wrong, bsdtar supports -O,--to-stdout like GNU tar.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: common/hooks/do-fetch/00-distfiles.sh: contents checksum broken
2020-01-06 13:57 [ISSUE] common/hooks/do-fetch/00-distfiles.sh: contents checksum broken voidlinux-github
2020-01-06 14:04 ` voidlinux-github
2020-01-06 14:05 ` voidlinux-github
@ 2020-01-06 14:06 ` voidlinux-github
2020-01-06 14:06 ` voidlinux-github
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-06 14:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/issues/18070#issuecomment-571150014
Comment:
I already have a fix along the lines described above. Some more testing and I'll push it.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: common/hooks/do-fetch/00-distfiles.sh: contents checksum broken
2020-01-06 13:57 [ISSUE] common/hooks/do-fetch/00-distfiles.sh: contents checksum broken voidlinux-github
` (2 preceding siblings ...)
2020-01-06 14:06 ` voidlinux-github
@ 2020-01-06 14:06 ` voidlinux-github
2020-01-06 14:12 ` [ISSUE] [CLOSED] " voidlinux-github
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-06 14:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/issues/18070#issuecomment-571150027
Comment:
@pullmoll feel free to fix this; in this case TAR_CMD_STDOUT is useless, we can use --to-stdout anywhere
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ISSUE] [CLOSED] common/hooks/do-fetch/00-distfiles.sh: contents checksum broken
2020-01-06 13:57 [ISSUE] common/hooks/do-fetch/00-distfiles.sh: contents checksum broken voidlinux-github
` (3 preceding siblings ...)
2020-01-06 14:06 ` voidlinux-github
@ 2020-01-06 14:12 ` voidlinux-github
2020-01-06 14:13 ` voidlinux-github
2020-01-06 14:14 ` [ISSUE] [CLOSED] " voidlinux-github
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-06 14:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]
Closed issue by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/issues/18070
Description:
With the switch to `bsdtar` the evaluation of contents checksums (i.e. the ones starting with `@`) is broken. One example is `libaom`. Trying to build it gives the error:
```
=> libaom-1.0.0.1_2: verifying contents checksum for distfile 'v1.0.0-errata1.tar.gz'... bsdtar: Can't specify both -t and -x
```
`bsdtar` as opposed to `tar` does not support `-x extract` together with `-t list`, yet the commands are like `$TAR_CMD xf $filename $TAR_CMD_STDOUT`.
I think we need to get rid of the `TAR_CMD_STDOUT="--list"` vs. `TAR_CMD_STDOUT="--to-stdout"` and rather have the type of command (extract or list) for `bsdtar` and `tar` as part of some `TAR_CMD_STDOUT`
For `bsdtar` that could be `TAR_CMD_STDOUT="bsdtar --list"`, and for GNU `tar` that could be `TAR_CMD_STDOUT="tar --extract --to-stdout"`.
For the single case where there is no redirection from the tar output to stdout, in line 98, then `TAR_CMD="bsdtar"` or `TAR_CMD="tar"` should be defined.
I could try to fix that but perhaps @xtraeme knows better how to fix this and beats me to it?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: common/hooks/do-fetch/00-distfiles.sh: contents checksum broken
2020-01-06 13:57 [ISSUE] common/hooks/do-fetch/00-distfiles.sh: contents checksum broken voidlinux-github
` (4 preceding siblings ...)
2020-01-06 14:12 ` [ISSUE] [CLOSED] " voidlinux-github
@ 2020-01-06 14:13 ` voidlinux-github
2020-01-06 14:14 ` [ISSUE] [CLOSED] " voidlinux-github
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-06 14:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/issues/18070#issuecomment-571152310
Comment:
omg wrong click :-)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ISSUE] [CLOSED] common/hooks/do-fetch/00-distfiles.sh: contents checksum broken
2020-01-06 13:57 [ISSUE] common/hooks/do-fetch/00-distfiles.sh: contents checksum broken voidlinux-github
` (5 preceding siblings ...)
2020-01-06 14:13 ` voidlinux-github
@ 2020-01-06 14:14 ` voidlinux-github
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-06 14:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]
Closed issue by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/issues/18070
Description:
With the switch to `bsdtar` the evaluation of contents checksums (i.e. the ones starting with `@`) is broken. One example is `libaom`. Trying to build it gives the error:
```
=> libaom-1.0.0.1_2: verifying contents checksum for distfile 'v1.0.0-errata1.tar.gz'... bsdtar: Can't specify both -t and -x
```
`bsdtar` as opposed to `tar` does not support `-x extract` together with `-t list`, yet the commands are like `$TAR_CMD xf $filename $TAR_CMD_STDOUT`.
I think we need to get rid of the `TAR_CMD_STDOUT="--list"` vs. `TAR_CMD_STDOUT="--to-stdout"` and rather have the type of command (extract or list) for `bsdtar` and `tar` as part of some `TAR_CMD_STDOUT`
For `bsdtar` that could be `TAR_CMD_STDOUT="bsdtar --list"`, and for GNU `tar` that could be `TAR_CMD_STDOUT="tar --extract --to-stdout"`.
For the single case where there is no redirection from the tar output to stdout, in line 98, then `TAR_CMD="bsdtar"` or `TAR_CMD="tar"` should be defined.
I could try to fix that but perhaps @xtraeme knows better how to fix this and beats me to it?
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-01-06 14:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-06 13:57 [ISSUE] common/hooks/do-fetch/00-distfiles.sh: contents checksum broken voidlinux-github
2020-01-06 14:04 ` voidlinux-github
2020-01-06 14:05 ` voidlinux-github
2020-01-06 14:06 ` voidlinux-github
2020-01-06 14:06 ` voidlinux-github
2020-01-06 14:12 ` [ISSUE] [CLOSED] " voidlinux-github
2020-01-06 14:13 ` voidlinux-github
2020-01-06 14:14 ` [ISSUE] [CLOSED] " voidlinux-github
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).