* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
@ 2020-02-17 11:51 ` Duncaen
2020-02-17 12:34 ` amak79
` (15 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: Duncaen @ 2020-02-17 11:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-586959040
Comment:
`log/run` can be a symlink to `/usr/bin/vlogger`, vlogger will get the tag from the service path.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
2020-02-17 11:51 ` lxd: add logging Duncaen
@ 2020-02-17 12:34 ` amak79
2020-02-17 17:12 ` CameronNemo
` (14 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: amak79 @ 2020-02-17 12:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
New comment by amak79 on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-586973698
Comment:
When using a symlink I noticed that `ps` will display `./run` for the command instead of `vlogger -t lxd`. This is less informative, but if you prefer a symlink I will amend the commit.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
2020-02-17 11:51 ` lxd: add logging Duncaen
2020-02-17 12:34 ` amak79
@ 2020-02-17 17:12 ` CameronNemo
2020-02-18 1:13 ` amak79
` (13 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: CameronNemo @ 2020-02-17 17:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 176 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587089216
Comment:
FWIW lxd has `--syslog` option.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
` (2 preceding siblings ...)
2020-02-17 17:12 ` CameronNemo
@ 2020-02-18 1:13 ` amak79
2020-02-18 3:59 ` CameronNemo
` (12 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: amak79 @ 2020-02-18 1:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New comment by amak79 on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587228427
Comment:
I've added conf file support to allow `--syslog` or any other option to be passed to lxd.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
` (3 preceding siblings ...)
2020-02-18 1:13 ` amak79
@ 2020-02-18 3:59 ` CameronNemo
2020-02-18 3:59 ` CameronNemo
` (11 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: CameronNemo @ 2020-02-18 3:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587267016
Comment:
vlogger logs to syslog. no use in using it when lxd can do that itself. I would suggest defaulting to passing `--syslog`. I am not using runit though, so I do not have much stake in the matter. Either way LGTM.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
` (4 preceding siblings ...)
2020-02-18 3:59 ` CameronNemo
@ 2020-02-18 3:59 ` CameronNemo
2020-02-18 4:12 ` amak79
` (10 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: CameronNemo @ 2020-02-18 3:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587267016
Comment:
vlogger logs to syslog. no use in using it when lxd can do that itself. I would suggest defaulting to passing `--syslog`. I am not using runit though, so I do not have much stake in the matter. Either way is fine by me.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
` (5 preceding siblings ...)
2020-02-18 3:59 ` CameronNemo
@ 2020-02-18 4:12 ` amak79
2020-02-18 4:19 ` CameronNemo
` (9 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: amak79 @ 2020-02-18 4:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 257 bytes --]
New comment by amak79 on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587269473
Comment:
lxd writes to tty1 even with `--syslog`. That's why I kept vlogger. I will amend the commit to use syslog by default.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
` (6 preceding siblings ...)
2020-02-18 4:12 ` amak79
@ 2020-02-18 4:19 ` CameronNemo
2020-02-18 4:28 ` amak79
` (8 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: CameronNemo @ 2020-02-18 4:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587270790
Comment:
I see... in that case you will have two copies of each message in syslog (one from lxd and one from vlogger). Less than ideal. You could throw away the stdout/stderr streams by redirecting them to `/dev/null`.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
` (7 preceding siblings ...)
2020-02-18 4:19 ` CameronNemo
@ 2020-02-18 4:28 ` amak79
2020-02-18 5:34 ` amak79
` (7 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: amak79 @ 2020-02-18 4:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
New comment by amak79 on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587272668
Comment:
I noticed the duplicated messages when testing. I will just discard stdout/stderr. Thanks.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
` (8 preceding siblings ...)
2020-02-18 4:28 ` amak79
@ 2020-02-18 5:34 ` amak79
2020-02-18 5:36 ` amak79
` (6 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: amak79 @ 2020-02-18 5:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
New comment by amak79 on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587286665
Comment:
Is there a reason why `2>&1` was added to the run script? I just realised that it was causing the messages being written to tty1. My current commit discards stdout/stderr, but it's not needed when `--syslog` is passed to lxd.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
` (9 preceding siblings ...)
2020-02-18 5:34 ` amak79
@ 2020-02-18 5:36 ` amak79
2020-02-18 5:46 ` amak79
` (5 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: amak79 @ 2020-02-18 5:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
New comment by amak79 on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587286665
Comment:
Is there a reason why `2>&1` was added to the run script? I just realised that it was the cause of messages being written to tty1. My current commit discards stdout/stderr, but it's not needed when `--syslog` is passed to lxd.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
` (10 preceding siblings ...)
2020-02-18 5:36 ` amak79
@ 2020-02-18 5:46 ` amak79
2020-02-18 5:48 ` amak79
` (4 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: amak79 @ 2020-02-18 5:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 394 bytes --]
New comment by amak79 on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587286665
Comment:
Is there a reason why `2>&1` was added to the run script? I just realised that it was the cause of messages being written to tty1. My current commit discards stdout/stderr, but it's not needed when `--syslog` is passed to lxd and stderr isn't redirected.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
` (11 preceding siblings ...)
2020-02-18 5:46 ` amak79
@ 2020-02-18 5:48 ` amak79
2020-02-18 9:04 ` xtraeme
` (3 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: amak79 @ 2020-02-18 5:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 394 bytes --]
New comment by amak79 on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587286665
Comment:
Is there a reason why `2>&1` was added to the run script? I just realised that it was the cause of messages being written to tty1. My current commit discards stdout/stderr, but it isn't needed when `--syslog` is passed to lxd and stderr isn't redirected.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
` (12 preceding siblings ...)
2020-02-18 5:48 ` amak79
@ 2020-02-18 9:04 ` xtraeme
2020-02-18 11:24 ` Duncaen
` (2 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: xtraeme @ 2020-02-18 9:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587352443
Comment:
If you are enabling syslog logging you can remove the redirects as well.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
` (13 preceding siblings ...)
2020-02-18 9:04 ` xtraeme
@ 2020-02-18 11:24 ` Duncaen
2020-02-19 0:47 ` amak79
2020-02-21 0:17 ` amak79
16 siblings, 0 replies; 17+ messages in thread
From: Duncaen @ 2020-02-18 11:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587414435
Comment:
vlogger allows to write logs to log files with svlogd and only uses syslog by default. Using vlogger to execute into svlogd is superior because it would never lose any messages (if the daemon starts before the syslog daemon or the syslog daemon is restarted).
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
` (14 preceding siblings ...)
2020-02-18 11:24 ` Duncaen
@ 2020-02-19 0:47 ` amak79
2020-02-21 0:17 ` amak79
16 siblings, 0 replies; 17+ messages in thread
From: amak79 @ 2020-02-19 0:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
New comment by amak79 on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587978145
Comment:
When the stderr redirect is removed from the run script, vlogger isn't able to log anything. With the redirect only 2 messages are logged. To use vlogger, lxd must be started with `--verbose`. This option appears to output the same messages as `--syslog`.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: lxd: add logging
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19229@inbox.vuxu.org>
` (15 preceding siblings ...)
2020-02-19 0:47 ` amak79
@ 2020-02-21 0:17 ` amak79
16 siblings, 0 replies; 17+ messages in thread
From: amak79 @ 2020-02-21 0:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
New comment by amak79 on void-packages repository
https://github.com/void-linux/void-packages/pull/19229#issuecomment-587978145
Comment:
When the stderr redirect is removed from the run script, there is nothing for vlogger to log. With the redirect only 2 error messages are logged. For vlogger to have something to log, lxd must be started with `--verbose`. This option appears to output the same messages as `--syslog`.
^ permalink raw reply [flat|nested] 17+ messages in thread