Re: lxd: add logging

Re: lxd: add logging

[amak79]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

New comment by amak79 on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-586973698

Comment:
When using a symlink I noticed that `ps` will display `./run` for the command instead of `vlogger -t lxd`. This is less informative, but if you prefer a symlink I will amend the commit.

Re: lxd: add logging

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587089216

Comment:
FWIW lxd has `--syslog` option.

Re: lxd: add logging

[amak79]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by amak79 on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587228427

Comment:
I've added conf file support to allow `--syslog` or any other option to be passed to lxd.

Re: lxd: add logging

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587267016

Comment:
vlogger logs to syslog. no use in using it when lxd can do that itself. I would suggest defaulting to passing `--syslog`. I am not using runit though, so I do not have much stake in the matter. Either way LGTM.

Re: lxd: add logging

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587267016

Comment:
vlogger logs to syslog. no use in using it when lxd can do that itself. I would suggest defaulting to passing `--syslog`. I am not using runit though, so I do not have much stake in the matter. Either way is fine by me.

Re: lxd: add logging

[amak79]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by amak79 on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587269473

Comment:
lxd writes to tty1 even with `--syslog`. That's why I kept vlogger. I will amend the commit to use syslog by default.

Re: lxd: add logging

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587270790

Comment:
I see... in that case you will have two copies of each message in syslog (one from lxd and one from vlogger). Less than ideal. You could throw away the stdout/stderr streams by redirecting them to `/dev/null`.

Re: lxd: add logging

[amak79]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by amak79 on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587272668

Comment:
I noticed the duplicated messages when testing. I will just discard stdout/stderr. Thanks.

Re: lxd: add logging

[amak79]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New comment by amak79 on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587286665

Comment:
Is there a reason why `2>&1` was added to the run script? I just realised that it was causing the messages being written to tty1. My current commit discards stdout/stderr, but it's not needed when `--syslog` is passed to lxd.

Re: lxd: add logging

[amak79]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

New comment by amak79 on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587286665

Comment:
Is there a reason why `2>&1` was added to the run script? I just realised that it was the cause of messages being written to tty1. My current commit discards stdout/stderr, but it's not needed when `--syslog` is passed to lxd.

Re: lxd: add logging

[amak79]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

New comment by amak79 on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587286665

Comment:
Is there a reason why `2>&1` was added to the run script? I just realised that it was the cause of messages being written to tty1. My current commit discards stdout/stderr, but it's not needed when `--syslog` is passed to lxd and stderr isn't redirected.

Re: lxd: add logging

[amak79]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

New comment by amak79 on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587286665

Comment:
Is there a reason why `2>&1` was added to the run script? I just realised that it was the cause of messages being written to tty1. My current commit discards stdout/stderr, but it isn't needed when `--syslog` is passed to lxd and stderr isn't redirected.

Re: lxd: add logging

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587352443

Comment:
If you are enabling syslog logging you can remove the redirects as well.

Re: lxd: add logging

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587414435

Comment:
vlogger allows to write logs to log files with svlogd and only uses syslog by default. Using vlogger to execute into svlogd is superior because it would never lose any messages (if the daemon starts before the syslog daemon or the syslog daemon is restarted).

Re: lxd: add logging

[amak79]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

New comment by amak79 on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587978145

Comment:
When the stderr redirect is removed from the run script, vlogger isn't able to log anything. With the redirect only 2 messages are logged. To use vlogger, lxd must be started with `--verbose`. This option appears to output the same messages as `--syslog`.

Re: lxd: add logging

[amak79]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

New comment by amak79 on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-587978145

Comment:
When the stderr redirect is removed from the run script, there is nothing for vlogger to log. With the redirect only 2 error messages are logged. For vlogger to have something to log, lxd must be started with `--verbose`. This option appears to output the same messages as `--syslog`.

Re: [PR PATCH] [Merged]: lxd: add logging

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

There's a merged pull request on the void-packages repository

lxd: add logging
https://github.com/void-linux/void-packages/pull/19229

Description:
This pull request adds service logging to stop lxd from sending messages to tty1.

Re: lxd: add logging

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/19229#issuecomment-586959040

Comment:
`log/run` can be a symlink to `/usr/bin/vlogger`, vlogger will get the tag from the service path.