Re: dante: enable preload support

Re: dante: enable preload support

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-586968889

Comment:
There is no ldconfig for musl, I think the configure script should be patched.

Re: dante: enable preload support

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-586973605

Comment:
If a sw depends on ldconfig that means it's a big mistake

Re: dante: enable preload support

[shtayerc]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New comment by shtayerc on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-587003393

Comment:
Looks like travis builds passed. Should I still try to fix it with patching configure scripts?

Re: dante: enable preload support

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-587020444

Comment:
Did you test it? There is an `ldconfig` wrapper in xbps-src which does nothing, its still not building preload.

* https://travis-ci.org/void-linux/void-packages/jobs/651478151#L986
* https://travis-ci.org/void-linux/void-packages/jobs/651478151#L1822

Re: dante: enable preload support

[shtayerc]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

New comment by shtayerc on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-587027429

Comment:
Weird, I tested on x86_64 locally. Only x86_64 and i686 have set nopreload. On musl it was never disabled https://travis-ci.org/void-linux/void-packages/jobs/648598388#L1694. I will look into patching configure script.

Re: dante: enable preload support

[shtayerc]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by shtayerc on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-587047912

Comment:
It should be fixed now.

Re: dante: enable preload support

[absrd]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by absrd on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-587367070

Comment:
It compiles and run, but I'm not getting any output on an socksified w3m. It works just fine when using ldconfig.

Re: dante: enable preload support

[shtayerc]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by shtayerc on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-587398159

Comment:
> It compiles and run, but I'm not getting any output on an socksified w3m. It works just fine when using ldconfig.

On which arch are you on? Exactly what command are you running?

Re: dante: enable preload support

[shtayerc]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New comment by shtayerc on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-587470271

Comment:
Without ldconfig libc must be defined manually. @Duncaen is libc name different on different archs? Maybe there is better way to do this.

Re: dante: enable preload support

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-587478634

Comment:
Yes the names are different, for glibc it will be different for every arch, for musl I think its always the same for each architecture.
I don't know if there is a good way to get the right name, maybe with help of the compiler or linker.
But `ldconfig` would also not work for cross compiling afaik. 

Re: dante: enable preload support

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-587486118

Comment:
ok, buddies... wtf is going on with this? let's look at the code to see what's wrong.  Clearly its code has a problem, let's investigate and fix.

Re: dante: enable preload support

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-587993149

Comment:
For musl you can simple use `libc.so`

Re: dante: enable preload support

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-587993149

Comment:
For musl you can simply use `libc.so`

Re: dante: enable preload support

[shtayerc]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

New comment by shtayerc on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-588105072

Comment:
This should work on glibc. Default is libc.so so on musl it selects right libc. But there is error while running socksify:
`error: symbolfunction(): compile time configuration error?  Failed to find "bindresvport" using RTLD_NEXT: Symbol not found: bindresvport`

Re: dante: enable preload support

[shtayerc]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by shtayerc on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-590920211

Comment:
I do not know how to fix error above, so package is not usefull on musl. On glibc it works. It can be merged.

Re: dante: enable preload support

[shtayerc]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New comment by shtayerc on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-621287376

Comment:
I tried `socksify` on alpine linux. It returns same error as above. I guess that package does not work on musl. @Duncaen is there anything stopping this from merging?

Re: dante: enable preload support

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-621290380

Comment:
Disabling musl builds because some hacky client feature doesn't work is not good.

Re: [PR PATCH] [Updated] dante: enable preload support

[shtayerc]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

There is an updated pull request by shtayerc against master on the void-packages repository

https://github.com/shtayerc/void-packages dante
https://github.com/void-linux/void-packages/pull/19232

dante: enable preload support
Configure script does not detect preloading support unless file /etc/ld.so.cache exists.

A patch file from https://github.com/void-linux/void-packages/pull/19232.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dante-19232.patch --]
[-- Type: text/x-diff, Size: 988 bytes --]

From ccafdc00296cbaef8d901c34cec25c38291caedd Mon Sep 17 00:00:00 2001
From: shtayerc <david.murko@mailbox.org>
Date: Sun, 22 Mar 2020 10:24:58 +0100
Subject: [PATCH] dante: enable preload support

---
 srcpkgs/dante/template | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/dante/template b/srcpkgs/dante/template
index 0d2c48da378..44e08fd6ab1 100644
--- a/srcpkgs/dante/template
+++ b/srcpkgs/dante/template
@@ -1,7 +1,7 @@
 # Template file for 'dante'
 pkgname=dante
 version=1.4.2
-revision=2
+revision=3
 build_style=gnu-configure
 hostmakedepends="tar automake libtool"
 short_desc="SOCKS server and client"
@@ -11,6 +11,10 @@ homepage="http://www.inet.no/dante/index.html"
 distfiles="http://www.inet.no/dante/files/dante-${version}.tar.gz"
 checksum=4c97cff23e5c9b00ca1ec8a95ab22972813921d7fbf60fc453e3e06382fc38a7
 
+if [ "$XBPS_TARGET_LIBC" = "glibc" ]; then
+	configure_args="--with-libc=libc.so.6"
+fi
+
 pre_configure() {
 	autoreconf -fi
 }

Re: dante: enable preload support

[shtayerc]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New comment by shtayerc on void-packages repository

https://github.com/void-linux/void-packages/pull/19232#issuecomment-621305378

Comment:
I see. This should do.

Re: [PR PATCH] [Merged]: dante: enable preload support

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

There's a merged pull request on the void-packages repository

dante: enable preload support
https://github.com/void-linux/void-packages/pull/19232

Description:
Configure script does not detect preloading support unless file /etc/ld.so.cache exists.