* Re: txt files handled by xbps-src aren't cleaned
2020-01-10 19:51 [ISSUE] txt files handled by xbps-src aren't cleaned voidlinux-github
@ 2020-01-27 19:11 ` voidlinux-github
2020-01-27 19:14 ` voidlinux-github
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-27 19:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/issues/18190#issuecomment-578904883
Comment:
Where do you want the txt files removed? The sources directory should keep a copy of them together with the sha256 symbolic link so they can be re-used and found later on by the same or other packages using them.
Or do you say they are not removed from `$wrksrc'? That would be a bug because $wrksrc should always be removed after building and packaging or checking.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: txt files handled by xbps-src aren't cleaned
2020-01-10 19:51 [ISSUE] txt files handled by xbps-src aren't cleaned voidlinux-github
2020-01-27 19:11 ` voidlinux-github
@ 2020-01-27 19:14 ` voidlinux-github
2020-01-27 19:14 ` voidlinux-github
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-27 19:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/issues/18190#issuecomment-578905984
Comment:
> Or do you say they are not removed from `$wrksrc'? That would be a bug because $wrksrc should always be removed after building and packaging or checking.
or outside of `$wrksrc`, which is expected, I usually use `create_wrksrc=yes` and `build_wrksrc` for multiple distfiles so I don't have to care about cleaning up correctly.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: txt files handled by xbps-src aren't cleaned
2020-01-10 19:51 [ISSUE] txt files handled by xbps-src aren't cleaned voidlinux-github
2020-01-27 19:11 ` voidlinux-github
2020-01-27 19:14 ` voidlinux-github
@ 2020-01-27 19:14 ` voidlinux-github
2020-01-27 19:31 ` voidlinux-github
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-27 19:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/issues/18190#issuecomment-578905984
Comment:
> Or do you say they are not removed from `$wrksrc'? That would be a bug because $wrksrc should always be removed after building and packaging or checking.
or outside of `$wrksrc`, which is expected. I usually use `create_wrksrc=yes` and `build_wrksrc` for multiple distfiles so I don't have to care about cleaning up correctly.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: txt files handled by xbps-src aren't cleaned
2020-01-10 19:51 [ISSUE] txt files handled by xbps-src aren't cleaned voidlinux-github
` (2 preceding siblings ...)
2020-01-27 19:14 ` voidlinux-github
@ 2020-01-27 19:31 ` voidlinux-github
2020-01-27 19:47 ` voidlinux-github
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-27 19:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/issues/18190#issuecomment-578913285
Comment:
Perhaps we should avoid such leftovers by removing everything below `builddir` and not just `$wrksrc` on success. I don't know for how long the `builddir/.xbps-*` directories are expected to live, though.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: txt files handled by xbps-src aren't cleaned
2020-01-10 19:51 [ISSUE] txt files handled by xbps-src aren't cleaned voidlinux-github
` (3 preceding siblings ...)
2020-01-27 19:31 ` voidlinux-github
@ 2020-01-27 19:47 ` voidlinux-github
2020-02-19 20:54 ` Chocimier
2020-02-19 20:54 ` [ISSUE] [CLOSED] " Chocimier
6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2020-01-27 19:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/issues/18190#issuecomment-578919866
Comment:
> use create_wrksrc=yes and build_wrksrc for multiple distfiles
Nice pattern. It is documented, but, undeservedly, unpopular. It may be enough to use it and require defined create_wrksrc to copy txts then.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: txt files handled by xbps-src aren't cleaned
2020-01-10 19:51 [ISSUE] txt files handled by xbps-src aren't cleaned voidlinux-github
` (4 preceding siblings ...)
2020-01-27 19:47 ` voidlinux-github
@ 2020-02-19 20:54 ` Chocimier
2020-02-19 20:54 ` [ISSUE] [CLOSED] " Chocimier
6 siblings, 0 replies; 8+ messages in thread
From: Chocimier @ 2020-02-19 20:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/issues/18190#issuecomment-588455791
Comment:
Resolved by requiring to set create_wrksrc in #19053.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ISSUE] [CLOSED] txt files handled by xbps-src aren't cleaned
2020-01-10 19:51 [ISSUE] txt files handled by xbps-src aren't cleaned voidlinux-github
` (5 preceding siblings ...)
2020-02-19 20:54 ` Chocimier
@ 2020-02-19 20:54 ` Chocimier
6 siblings, 0 replies; 8+ messages in thread
From: Chocimier @ 2020-02-19 20:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
Closed issue by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/issues/18190
Description:
If template downloads txt file, it is copied into builddir and then not removed, e.g. scons or emacs-ess.
Handling of txt should be changed to copy into wrksrc, or removed, or together with skip_extraction replaced with new variable that hold (distfile, path relative to wrksrc) pairs. Last one would be handy for many cases where XBPS_SRCDISTDIR is accessed currently.
Suggestions?
^ permalink raw reply [flat|nested] 8+ messages in thread