[ISSUE] txt files handled by xbps-src aren't cleaned

[ISSUE] txt files handled by xbps-src aren't cleaned

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

New issue by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/issues/18190

Description:
If template downloads txt file, it is copied into builddir and then not removed, e.g. emacs-ess.

Handling of txt should be changed to copy into wrksrc, or removed, or together with skip_extraction replaced with new variable that hold (distfile, path relative to wrksrc) pairs. Last one would be handy for many cases where XBPS_SRCDISTDIR is accessed currently.

Suggestions?

Re: txt files handled by xbps-src aren't cleaned

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/issues/18190#issuecomment-578904883

Comment:
Where do you want the txt files removed? The sources directory should keep a copy of them together with the sha256 symbolic link so they can be re-used and found later on by the same or other packages using them.

Or do you say they are not removed from `$wrksrc'? That would be a bug because $wrksrc should always be removed after building and packaging or checking.

Re: txt files handled by xbps-src aren't cleaned

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/issues/18190#issuecomment-578905984

Comment:
> Or do you say they are not removed from `$wrksrc'? That would be a bug because $wrksrc should always be removed after building and packaging or checking.

or outside of `$wrksrc`, which is expected, I usually use `create_wrksrc=yes` and `build_wrksrc` for multiple distfiles so I don't have to care about cleaning up correctly.

Re: txt files handled by xbps-src aren't cleaned

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/issues/18190#issuecomment-578905984

Comment:
> Or do you say they are not removed from `$wrksrc'? That would be a bug because $wrksrc should always be removed after building and packaging or checking.

or outside of `$wrksrc`, which is expected. I usually use `create_wrksrc=yes` and `build_wrksrc` for multiple distfiles so I don't have to care about cleaning up correctly.

Re: txt files handled by xbps-src aren't cleaned

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/issues/18190#issuecomment-578913285

Comment:
Perhaps we should avoid such leftovers by removing everything below `builddir` and not just `$wrksrc` on success. I don't know for how long the `builddir/.xbps-*` directories are expected to live, though.

Re: txt files handled by xbps-src aren't cleaned

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/issues/18190#issuecomment-578919866

Comment:
> use create_wrksrc=yes and build_wrksrc for multiple distfiles

Nice pattern. It is documented, but, undeservedly, unpopular. It may be enough to use it and require defined create_wrksrc to copy txts then.

Re: txt files handled by xbps-src aren't cleaned

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/issues/18190#issuecomment-588455791

Comment:
Resolved by requiring to set create_wrksrc in #19053.

Re: [ISSUE] [CLOSED] txt files handled by xbps-src aren't cleaned

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Closed issue by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/issues/18190

Description:
If template downloads txt file, it is copied into builddir and then not removed, e.g. scons or emacs-ess.

Handling of txt should be changed to copy into wrksrc, or removed, or together with skip_extraction replaced with new variable that hold (distfile, path relative to wrksrc) pairs. Last one would be handy for many cases where XBPS_SRCDISTDIR is accessed currently.

Suggestions?