Re: New package: mstflint-4.13.3

Re: New package: mstflint-4.13.3

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/19569#issuecomment-594251448

Comment:
I would do this instead:
```
diff --git a/srcpkgs/mstflint/template b/srcpkgs/mstflint/template
index 7ebe2bcd27..2a449956a4 100644
--- a/srcpkgs/mstflint/template
+++ b/srcpkgs/mstflint/template
@@ -1,8 +1,9 @@
 # Template file for 'mstflint'
 pkgname=mstflint
-version=4.13.3
+version=4.13.3r2
 revision=1
-subvers="-2"
+_version=${version/r/-}
+wrksrc=mstflint-${version%r*}
 build_style=gnu-configure
 configure_args="--enable-cs --enable-fw-mgr --enable-xml2"
 makedepends="boost-devel libcurl-devel libibmad-devel liblzma-devel libxml2-devel zlib-devel"
@@ -10,7 +11,7 @@ short_desc="Open source version of Mellanox Firmware Tools"
 maintainer="Rich Gannon <rich@richgannon.net>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/Mellanox/mstflint"
-distfiles="https://github.com/Mellanox/mstflint/releases/download/v${version}${subvers}/${pkgname}-${version}${subvers}.tar.gz"
+distfiles="https://github.com/Mellanox/mstflint/releases/download/v${_version}/${pkgname}-${_version}.tar.gz"
 checksum=3abc918311fc07e4add7564879bd4a8def8ccfed40962f31682c75f2ee8a58d1
 
 mstflint-devel_package() {
```

Anyway, cross-compile and musl build are broken.

Re: New package: mstflint-4.13.3

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/19569#issuecomment-594251448

Comment:
I would do this instead:
```diff
diff --git a/srcpkgs/mstflint/template b/srcpkgs/mstflint/template
index 7ebe2bcd27..2a449956a4 100644
--- a/srcpkgs/mstflint/template
+++ b/srcpkgs/mstflint/template
@@ -1,8 +1,9 @@
 # Template file for 'mstflint'
 pkgname=mstflint
-version=4.13.3
+version=4.13.3r2
 revision=1
-subvers="-2"
+_version=${version/r/-}
+wrksrc=mstflint-${version%r*}
 build_style=gnu-configure
 configure_args="--enable-cs --enable-fw-mgr --enable-xml2"
 makedepends="boost-devel libcurl-devel libibmad-devel liblzma-devel libxml2-devel zlib-devel"
@@ -10,7 +11,7 @@ short_desc="Open source version of Mellanox Firmware Tools"
 maintainer="Rich Gannon <rich@richgannon.net>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/Mellanox/mstflint"
-distfiles="https://github.com/Mellanox/mstflint/releases/download/v${version}${subvers}/${pkgname}-${version}${subvers}.tar.gz"
+distfiles="https://github.com/Mellanox/mstflint/releases/download/v${_version}/${pkgname}-${_version}.tar.gz"
 checksum=3abc918311fc07e4add7564879bd4a8def8ccfed40962f31682c75f2ee8a58d1
 
 mstflint-devel_package() {
```

Anyway, cross-compile and musl build are broken.

Re: New package: mstflint-4.13.3

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/19569#issuecomment-594270321

Comment:
This fixup for musl:
```diff
 srcpkgs/mstflint/patches/musl.patch | 11 +++++++++++
 srcpkgs/mstflint/template           |  2 ++
 2 files changed, 13 insertions(+)

diff --git a/srcpkgs/mstflint/patches/musl.patch b/srcpkgs/mstflint/patches/musl.patch
new file mode 100644
index 0000000000..524c077438
--- /dev/null
+++ b/srcpkgs/mstflint/patches/musl.patch
@@ -0,0 +1,11 @@
+--- mtcr_ul/mtcr_ul_com.c.orig	2020-03-04 08:19:35.889730972 +0700
++++ mtcr_ul/mtcr_ul_com.c	2020-03-04 08:19:41.690743181 +0700
+@@ -76,7 +76,7 @@
+ 
+ #if CONFIG_ENABLE_MMAP
+ #include <sys/mman.h>
++#include <linux/pci.h>
+-#include <sys/pci.h>
+ #include <sys/ioctl.h>
+ #endif
+ 
diff --git a/srcpkgs/mstflint/template b/srcpkgs/mstflint/template
index 7ebe2bcd27..5dfb7283b9 100644
--- a/srcpkgs/mstflint/template
+++ b/srcpkgs/mstflint/template
@@ -13,6 +13,8 @@ homepage="https://github.com/Mellanox/mstflint"
 distfiles="https://github.com/Mellanox/mstflint/releases/download/v${version}${subvers}/${pkgname}-${version}${subvers}.tar.gz"
 checksum=3abc918311fc07e4add7564879bd4a8def8ccfed40962f31682c75f2ee8a58d1
 
+CFLAGS="-Du_int8_t=uint8_t -Du_int16_t=uint16_t -Du_int32_t=uint32_t -Du_int64_t=uint64_t"
+
 mstflint-devel_package() {
 	depends="${pkgname}-${version}_${revision}"
 	short_desc+=" - development files"
```

Re: New package: mstflint-4.13.3

[ArmedAviator]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by ArmedAviator on void-packages repository

https://github.com/void-linux/void-packages/pull/19569#issuecomment-594276043

Comment:
Thanks sgn!

I updated with the musl patch and the reversioning.

Re: [PR PATCH] [Closed]: New package: mstflint-4.13.3

[ArmedAviator]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

There's a closed pull request on the void-packages repository

New package: mstflint-4.13.3
https://github.com/void-linux/void-packages/pull/19569

Description:
Package used to control Infiniband network cards, including firmware updates.

2 Issues:
   - Not sure how to properly handle the upstream versioning properly.
   - The packaging fails to identify that it needs boost_regex1.69.  How do I fix this?