Re: [WIP] nerd-fonts: fix font source

Re: [WIP] nerd-fonts: fix font source

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/19976#issuecomment-596874202

Comment:
Alright, I've added your suggested changes, and the package now builds and installs perfectly. Thank you so much for the assistance; I feel pretty silly for not thinking of using `find`. The last two force-pushed commits were just removing redundant lines and complying with xlint; respectively. Once the checks (hopefully) pass, the template should be fine to merge.

Re: nerd-fonts: fix font source

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/19976#issuecomment-598881850

Comment:
Sorry to bother you again @daniel-eys, but since you seem like a regular contributor to this repo I thought you'd know: How long does it normally take a package like this to get merged?

Re: nerd-fonts: fix font source

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/19976#issuecomment-598965183

Comment:
There's no fixed timeline when things like this get merged.
As soon as some void dev comes across this, it should be merged right away.
Maybe give them a friendly ping on IRC, this is where most of them hang out.

Oh btw, the commit message still has the [WIP] marker.

Re: [PR PATCH] [Merged]: nerd-fonts: fix font source

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

There's a merged pull request on the void-packages repository

nerd-fonts: fix font source
https://github.com/void-linux/void-packages/pull/19976

Description:
(Paging @daniel-eys) This commit does not quite work yet, but it's a start in fixing the font source issue I created with the last nerd-fonts commit. Please do NOT merge this yet, even if it passes the builder tests. Attached is a log file showing the output of xbps-src attempting to package nerd-fonts using this template. I'm stumped as to what could be going  wrong.
[nerd-fonts.log](https://github.com/void-linux/void-packages/files/4306838/nerd-fonts.log)

Re: [WIP] nerd-fonts: fix font source

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 2207 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/19976#issuecomment-596599343

Comment:
* `create_wrksrc` and `build_wrksrc` are not needed anymore, upstream's tarball follows void's standard `${pkgname}-${version}`

* No need to fetch those `i_*.sh` scripts anymore, upstream's tarball includes them already.

* `do_install()` needed some adjustments to reflect the structure of the new tarball.

* I switched to `find ... -exec install ...` to really collect all .otf / .ttf files.

This is what I came up with. Feel free to include my suggestions.

```sh
# Template file for 'nerd-fonts'
pkgname=nerd-fonts
version=2.1.0
revision=2
archs=noarch
depends="font-util xbps-triggers nerd-fonts-ttf nerd-fonts-otf"
short_desc="Iconic font aggregator, collection and patcher"
maintainer="cinerea0 <cinerea0@protonmail.com>"
license="MIT"
homepage="https://nerdfonts.com"
distfiles="https://github.com/ryanoasis/nerd-fonts/archive/v${version}.tar.gz"
checksum="a084ca91a174b547bab4523507824c76aa91ebcf38f9256a4ffd181813f87bd8"

do_install() {
	vmkdir usr/share/fonts/NerdFonts/otf
	vmkdir usr/share/fonts/NerdFonts/ttf
	vmkdir usr/lib/NerdFonts

	find patched-fonts -name '*.otf' -exec install -Dm644 '{}' ${DESTDIR}/usr/share/fonts/NerdFonts/otf \;
	find patched-fonts -name '*.ttf' -exec install -Dm644 '{}' ${DESTDIR}/usr/share/fonts/NerdFonts/ttf \;

	# Remove Windows Compatible font versions
	find ${DESTDIR}/usr/share/fonts/NerdFonts -name '*Windows Compatible.*tf' -delete

	for sh in bin/scripts/lib/i_*.sh; do
		vinstall $sh 744 usr/lib/NerdFonts
	done

	vlicense LICENSE
}

nerd-fonts-otf_package() {
	archs=noarch
	short_desc="Iconic font aggregator, collection and patcher - otf fonts"
	font_dirs="usr/share/fonts/NerdFonts/otf"
	depends="font-util xbps-triggers"
	pkg_install() {
		vmove usr/share/fonts/NerdFonts/otf
	}
}

nerd-fonts-ttf_package() {
	archs=noarch
	short_desc="Iconic font aggregator, collection and patcher - ttf fonts"
	font_dirs="usr/share/fonts/NerdFonts/ttf"
	depends="font-util xbps-triggers"
	pkg_install() {
		vmove usr/share/fonts/NerdFonts/ttf
	}
}
```