Re: Firefox 74

Re: Firefox 74

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/20012#issuecomment-597296049

Comment:
Broken on ppc64le:
```
=> firefox-74.0_1: patching: fix-toolkit.patch.
1 out of 1 hunk FAILED -- saving rejects to file toolkit/mozapps/update/common/updatedefines.h.rej
```

It's beyond me to fix the specific problem, I'll have to defer to @q66. 

Re: Firefox 74

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/20012#issuecomment-597296049

Comment:
Broken on ppc64le:
```
=> firefox-74.0_1: patching: fix-toolkit.patch.
1 out of 1 hunk FAILED -- saving rejects to file toolkit/mozapps/update/common/updatedefines.h.rej
```

It's beyond me to fix the specific problem, I'll have to defer to @q66.  Shouldn't gate the merge of this though. 

Re: Firefox 74

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/20012#issuecomment-597296049

Comment:
Broken on ppc64le:
```
=> firefox-74.0_1: patching: fix-toolkit.patch.
1 out of 1 hunk FAILED -- saving rejects to file toolkit/mozapps/update/common/updatedefines.h.rej
```

It's beyond me to fix the specific problem, I'll have to defer to @q66.  Shouldn't gate the merge of this though. 

Re: Firefox 74

[jnbr]

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/20012#issuecomment-597327262

Comment:
On Tue, 10 Mar 2020 13:23:36 -0700
Zach Dykstra <notifications@github.com> wrote:

> Broken on ppc64le:
> ```
> => firefox-74.0_1: patching: fix-toolkit.patch.  
> 1 out of 1 hunk FAILED -- saving rejects to file
> toolkit/mozapps/update/common/updatedefines.h.rej ```
> 
> It's beyond me to fix the specific problem, I'll have to defer to
> @q66. 
> 

This is weird because this hunk was removed from the patchset.
Make sure your branch is up to date.

Re: Firefox 74

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/20012#issuecomment-597351001

Comment:
> This is weird because this hunk was removed from the patchset. Make sure your branch is up to date.

Yup, quick-and-dirty work on my end was incomplete. I caught it right after I commented, so I deleted it. Now my shame is public ;)

Re: Firefox 74

[michaelforney]

[-- Attachment #1: Type: text/plain, Size: 704 bytes --]

New comment by michaelforney on void-packages repository

https://github.com/void-linux/void-packages/pull/20012#issuecomment-597496489

Comment:
Some more of the patch hunks can be dropped; firefox 74 includes a few other upstreamed musl fixes.

- fix-seccomp-bpf.patch is no longer necessary, it was fixed in https://hg.mozilla.org/mozilla-central/rev/3ec8c96f4d53
- The `__NR_pread` hunk in fix-toolkit.patch is no longer necessary, it was fixed in https://hg.mozilla.org/mozilla-central/rev/660da1ec99c0

Additionally, you might consider dropping the basename hunk in fix-tools.patch in favor of the upstream fix scheduled for firefox 75: https://hg.mozilla.org/mozilla-central/rev/a3096ca24124

Re: Firefox 74

[jnbr]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/20012#issuecomment-597820719

Comment:
That's nice. Thank you. I've updated the PR.

Re: Firefox 74

[michaelforney]

[-- Attachment #1: Type: text/plain, Size: 704 bytes --]

New comment by michaelforney on void-packages repository

https://github.com/void-linux/void-packages/pull/20012#issuecomment-597875781

Comment:
Looking through the remaining patches, I think the libgen.h hunk in fix-toolkit.patch is not necessary since firefox 63: https://hg.mozilla.org/mozilla-central/diff/5284d9a25ffb3ec2130f2526f1b8785a9e48e0ba/toolkit/crashreporter/google-breakpad/src/common/linux/dump_symbols.cc.

The two other remaining hunks fix-toolkit.patch also don't seem necessary. stabs_reader.cc is only built on Darwin since firefox 47: https://hg.mozilla.org/mozilla-central/diff/62a0d8c93da2ca24f3f87642a2989c4741f214d4/toolkit/crashreporter/google-breakpad/src/common/moz.build

Re: Firefox 74

[jnbr]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/20012#issuecomment-598035134

Comment:
Thank you for reviewing these patches.

Re: [PR PATCH] [Merged]: Firefox 74

[jnbr]

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

There's a merged pull request on the void-packages repository

Firefox 74
https://github.com/void-linux/void-packages/pull/20012

Description:

Re: Firefox 74

[jnbr]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/20012#issuecomment-597282336

Comment:
Tested briefly on x86_64, glibc and musl.
Builds pass for arm7, aarch64 and i686 as well.