* Re: Firefox 74
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20012@inbox.vuxu.org>
@ 2020-03-10 20:23 ` zdykstra
2020-03-10 20:24 ` zdykstra
` (8 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: zdykstra @ 2020-03-10 20:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
New comment by zdykstra on void-packages repository
https://github.com/void-linux/void-packages/pull/20012#issuecomment-597296049
Comment:
Broken on ppc64le:
```
=> firefox-74.0_1: patching: fix-toolkit.patch.
1 out of 1 hunk FAILED -- saving rejects to file toolkit/mozapps/update/common/updatedefines.h.rej
```
It's beyond me to fix the specific problem, I'll have to defer to @q66.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Firefox 74
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20012@inbox.vuxu.org>
2020-03-10 20:23 ` Firefox 74 zdykstra
@ 2020-03-10 20:24 ` zdykstra
2020-03-10 20:24 ` zdykstra
` (7 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: zdykstra @ 2020-03-10 20:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
New comment by zdykstra on void-packages repository
https://github.com/void-linux/void-packages/pull/20012#issuecomment-597296049
Comment:
Broken on ppc64le:
```
=> firefox-74.0_1: patching: fix-toolkit.patch.
1 out of 1 hunk FAILED -- saving rejects to file toolkit/mozapps/update/common/updatedefines.h.rej
```
It's beyond me to fix the specific problem, I'll have to defer to @q66. Shouldn't gate the merge of this though.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Firefox 74
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20012@inbox.vuxu.org>
2020-03-10 20:23 ` Firefox 74 zdykstra
2020-03-10 20:24 ` zdykstra
@ 2020-03-10 20:24 ` zdykstra
2020-03-10 21:29 ` jnbr
` (6 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: zdykstra @ 2020-03-10 20:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
New comment by zdykstra on void-packages repository
https://github.com/void-linux/void-packages/pull/20012#issuecomment-597296049
Comment:
Broken on ppc64le:
```
=> firefox-74.0_1: patching: fix-toolkit.patch.
1 out of 1 hunk FAILED -- saving rejects to file toolkit/mozapps/update/common/updatedefines.h.rej
```
It's beyond me to fix the specific problem, I'll have to defer to @q66. Shouldn't gate the merge of this though.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Firefox 74
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20012@inbox.vuxu.org>
` (2 preceding siblings ...)
2020-03-10 20:24 ` zdykstra
@ 2020-03-10 21:29 ` jnbr
2020-03-10 22:26 ` zdykstra
` (5 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: jnbr @ 2020-03-10 21:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
New comment by jnbr on void-packages repository
https://github.com/void-linux/void-packages/pull/20012#issuecomment-597327262
Comment:
On Tue, 10 Mar 2020 13:23:36 -0700
Zach Dykstra <notifications@github.com> wrote:
> Broken on ppc64le:
> ```
> => firefox-74.0_1: patching: fix-toolkit.patch.
> 1 out of 1 hunk FAILED -- saving rejects to file
> toolkit/mozapps/update/common/updatedefines.h.rej ```
>
> It's beyond me to fix the specific problem, I'll have to defer to
> @q66.
>
This is weird because this hunk was removed from the patchset.
Make sure your branch is up to date.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Firefox 74
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20012@inbox.vuxu.org>
` (3 preceding siblings ...)
2020-03-10 21:29 ` jnbr
@ 2020-03-10 22:26 ` zdykstra
2020-03-11 8:06 ` michaelforney
` (4 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: zdykstra @ 2020-03-10 22:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
New comment by zdykstra on void-packages repository
https://github.com/void-linux/void-packages/pull/20012#issuecomment-597351001
Comment:
> This is weird because this hunk was removed from the patchset. Make sure your branch is up to date.
Yup, quick-and-dirty work on my end was incomplete. I caught it right after I commented, so I deleted it. Now my shame is public ;)
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Firefox 74
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20012@inbox.vuxu.org>
` (4 preceding siblings ...)
2020-03-10 22:26 ` zdykstra
@ 2020-03-11 8:06 ` michaelforney
2020-03-11 19:19 ` jnbr
` (3 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: michaelforney @ 2020-03-11 8:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
New comment by michaelforney on void-packages repository
https://github.com/void-linux/void-packages/pull/20012#issuecomment-597496489
Comment:
Some more of the patch hunks can be dropped; firefox 74 includes a few other upstreamed musl fixes.
- fix-seccomp-bpf.patch is no longer necessary, it was fixed in https://hg.mozilla.org/mozilla-central/rev/3ec8c96f4d53
- The `__NR_pread` hunk in fix-toolkit.patch is no longer necessary, it was fixed in https://hg.mozilla.org/mozilla-central/rev/660da1ec99c0
Additionally, you might consider dropping the basename hunk in fix-tools.patch in favor of the upstream fix scheduled for firefox 75: https://hg.mozilla.org/mozilla-central/rev/a3096ca24124
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Firefox 74
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20012@inbox.vuxu.org>
` (5 preceding siblings ...)
2020-03-11 8:06 ` michaelforney
@ 2020-03-11 19:19 ` jnbr
2020-03-11 20:59 ` michaelforney
` (2 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: jnbr @ 2020-03-11 19:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 182 bytes --]
New comment by jnbr on void-packages repository
https://github.com/void-linux/void-packages/pull/20012#issuecomment-597820719
Comment:
That's nice. Thank you. I've updated the PR.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Firefox 74
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20012@inbox.vuxu.org>
` (6 preceding siblings ...)
2020-03-11 19:19 ` jnbr
@ 2020-03-11 20:59 ` michaelforney
2020-03-12 6:55 ` jnbr
2020-03-12 17:49 ` [PR PATCH] [Merged]: " jnbr
9 siblings, 0 replies; 10+ messages in thread
From: michaelforney @ 2020-03-11 20:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
New comment by michaelforney on void-packages repository
https://github.com/void-linux/void-packages/pull/20012#issuecomment-597875781
Comment:
Looking through the remaining patches, I think the libgen.h hunk in fix-toolkit.patch is not necessary since firefox 63: https://hg.mozilla.org/mozilla-central/diff/5284d9a25ffb3ec2130f2526f1b8785a9e48e0ba/toolkit/crashreporter/google-breakpad/src/common/linux/dump_symbols.cc.
The two other remaining hunks fix-toolkit.patch also don't seem necessary. stabs_reader.cc is only built on Darwin since firefox 47: https://hg.mozilla.org/mozilla-central/diff/62a0d8c93da2ca24f3f87642a2989c4741f214d4/toolkit/crashreporter/google-breakpad/src/common/moz.build
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Firefox 74
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20012@inbox.vuxu.org>
` (7 preceding siblings ...)
2020-03-11 20:59 ` michaelforney
@ 2020-03-12 6:55 ` jnbr
2020-03-12 17:49 ` [PR PATCH] [Merged]: " jnbr
9 siblings, 0 replies; 10+ messages in thread
From: jnbr @ 2020-03-12 6:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 176 bytes --]
New comment by jnbr on void-packages repository
https://github.com/void-linux/void-packages/pull/20012#issuecomment-598035134
Comment:
Thank you for reviewing these patches.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Merged]: Firefox 74
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20012@inbox.vuxu.org>
` (8 preceding siblings ...)
2020-03-12 6:55 ` jnbr
@ 2020-03-12 17:49 ` jnbr
9 siblings, 0 replies; 10+ messages in thread
From: jnbr @ 2020-03-12 17:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 144 bytes --]
There's a merged pull request on the void-packages repository
Firefox 74
https://github.com/void-linux/void-packages/pull/20012
Description:
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-03-12 17:49 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20012@inbox.vuxu.org>
2020-03-10 20:23 ` Firefox 74 zdykstra
2020-03-10 20:24 ` zdykstra
2020-03-10 20:24 ` zdykstra
2020-03-10 21:29 ` jnbr
2020-03-10 22:26 ` zdykstra
2020-03-11 8:06 ` michaelforney
2020-03-11 19:19 ` jnbr
2020-03-11 20:59 ` michaelforney
2020-03-12 6:55 ` jnbr
2020-03-12 17:49 ` [PR PATCH] [Merged]: " jnbr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).