Re: go: add build_style=go to avoid code duplication

Re: go: add build_style=go to avoid code duplication

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/20435#issuecomment-605711092

Comment:
This adds go to hostmakedepends and therefore results in a build loop for noncross architectures.

Re: go: add build_style=go to avoid code duplication

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20435#issuecomment-605745797

Comment:
> This adds go to hostmakedepends and therefore results in a build loop for noncross architectures.

Yeah, I was messing with it and noticed this issue when building for a second time. Do you know if I could just source the c/e/build_style/go.sh file? From what I read of the manual, there isn't any variable that points to the directory where xbps-src is located and I don't know if it's possible for the script to be run from anywhere or if it's always supposed to be run as `./xbps-src`.

Re: go: add build_style=go to avoid code duplication

[q66]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20435#issuecomment-605759382

Comment:
`broken` does not work in environment, it's not a variable.

Re: go: add build_style=go to avoid code duplication

[q66]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20435#issuecomment-605759382

Comment:
`broken` does not work in environment, it's not a variable

this PR doesn't really make sense

Re: go: add build_style=go to avoid code duplication

[q66]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20435#issuecomment-605764728

Comment:
ec937e4d293c642dc45c20deef479dc79d80751a and 927e7904637a29650019668ee193d13efb2afda0 addressed the functional concerns of this, other than that it doesn't really make sense to set `build-style` here as there is too much of a mismatch and attempting to merge them would create more code than remove.

Re: [PR PATCH] [Closed]: go: add build_style=go to avoid code duplication

[q66]

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

There's a closed pull request on the void-packages repository

go: add build_style=go to avoid code duplication
https://github.com/void-linux/void-packages/pull/20435

Description:
The GOARCH selection snippet was duplicated in the go build_style script
for environment variables and in the go template itself. Furthermore,
there were discrepancies between the two snippets, which have been
fixed.

This makes the go template leaner, and makes both cases more robust (changes to GOARCH selection can be done in a single place).

Re: go: add build_style=go to avoid code duplication

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20435#issuecomment-605586929

Comment:
Seems some builds failed with timeouts, with others the issue was memory consumption during the bootstrap process:

> cc1plus: out of memory allocating 262144 bytes after a total of 3915776 bytes