Re: [PR PATCH] [Closed]: New package: go-pie

Re: [PR PATCH] [Closed]: New package: go-pie

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

There's a closed pull request on the void-packages repository

New package: go-pie
https://github.com/void-linux/void-packages/pull/20450

Description:
This package makes it possible to build Go binaries with PIE.

Both Arch Linux and Alpine already implement this feature. Arch has a package called go-pie that's used for most of their PKGBUILDs, while the only version of Go on Alpine is one capable of producing PIE binaries.

* On Arch: https://www.archlinux.org/packages/community/x86_64/go-pie/
* On Alpine: https://pkgs.alpinelinux.org/package/edge/community/x86_64/go

The patch used here is actually adapted from the one used by Arch, and if adopted can allow us to remove the nostrip flag from the go build_style.

I'm getting some weird build output, where it says

```
loadinternal: cannot find runtime/cgo
```

so I'm not completely certain that it's 100% complete. Building a program that uses cgo does work cleanly, so I'm not sure what it means.

It's referenced [in this issue](https://github.com/golang/go/issues/31544), but without any solution.

Re: New package: go-pie

[q66]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20450#issuecomment-605769834

Comment:
do we need a separate PIE compiler? if this works reliably, we could just have it do that always, we already do default-pie for the primary system toolchain, but my knowledge of the toolchain is limited, so I'll refrain from making any claims here; maybe @the-maldridge can provide some insight

Re: New package: go-pie

[q66]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20450#issuecomment-605769834

Comment:
do we need a separate PIE compiler? if this works reliably, we could just have it do that always, we already do default-pie for the primary system toolchain, but my knowledge of the toolchain is limited, so I'll refrain from making any claims here; maybe @the-maldridge can provide some insight

what we definitely do not want is another template that's more or less a copy of the original, that's just a pain to maintain and get synchronized, no matter how much of it you try to move into build-style

Re: New package: go-pie

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/20450#issuecomment-605770095

Comment:
For a long time PIE had problems with Go which is why we disabled it.  If we were to run a universe build and observe that there was no serious breakage, I could see turning it on in the default compiler.

Re: New package: go-pie

[q66]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20450#issuecomment-605770264

Comment:
universe rebuild shouldn't exactly be an issue, should be done in a day or so...

Re: New package: go-pie

[q66]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20450#issuecomment-605770264

Comment:
universe rebuild shouldn't exactly be an issue, should be done in a day or so... another matter is testing, everything would need to get tested for brokenness :P

Re: New package: go-pie

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20450#issuecomment-606418468

Comment:
@q66 what sort of testing would have to be done? I just installed Void on my Rasp, so I have one more arch target to test this change against. How would the packages of a rebuild be offered? (I can also script a detection for packages with the go build_style, and try and build them locally).

Should I open a PR with just the patch then?

Re: New package: go-pie

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/20450#issuecomment-606438068

Comment:
If we were to adopt this then it would be for the compiler itself that is the main one.  there's not a really good way to test that easily though, so I don't have tips for what the acceptance process would be.