* Re: New package: go-pie
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20450@inbox.vuxu.org>
@ 2020-03-30 3:48 ` ericonr
2020-03-30 3:49 ` [PR PATCH] [Closed]: " ericonr
` (7 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-03-30 3:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/20450#issuecomment-605767562
Comment:
Given that #20435 was closed, I will have to rewrite this one. I will close it and reopen it later, then. Make an issue to discuss it as well.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Closed]: New package: go-pie
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20450@inbox.vuxu.org>
2020-03-30 3:48 ` New package: go-pie ericonr
@ 2020-03-30 3:49 ` ericonr
2020-03-30 4:01 ` q66
` (6 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-03-30 3:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]
There's a closed pull request on the void-packages repository
New package: go-pie
https://github.com/void-linux/void-packages/pull/20450
Description:
This package makes it possible to build Go binaries with PIE.
Both Arch Linux and Alpine already implement this feature. Arch has a package called go-pie that's used for most of their PKGBUILDs, while the only version of Go on Alpine is one capable of producing PIE binaries.
* On Arch: https://www.archlinux.org/packages/community/x86_64/go-pie/
* On Alpine: https://pkgs.alpinelinux.org/package/edge/community/x86_64/go
The patch used here is actually adapted from the one used by Arch, and if adopted can allow us to remove the nostrip flag from the go build_style.
I'm getting some weird build output, where it says
```
loadinternal: cannot find runtime/cgo
```
so I'm not completely certain that it's 100% complete. Building a program that uses cgo does work cleanly, so I'm not sure what it means.
It's referenced [in this issue](https://github.com/golang/go/issues/31544), but without any solution.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: New package: go-pie
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20450@inbox.vuxu.org>
2020-03-30 3:48 ` New package: go-pie ericonr
2020-03-30 3:49 ` [PR PATCH] [Closed]: " ericonr
@ 2020-03-30 4:01 ` q66
2020-03-30 4:02 ` q66
` (5 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: q66 @ 2020-03-30 4:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 431 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/20450#issuecomment-605769834
Comment:
do we need a separate PIE compiler? if this works reliably, we could just have it do that always, we already do default-pie for the primary system toolchain, but my knowledge of the toolchain is limited, so I'll refrain from making any claims here; maybe @the-maldridge can provide some insight
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: New package: go-pie
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20450@inbox.vuxu.org>
` (2 preceding siblings ...)
2020-03-30 4:01 ` q66
@ 2020-03-30 4:02 ` q66
2020-03-30 4:02 ` the-maldridge
` (4 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: q66 @ 2020-03-30 4:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/20450#issuecomment-605769834
Comment:
do we need a separate PIE compiler? if this works reliably, we could just have it do that always, we already do default-pie for the primary system toolchain, but my knowledge of the toolchain is limited, so I'll refrain from making any claims here; maybe @the-maldridge can provide some insight
what we definitely do not want is another template that's more or less a copy of the original, that's just a pain to maintain and get synchronized, no matter how much of it you try to move into build-style
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: New package: go-pie
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20450@inbox.vuxu.org>
` (3 preceding siblings ...)
2020-03-30 4:02 ` q66
@ 2020-03-30 4:02 ` the-maldridge
2020-03-30 4:03 ` q66
` (3 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: the-maldridge @ 2020-03-30 4:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/20450#issuecomment-605770095
Comment:
For a long time PIE had problems with Go which is why we disabled it. If we were to run a universe build and observe that there was no serious breakage, I could see turning it on in the default compiler.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: New package: go-pie
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20450@inbox.vuxu.org>
` (4 preceding siblings ...)
2020-03-30 4:02 ` the-maldridge
@ 2020-03-30 4:03 ` q66
2020-03-30 4:10 ` q66
` (2 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: q66 @ 2020-03-30 4:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/20450#issuecomment-605770264
Comment:
universe rebuild shouldn't exactly be an issue, should be done in a day or so...
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: New package: go-pie
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20450@inbox.vuxu.org>
` (5 preceding siblings ...)
2020-03-30 4:03 ` q66
@ 2020-03-30 4:10 ` q66
2020-03-31 6:01 ` ericonr
2020-03-31 6:57 ` the-maldridge
8 siblings, 0 replies; 9+ messages in thread
From: q66 @ 2020-03-30 4:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 298 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/20450#issuecomment-605770264
Comment:
universe rebuild shouldn't exactly be an issue, should be done in a day or so... another matter is testing, everything would need to get tested for brokenness :P
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: New package: go-pie
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20450@inbox.vuxu.org>
` (6 preceding siblings ...)
2020-03-30 4:10 ` q66
@ 2020-03-31 6:01 ` ericonr
2020-03-31 6:57 ` the-maldridge
8 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-03-31 6:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 481 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/20450#issuecomment-606418468
Comment:
@q66 what sort of testing would have to be done? I just installed Void on my Rasp, so I have one more arch target to test this change against. How would the packages of a rebuild be offered? (I can also script a detection for packages with the go build_style, and try and build them locally).
Should I open a PR with just the patch then?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: New package: go-pie
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20450@inbox.vuxu.org>
` (7 preceding siblings ...)
2020-03-31 6:01 ` ericonr
@ 2020-03-31 6:57 ` the-maldridge
8 siblings, 0 replies; 9+ messages in thread
From: the-maldridge @ 2020-03-31 6:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 356 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/20450#issuecomment-606438068
Comment:
If we were to adopt this then it would be for the compiler itself that is the main one. there's not a really good way to test that easily though, so I don't have tips for what the acceptance process would be.
^ permalink raw reply [flat|nested] 9+ messages in thread