Re: New packages: tageditor, tagparser and c++utilities

Re: New packages: tageditor, tagparser and c++utilities

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/19844#issuecomment-606264763

Comment:
Packages are usually named like tarball, not necessarily like content, so `cpp-utilities`. Otherwise looks ok. Build with webengine option passes.

Re: New packages: tageditor, tagparser and c++utilities

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/19844#issuecomment-614285596

Comment:
Good job!

Re: New packages: tageditor, tagparser and c++utilities

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/19844#issuecomment-614281242

Comment:
> Tested, works. But please move changes to [proper commits](https://github.com/void-linux/void-packages/pull/19844/commits/1a88641dd9a4aaa4bfdbc4b998ebc6fa03a6badb#diff-816e5624e093eafd5fac2aa7b3b46e83R7), reorder so deps go before package using it, fix commit titles - no revision, remove `wrksrc="${pkgname}-${version}"` that is default.

Thanks for catching these mistakes. I've reworded the commit messages, moved the misplaced change to its proper commit (an artifact of an earlier rebase), and removed the unnecessary `wrksrc` definition (an artifact of the `c++utilities` to `cpp-utilities` rename).

The Github comment thread seems to be sorting the commit messages according to the order I originally added these packages, but the commits are ordered properly in `git log`. If you view history for commit [`926e663`](https://github.com/void-linux/void-packages/commits/926e663ace2a1ab81ae344cd52014115c757bb13/srcpkgs), you should see that the `qtutilities` commit is listed before the `tageditor` commit. 

Re: New packages: tageditor, tagparser and c++utilities

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/19844#issuecomment-614281242

Comment:
> Tested, works. But please move changes to [proper commits](https://github.com/void-linux/void-packages/pull/19844/commits/1a88641dd9a4aaa4bfdbc4b998ebc6fa03a6badb#diff-816e5624e093eafd5fac2aa7b3b46e83R7), reorder so deps go before package using it, fix commit titles - no revision, remove `wrksrc="${pkgname}-${version}"` that is default.

Thanks for catching these mistakes. I've reworded the commit messages, moved the misplaced change to its proper commit (an artifact of an earlier rebase), and removed the unnecessary `wrksrc` definition (an artifact of the `c++utilities` to `cpp-utilities` rename).

The Github comment thread seems to be sorting the commit messages alphabetically, but the commits are ordered properly in `git log`. If you view history for commit [`926e663`](https://github.com/void-linux/void-packages/commits/926e663ace2a1ab81ae344cd52014115c757bb13/srcpkgs), you should see that the `qtutilities` commit is listed before the `tageditor` commit. 

Re: New packages: tageditor, tagparser and c++utilities

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/19844#issuecomment-614262318

Comment:
Tested, works. But please move changes to [proper commits](https://github.com/void-linux/void-packages/pull/19844/commits/1a88641dd9a4aaa4bfdbc4b998ebc6fa03a6badb#diff-816e5624e093eafd5fac2aa7b3b46e83R7), reorder so deps go before package using it, fix commit titles - no revision, remove `wrksrc="${pkgname}-${version}"` that is default.

Re: New packages: tageditor, tagparser and c++utilities

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/19844#issuecomment-612405996

Comment:
> Please rebase

Done, thanks!

Re: New packages: tageditor, tagparser and c++utilities

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/19844#issuecomment-612399145

Comment:
Please rebase

Re: New packages: tageditor, tagparser and c++utilities

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/19844#issuecomment-606300844

Comment:
> Packages are usually named like tarball, not necessarily like content, so `cpp-utilities`. Otherwise looks ok. Build with webengine option passes.

That was my original name for the package, but in reworking everything I moved to `c++utilities` because of the contents. I've reverted back to `cpp-utilities` as recommended.