[PR PATCH] docker: Fix runit service

[PR PATCH] docker: Fix runit service

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

There is a new pull request by beanpole135 against master on the void-packages repository

https://github.com/beanpole135/void-packages patch/docker
https://github.com/void-linux/void-packages/pull/21254

docker: Fix runit service
The "-s=overlay2" command line flag appears to prevent the service from starting.
Comment out this line in the service file for now.

A patch file from https://github.com/void-linux/void-packages/pull/21254.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch/docker-21254.patch --]
[-- Type: text/x-diff, Size: 910 bytes --]

From 38333b06ccd79e8c34aad29c8ba33a6feb2130a4 Mon Sep 17 00:00:00 2001
From: Ken Moore <moorekou@gmail.com>
Date: Wed, 22 Apr 2020 16:03:42 -0400
Subject: [PATCH] docker: Fix runit service

The "-s=overlay2" command line flag appears to prevent the service from starting.
Comment out this line in the service file for now.
---
 srcpkgs/docker/files/docker/run | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/docker/files/docker/run b/srcpkgs/docker/files/docker/run
index 9922e2f6196..4bacda69df3 100755
--- a/srcpkgs/docker/files/docker/run
+++ b/srcpkgs/docker/files/docker/run
@@ -5,5 +5,5 @@ mountpoint -q /sys/fs/cgroup/systemd || {
     mkdir -p /sys/fs/cgroup/systemd;
     mount -t cgroup -o none,name=systemd cgroup /sys/fs/cgroup/systemd;
 }
-[ -n "$OPTS" ] || OPTS="-s=overlay2"
+#[ -n "$OPTS" ] || OPTS="-s=overlay2"
 exec chpst -o 1048576 -p 1048576 dockerd $OPTS 2>&1

Re: docker: Fix runit service

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/21254#issuecomment-618015010

Comment:
I cannot reproduce.

Re: docker: Fix runit service

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

New comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/21254#issuecomment-618016769

Comment:
I just had this hit 3 different systems after fresh installations - commenting out that one line in the service file was the only way to get dockerd to startup.
Note: overlay2 might be specific to a particular underlying file system (ext4 for instance). I am using ZFS.

Re: docker: Fix runit service

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/21254#issuecomment-618083388

Comment:
closing this as it seems to be a user configuration issue

Re: [PR PATCH] [Closed]: docker: Fix runit service

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

There's a closed pull request on the void-packages repository

docker: Fix runit service
https://github.com/void-linux/void-packages/pull/21254

Description:
The "-s=overlay2" command line flag appears to prevent the service from starting.
Comment out this line in the service file for now.

Re: docker: Fix runit service

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

New comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/21254#issuecomment-618093708

Comment:
While I will not contest this further, I do want to point out the following for anyone else who runs into this later:

This one line in the runit script forcibly overrides both:
   * The filesystem auto-detection mechanisms in `dockerd` itself
   * The user-set configuration of the filesystem driver in /etc/docker/daemon.json

The easiest way to enable multi-filesystem support or to use the XBPS docker package on any non-EXT filesystem is to remove this one line in the /etc/sv/docker/run service file.

Re: docker: Fix runit service

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/21254#issuecomment-619077594

Comment:
or provide the conf file with `OPTS=" "`

Re: docker: Fix runit service

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/21254#issuecomment-619078866

Comment:
5c212702efaeef7d2334952bd7d0d20ac49c96c8
@beanpole135 you can complain here: #19374

Re: docker: Fix runit service

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/21254#issuecomment-619348637

Comment:
@beanpole135 please properly revert the commit instead of commenting the line.

Re: docker: Fix runit service

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/21254#issuecomment-619348637

Comment:
@beanpole135 please properly revert the commit instead of commenting the line.

config issue in fact is present at the author of the commit adding the flag in #19374

Re: docker: Fix runit service

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/21254#issuecomment-619348637

Comment:
@beanpole135 please properly revert the commit instead of commenting the line. (revert + revbump the template)

config issue in fact is present at the author of the commit adding the flag in #19374

Re: docker: Fix runit service

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

New comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/21254#issuecomment-619962784

Comment:
Reverting a previous commit is a task for the port maintainer, as it is a completely different approach than this PR takes (even though the end result is the same).
I do not care if my name appears in commit logs or anything - go ahead and do the revert in a separate PR and just close this one.

Re: [PR PATCH] [Closed]: docker: Fix runit service

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

There's a closed pull request on the void-packages repository

docker: Fix runit service
https://github.com/void-linux/void-packages/pull/21254

Description:
The "-s=overlay2" command line flag appears to prevent the service from starting.
Comment out this line in the service file for now.

Re: docker: Fix runit service

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/21254#issuecomment-623942555

Comment:
because this came up in IRC again, here is my (naive) explanation.

### Explanation
- #19374 was clearly a user configuration issue. The user should have cleaned up like the error message indicates.
- by adding `-s=overlay2` to the service run file this switched (probably quite a few) users that were using a different storage driver before (such as devicemapper, probably old docker installs that defaulted to sth else than overlay2) to overlay2 storage driver
- now by my revert (7e4ec0a6a9ecb96b0f8a8364e19f465f9dca29ee) those users end up with two configured storage drivers (their old one and overlay2). thus docker daemon fail demanding to explicitly set the one to use clean up `/var/lib/docker` (just like the original author of #19374)

### how to fix
if you are affected,
- either clean up `/var/lib/docker` (remove all sotage driver dirs what are oboslete). might require migration of existing containers
- or put `OPTS="-s=STORAGEDRIVER"` (for example devimapper if that was used before) in `/etc/sv/docker/conf`