* Re: Avoid overriding do_install() from build-style
2020-04-25 22:20 [PR PATCH] Avoid overriding do_install() in haskell-stack build-style zhengqunkoo
@ 2020-04-26 1:15 ` sgn
2020-04-26 8:07 ` [PR PATCH] [Updated] " zhengqunkoo
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2020-04-26 1:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/21343#issuecomment-619463300
Comment:
Please bump revision.
I don't do much haskell.
I guess @leahneukirchen know this.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR PATCH] [Updated] Avoid overriding do_install() from build-style
2020-04-25 22:20 [PR PATCH] Avoid overriding do_install() in haskell-stack build-style zhengqunkoo
2020-04-26 1:15 ` Avoid overriding do_install() from build-style sgn
@ 2020-04-26 8:07 ` zhengqunkoo
2020-04-26 8:08 ` zhengqunkoo
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: zhengqunkoo @ 2020-04-26 8:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 412 bytes --]
There is an updated pull request by zhengqunkoo against master on the void-packages repository
https://github.com/zhengqunkoo/void-packages kmonad
https://github.com/void-linux/void-packages/pull/21343
Avoid overriding do_install() from build-style
An overrided `do_install()` means `/usr/bin/kmonad` is not installed.
A patch file from https://github.com/void-linux/void-packages/pull/21343.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kmonad-21343.patch --]
[-- Type: text/x-diff, Size: 958 bytes --]
From d2dde89869806f7b645f2471678a837c219984a0 Mon Sep 17 00:00:00 2001
From: zhengqunkoo <root@zhengqunkoo.com>
Date: Sun, 26 Apr 2020 06:20:09 +0800
Subject: [PATCH] Avoid overriding do_install() in haskell-stack build-style
---
srcpkgs/kmonad/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/kmonad/template b/srcpkgs/kmonad/template
index 88584c00607..bfa208d1ce3 100644
--- a/srcpkgs/kmonad/template
+++ b/srcpkgs/kmonad/template
@@ -1,7 +1,7 @@
# Template file for 'kmonad'
pkgname=kmonad
version=0.3.0
-revision=2
+revision=3
build_style=haskell-stack
stackage=lts-14.07
short_desc="Keyboard remapping utility providing qmk-like functionality"
@@ -13,7 +13,7 @@ checksum="3f61c546d456354a15326558eb8025024ab3d51ef2f6ec761da5568e4473f7ec"
nopie_files="/usr/bin/kmonad"
nocross=yes
-do_install() {
+post_install() {
vlicense LICENSE
vinstall ${FILESDIR}/60-kmonad.rules 644 usr/lib/udev/rules.d
}
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Avoid overriding do_install() from build-style
2020-04-25 22:20 [PR PATCH] Avoid overriding do_install() in haskell-stack build-style zhengqunkoo
2020-04-26 1:15 ` Avoid overriding do_install() from build-style sgn
2020-04-26 8:07 ` [PR PATCH] [Updated] " zhengqunkoo
@ 2020-04-26 8:08 ` zhengqunkoo
2020-04-26 11:15 ` NeelChotai
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: zhengqunkoo @ 2020-04-26 8:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 192 bytes --]
New comment by zhengqunkoo on void-packages repository
https://github.com/void-linux/void-packages/pull/21343#issuecomment-619506292
Comment:
Thanks for catching the revision mistake @sgn .
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Avoid overriding do_install() from build-style
2020-04-25 22:20 [PR PATCH] Avoid overriding do_install() in haskell-stack build-style zhengqunkoo
` (2 preceding siblings ...)
2020-04-26 8:08 ` zhengqunkoo
@ 2020-04-26 11:15 ` NeelChotai
2020-04-26 13:20 ` [PR PATCH] [Updated] " zhengqunkoo
2020-04-27 15:56 ` [PR PATCH] [Merged]: kmonad: avoid overriding do_install() in build-style Hoshpak
5 siblings, 0 replies; 7+ messages in thread
From: NeelChotai @ 2020-04-26 11:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 185 bytes --]
New comment by NeelChotai on void-packages repository
https://github.com/void-linux/void-packages/pull/21343#issuecomment-619531924
Comment:
Try another force push to restart Travis.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR PATCH] [Updated] Avoid overriding do_install() from build-style
2020-04-25 22:20 [PR PATCH] Avoid overriding do_install() in haskell-stack build-style zhengqunkoo
` (3 preceding siblings ...)
2020-04-26 11:15 ` NeelChotai
@ 2020-04-26 13:20 ` zhengqunkoo
2020-04-27 15:56 ` [PR PATCH] [Merged]: kmonad: avoid overriding do_install() in build-style Hoshpak
5 siblings, 0 replies; 7+ messages in thread
From: zhengqunkoo @ 2020-04-26 13:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 412 bytes --]
There is an updated pull request by zhengqunkoo against master on the void-packages repository
https://github.com/zhengqunkoo/void-packages kmonad
https://github.com/void-linux/void-packages/pull/21343
Avoid overriding do_install() from build-style
An overrided `do_install()` means `/usr/bin/kmonad` is not installed.
A patch file from https://github.com/void-linux/void-packages/pull/21343.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kmonad-21343.patch --]
[-- Type: text/x-diff, Size: 1018 bytes --]
From 81e8b5dbe95ec170d030c371caaa3fcd94f3400b Mon Sep 17 00:00:00 2001
From: zhengqunkoo <root@zhengqunkoo.com>
Date: Sun, 26 Apr 2020 06:20:09 +0800
Subject: [PATCH] kmonad: avoid overriding do_install() in build-style
An overrided do_install() means /usr/bin/kmonad
is not installed.
---
srcpkgs/kmonad/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/kmonad/template b/srcpkgs/kmonad/template
index 88584c00607..bfa208d1ce3 100644
--- a/srcpkgs/kmonad/template
+++ b/srcpkgs/kmonad/template
@@ -1,7 +1,7 @@
# Template file for 'kmonad'
pkgname=kmonad
version=0.3.0
-revision=2
+revision=3
build_style=haskell-stack
stackage=lts-14.07
short_desc="Keyboard remapping utility providing qmk-like functionality"
@@ -13,7 +13,7 @@ checksum="3f61c546d456354a15326558eb8025024ab3d51ef2f6ec761da5568e4473f7ec"
nopie_files="/usr/bin/kmonad"
nocross=yes
-do_install() {
+post_install() {
vlicense LICENSE
vinstall ${FILESDIR}/60-kmonad.rules 644 usr/lib/udev/rules.d
}
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR PATCH] [Merged]: kmonad: avoid overriding do_install() in build-style
2020-04-25 22:20 [PR PATCH] Avoid overriding do_install() in haskell-stack build-style zhengqunkoo
` (4 preceding siblings ...)
2020-04-26 13:20 ` [PR PATCH] [Updated] " zhengqunkoo
@ 2020-04-27 15:56 ` Hoshpak
5 siblings, 0 replies; 7+ messages in thread
From: Hoshpak @ 2020-04-27 15:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
There's a merged pull request on the void-packages repository
kmonad: avoid overriding do_install() in build-style
https://github.com/void-linux/void-packages/pull/21343
Description:
An overrided `do_install()` means `/usr/bin/kmonad` is not installed.
^ permalink raw reply [flat|nested] 7+ messages in thread