[PR PATCH] NetworkManager: add rules for policykit

[PR PATCH] NetworkManager: add rules for policykit

[Gottox]

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

There is a new pull request by Gottox against master on the void-packages repository

https://github.com/Gottox/void-packages issue-21578
https://github.com/void-linux/void-packages/pull/21608

NetworkManager: add rules for policykit
allows members of the group 'network' to access NetworkManager. Fixes https://github.com/void-linux/void-packages/issues/21578

A patch file from https://github.com/void-linux/void-packages/pull/21608.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-issue-21578-21608.patch --]
[-- Type: text/x-diff, Size: 1701 bytes --]

From 0249a6980a9af2724aa06a530570bc2d2529262e Mon Sep 17 00:00:00 2001
From: Enno Boland <gottox@voidlinux.org>
Date: Mon, 4 May 2020 15:55:54 +0200
Subject: [PATCH] NetworkManager: add rules for policykit

allows members of the group 'network' to access NetworkManager.
---
 .../files/50-org.freedesktop.NetworkManager.rules            | 5 +++++
 srcpkgs/NetworkManager/template                              | 4 +++-
 2 files changed, 8 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/NetworkManager/files/50-org.freedesktop.NetworkManager.rules

diff --git a/srcpkgs/NetworkManager/files/50-org.freedesktop.NetworkManager.rules b/srcpkgs/NetworkManager/files/50-org.freedesktop.NetworkManager.rules
new file mode 100644
index 00000000000..8c933b7e8a4
--- /dev/null
+++ b/srcpkgs/NetworkManager/files/50-org.freedesktop.NetworkManager.rules
@@ -0,0 +1,5 @@
+polkit.addRule(function(action, subject) {
+	if (action.id.indexOf("org.freedesktop.NetworkManager.") == 0 && subject.isInGroup("network")) {
+		return polkit.Result.YES;
+	}
+});
diff --git a/srcpkgs/NetworkManager/template b/srcpkgs/NetworkManager/template
index 71ccbe8bcdc..edeb8278579 100644
--- a/srcpkgs/NetworkManager/template
+++ b/srcpkgs/NetworkManager/template
@@ -1,7 +1,7 @@
 # Template file for 'NetworkManager'
 pkgname=NetworkManager
 version=1.22.10
-revision=1
+revision=2
 build_style=meson
 build_helper="gir qemu"
 configure_args="-Dpolkit_agent=true -Dsystemd_journal=false
@@ -68,6 +68,8 @@ pre_configure() {
 
 post_install() {
 	vinstall ${FILESDIR}/${pkgname}.conf 644 etc/${pkgname}
+	vinstall ${FILESDIR}/50-org.freedesktop.NetworkManager.rules 644 \
+		/usr/share/polkit-1/rules.d
 	vsv ${pkgname}
 }
 

Re: NetworkManager: add rules for policykit

[Gottox]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New comment by Gottox on void-packages repository

https://github.com/void-linux/void-packages/pull/21608#issuecomment-623480588

Comment:
cc @flexibeast @kotoko

Re: NetworkManager: add rules for policykit

[flexibeast]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New comment by flexibeast on void-packages repository

https://github.com/void-linux/void-packages/pull/21608#issuecomment-623897945

Comment:
@Gottox: Thanks! Once this is merged, i'll close both https://github.com/void-linux/void-packages/issues/21578 and https://github.com/void-linux/void-docs/issues/135.

Re: [PR PATCH] [Merged]: NetworkManager: add rules for policykit

[Gottox]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

There's a merged pull request on the void-packages repository

NetworkManager: add rules for policykit
https://github.com/void-linux/void-packages/pull/21608

Description:
allows members of the group 'network' to access NetworkManager. Fixes https://github.com/void-linux/void-packages/issues/21578