* Re: Package request: grub-btrfs
2020-05-03 9:10 [ISSUE] Package request: grub-btrfs notramo
@ 2020-05-04 2:32 ` Morgareth99
2020-05-10 2:39 ` ericonr
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Morgareth99 @ 2020-05-04 2:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
New comment by Morgareth99 on void-packages repository
https://github.com/void-linux/void-packages/issues/21581#issuecomment-623231411
Comment:
# Template file for 'grub-btrfs'
pkgname=grub-btrfs
version=4.3
revision=1
archs="x86_64"
build_style=gnu-makefile
depends="btrfs-progs grub"
short_desc="Include btrfs snapshots in GRUB boot options"
maintainer="Morgareth <morgareth@tutanota.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/Antynea/grub-btrfs"
distfiles="https://github.com/Antynea/grub-btrfs/archive/${version}.tar.gz"
checksum=6692008326136371bb48fd2a4da0f44e8395413a999862007db6db77543c1f77
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Package request: grub-btrfs
2020-05-03 9:10 [ISSUE] Package request: grub-btrfs notramo
2020-05-04 2:32 ` Morgareth99
@ 2020-05-10 2:39 ` ericonr
2020-05-24 8:00 ` anjandev
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-05-10 2:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/issues/21581#issuecomment-626263861
Comment:
Wouldn't it be better to make a PR for it as well? That way you can put the template through CI as well.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Package request: grub-btrfs
2020-05-03 9:10 [ISSUE] Package request: grub-btrfs notramo
2020-05-04 2:32 ` Morgareth99
2020-05-10 2:39 ` ericonr
@ 2020-05-24 8:00 ` anjandev
2020-05-26 0:28 ` [ISSUE] [CLOSED] " sgn
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: anjandev @ 2020-05-24 8:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 375 bytes --]
New comment by anjandev on void-packages repository
https://github.com/void-linux/void-packages/issues/21581#issuecomment-633194796
Comment:
I was trying out this package on my void system and wrote a package for it two months ago. I wasnt going to submit but I saw this request. It seems that the other post hasnt submitted a PR so I sent my patch with a PR. Best wishes!
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [ISSUE] [CLOSED] Package request: grub-btrfs
2020-05-03 9:10 [ISSUE] Package request: grub-btrfs notramo
` (2 preceding siblings ...)
2020-05-24 8:00 ` anjandev
@ 2020-05-26 0:28 ` sgn
2020-05-27 21:58 ` Morgareth99
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: sgn @ 2020-05-26 0:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
Closed issue by notramo on void-packages repository
https://github.com/void-linux/void-packages/issues/21581
Description:
Include BTRFS snapshots at boot options in GRUB menu.
https://github.com/Antynea/grub-btrfs
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Package request: grub-btrfs
2020-05-03 9:10 [ISSUE] Package request: grub-btrfs notramo
` (3 preceding siblings ...)
2020-05-26 0:28 ` [ISSUE] [CLOSED] " sgn
@ 2020-05-27 21:58 ` Morgareth99
2020-05-27 22:05 ` Morgareth99
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Morgareth99 @ 2020-05-27 21:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
New comment by Morgareth99 on void-packages repository
https://github.com/void-linux/void-packages/issues/21581#issuecomment-634964949
Comment:
> I was trying out this package on my void system and wrote a package for it two months ago. I wasnt going to submit but I saw this request. It seems that the other post hasnt submitted a PR so I sent my patch with a PR. Best wishes!
# Template file for 'grub-btrfs'
pkgname=grub-btrfs
version=4.3
revision=1
build_style=gnu-makefile
depends="btrfs-progs grub"
short_desc="Include btrfs snapshots in GRUB boot options"
maintainer="Morgareth <morgareth@tutanota.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/Antynea/grub-btrfs"
distfiles="https://github.com/Antynea/grub-btrfs/archive/${version}.tar.gz"
checksum=6692008326136371bb48fd2a4da0f44e8395413a999862007db6db77543c1f77
post_install() {
vinstall ${FILESDIR}/41_snapshots-btrfs 755 /etc/grub.d/41_snapshots-btrfs
}
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Package request: grub-btrfs
2020-05-03 9:10 [ISSUE] Package request: grub-btrfs notramo
` (4 preceding siblings ...)
2020-05-27 21:58 ` Morgareth99
@ 2020-05-27 22:05 ` Morgareth99
2020-05-27 22:09 ` Morgareth99
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Morgareth99 @ 2020-05-27 22:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 972 bytes --]
New comment by Morgareth99 on void-packages repository
https://github.com/void-linux/void-packages/issues/21581#issuecomment-634964949
Comment:
> I was trying out this package on my void system and wrote a package for it two months ago. I wasnt going to submit but I saw this request. It seems that the other post hasnt submitted a PR so I sent my patch with a PR. Best wishes!
# Template file for 'grub-btrfs'
pkgname=grub-btrfs
version=4.3
archs=noarch
revision=1
build_style=gnu-makefile
depends="btrfs-progs grub"
short_desc="Include btrfs snapshots in GRUB boot options"
maintainer="Morgareth <morgareth@tutanota.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/Antynea/grub-btrfs"
distfiles="https://github.com/Antynea/grub-btrfs/archive/${version}.tar.gz"
checksum=6692008326136371bb48fd2a4da0f44e8395413a999862007db6db77543c1f77
post_install() {
vinstall ${FILESDIR}/41_snapshots-btrfs 755 /etc/grub.d/41_snapshots-btrfs
}
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Package request: grub-btrfs
2020-05-03 9:10 [ISSUE] Package request: grub-btrfs notramo
` (5 preceding siblings ...)
2020-05-27 22:05 ` Morgareth99
@ 2020-05-27 22:09 ` Morgareth99
2020-05-28 6:32 ` anjandev
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Morgareth99 @ 2020-05-27 22:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
New comment by Morgareth99 on void-packages repository
https://github.com/void-linux/void-packages/issues/21581#issuecomment-623231411
Comment:
# Template file for 'grub-btrfs'
pkgname=grub-btrfs
version=4.3
revision=1
archs=noarch
build_style=gnu-makefile
depends="btrfs-progs grub"
short_desc="Include btrfs snapshots in GRUB boot options"
maintainer="Morgareth <morgareth@tutanota.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/Antynea/grub-btrfs"
distfiles="https://github.com/Antynea/grub-btrfs/archive/${version}.tar.gz"
checksum=6692008326136371bb48fd2a4da0f44e8395413a999862007db6db77543c1f77
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Package request: grub-btrfs
2020-05-03 9:10 [ISSUE] Package request: grub-btrfs notramo
` (6 preceding siblings ...)
2020-05-27 22:09 ` Morgareth99
@ 2020-05-28 6:32 ` anjandev
2020-05-28 12:46 ` sgn
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: anjandev @ 2020-05-28 6:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
New comment by anjandev on void-packages repository
https://github.com/void-linux/void-packages/issues/21581#issuecomment-635135716
Comment:
Do you want to maintain this package instead of me? If so, I have no
problem. Please send a pull request with your patch overwriting my
grub-btrfs package.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Package request: grub-btrfs
2020-05-03 9:10 [ISSUE] Package request: grub-btrfs notramo
` (7 preceding siblings ...)
2020-05-28 6:32 ` anjandev
@ 2020-05-28 12:46 ` sgn
2020-05-28 13:41 ` Morgareth99
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: sgn @ 2020-05-28 12:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/issues/21581#issuecomment-635327844
Comment:
Hi Anjan,
On 2020-05-27 23:32:37-0700, Anjan Momi <notifications@github.com> wrote:
>
> Do you want to maintain this package instead of me? If so, I have no
> problem. Please send a pull request with your patch overwriting my
> grub-btrfs package.
Your template installed `/etc/grub.d/41_snapshots-btrfs`
I don't know why we need to install it in post_install.
Minor problem that I've just recognized:
- /etc/default/grub-btrfs/config should be conf_files
- /usr/lib/systemd/system shouldn't exist
- depends+="btrfs-progs"
I would be happy to have you check it and confirm it's correct.
I'm fine with write the change myself if you can confirm my understand
is correct.
If you create PR for them, I'll merge it.
--
Danh
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Package request: grub-btrfs
2020-05-03 9:10 [ISSUE] Package request: grub-btrfs notramo
` (8 preceding siblings ...)
2020-05-28 12:46 ` sgn
@ 2020-05-28 13:41 ` Morgareth99
2020-05-28 13:41 ` Morgareth99
2020-05-30 9:53 ` anjandev
11 siblings, 0 replies; 13+ messages in thread
From: Morgareth99 @ 2020-05-28 13:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
New comment by Morgareth99 on void-packages repository
https://github.com/void-linux/void-packages/issues/21581#issuecomment-623231411
Comment:
# Template file for 'grub-btrfs'
pkgname=grub-btrfs
version=4.3
revision=1
archs=noarch
build_style=gnu-makefile
depends="btrfs-progs grub"
short_desc="Include btrfs snapshots in GRUB boot options"
maintainer="Morgareth <morgareth@tutanota.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/Antynea/grub-btrfs"
distfiles="https://github.com/Antynea/grub-btrfs/archive/${version}.tar.gz"
checksum=6692008326136371bb48fd2a4da0f44e8395413a999862007db6db77543c1f77
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Package request: grub-btrfs
2020-05-03 9:10 [ISSUE] Package request: grub-btrfs notramo
` (9 preceding siblings ...)
2020-05-28 13:41 ` Morgareth99
@ 2020-05-28 13:41 ` Morgareth99
2020-05-30 9:53 ` anjandev
11 siblings, 0 replies; 13+ messages in thread
From: Morgareth99 @ 2020-05-28 13:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 972 bytes --]
New comment by Morgareth99 on void-packages repository
https://github.com/void-linux/void-packages/issues/21581#issuecomment-634964949
Comment:
> I was trying out this package on my void system and wrote a package for it two months ago. I wasnt going to submit but I saw this request. It seems that the other post hasnt submitted a PR so I sent my patch with a PR. Best wishes!
# Template file for 'grub-btrfs'
pkgname=grub-btrfs
version=4.3
archs=noarch
revision=1
build_style=gnu-makefile
depends="btrfs-progs grub"
short_desc="Include btrfs snapshots in GRUB boot options"
maintainer="Morgareth <morgareth@tutanota.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/Antynea/grub-btrfs"
distfiles="https://github.com/Antynea/grub-btrfs/archive/${version}.tar.gz"
checksum=6692008326136371bb48fd2a4da0f44e8395413a999862007db6db77543c1f77
post_install() {
vinstall ${FILESDIR}/41_snapshots-btrfs 755 /etc/grub.d/41_snapshots-btrfs
}
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: Package request: grub-btrfs
2020-05-03 9:10 [ISSUE] Package request: grub-btrfs notramo
` (10 preceding siblings ...)
2020-05-28 13:41 ` Morgareth99
@ 2020-05-30 9:53 ` anjandev
11 siblings, 0 replies; 13+ messages in thread
From: anjandev @ 2020-05-30 9:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
New comment by anjandev on void-packages repository
https://github.com/void-linux/void-packages/issues/21581#issuecomment-636307607
Comment:
All those changes sound reasonable. Please change the package as
required. =)
Thanks for checking over my work.
^ permalink raw reply [flat|nested] 13+ messages in thread