* Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
@ 2020-07-06 23:48 ` sgn
2020-07-06 23:48 ` sgn
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2020-07-06 23:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 414 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#discussion_r450535872
Comment:
`depends="bash sudo"`
---
Below are not comment on template, but the code itself
- `bash`: It looks like they're using non-required bashism. With a quick skim over the code, the code could be rewritten in POSIX sh.
- `sudo`: I prefer `runuser` or `chpst` instead.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
2020-07-06 23:48 ` [PR REVIEW] New package: zzz-user-hooks-1.0.0 sgn
@ 2020-07-06 23:48 ` sgn
2020-07-06 23:48 ` sgn
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2020-07-06 23:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 165 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#discussion_r450534191
Comment:
Do not indent here. :)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
2020-07-06 23:48 ` [PR REVIEW] New package: zzz-user-hooks-1.0.0 sgn
2020-07-06 23:48 ` sgn
@ 2020-07-06 23:48 ` sgn
2020-07-07 0:00 ` anjandev
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2020-07-06 23:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#discussion_r450534379
Comment:
Use `vinstall` instead. And merge `post_install` into `do_install`
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
` (2 preceding siblings ...)
2020-07-06 23:48 ` sgn
@ 2020-07-07 0:00 ` anjandev
2020-07-07 0:00 ` anjandev
2020-07-11 20:23 ` ahesford
5 siblings, 0 replies; 6+ messages in thread
From: anjandev @ 2020-07-07 0:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
New review comment by anjandev on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#discussion_r450539266
Comment:
I agree with the bashisms but it seems the maintainer likes bashisms according to his blog.
I have opened an issue asking to change to runuser or chpst (https://github.com/bahamas10/zzz-user-hooks/issues/5).
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
` (3 preceding siblings ...)
2020-07-07 0:00 ` anjandev
@ 2020-07-07 0:00 ` anjandev
2020-07-11 20:23 ` ahesford
5 siblings, 0 replies; 6+ messages in thread
From: anjandev @ 2020-07-07 0:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 376 bytes --]
New review comment by anjandev on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#discussion_r450539266
Comment:
I agree with the comment about bashisms but it seems the maintainer likes bashisms according to his blog.
I have opened an issue asking to change to runuser or chpst (https://github.com/bahamas10/zzz-user-hooks/issues/5).
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
` (4 preceding siblings ...)
2020-07-07 0:00 ` anjandev
@ 2020-07-11 20:23 ` ahesford
5 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2020-07-11 20:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 218 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#discussion_r453230484
Comment:
This can be bumpbed to 1.1.0 and the `sudo` dependency removed, right?
^ permalink raw reply [flat|nested] 6+ messages in thread