* Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
@ 2020-07-06 23:48 ` sgn
2020-07-06 23:48 ` sgn
` (12 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: sgn @ 2020-07-06 23:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#discussion_r450534379
Comment:
Use `vinstall` instead. And merge `post_install` into `do_install`
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
2020-07-06 23:48 ` [PR REVIEW] New package: zzz-user-hooks-1.0.0 sgn
@ 2020-07-06 23:48 ` sgn
2020-07-06 23:48 ` sgn
` (11 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: sgn @ 2020-07-06 23:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 414 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#discussion_r450535872
Comment:
`depends="bash sudo"`
---
Below are not comment on template, but the code itself
- `bash`: It looks like they're using non-required bashism. With a quick skim over the code, the code could be rewritten in POSIX sh.
- `sudo`: I prefer `runuser` or `chpst` instead.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
2020-07-06 23:48 ` [PR REVIEW] New package: zzz-user-hooks-1.0.0 sgn
2020-07-06 23:48 ` sgn
@ 2020-07-06 23:48 ` sgn
2020-07-06 23:58 ` [PR PATCH] [Updated] " anjandev
` (10 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: sgn @ 2020-07-06 23:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 165 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#discussion_r450534191
Comment:
Do not indent here. :)
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PR PATCH] [Updated] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
` (2 preceding siblings ...)
2020-07-06 23:48 ` sgn
@ 2020-07-06 23:58 ` anjandev
2020-07-07 0:00 ` [PR REVIEW] " anjandev
` (9 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: anjandev @ 2020-07-06 23:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
There is an updated pull request by anjandev against master on the void-packages repository
https://github.com/anjandev/void-packages zzz
https://github.com/void-linux/void-packages/pull/23430
New package: zzz-user-hooks-1.0.0
A patch file from https://github.com/void-linux/void-packages/pull/23430.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zzz-23430.patch --]
[-- Type: text/x-diff, Size: 1346 bytes --]
From de08a4c4c64e33d24014d0ed15ecb7ebd98897c2 Mon Sep 17 00:00:00 2001
From: Anjandev Momi <anjan@momi.ca>
Date: Mon, 6 Jul 2020 14:52:38 -0700
Subject: [PATCH] New package: zzz-user-hooks-1.0.0
---
srcpkgs/zzz-user-hooks/template | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
create mode 100644 srcpkgs/zzz-user-hooks/template
diff --git a/srcpkgs/zzz-user-hooks/template b/srcpkgs/zzz-user-hooks/template
new file mode 100644
index 00000000000..1915aee8012
--- /dev/null
+++ b/srcpkgs/zzz-user-hooks/template
@@ -0,0 +1,22 @@
+# Template file for 'zzz-user-hooks'
+pkgname=zzz-user-hooks
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+checkdepends="shellcheck"
+short_desc="Allow user scripts for logged in user using zzz suspend/resume"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="MIT"
+homepage="https://www.daveeddy.com/2018/10/01/run-user-scripts-on-suspend-and-wakeup-on-void-linux/"
+distfiles="https://github.com/bahamas10/zzz-user-hooks/archive/v${version}.tar.gz"
+checksum=bf29baf9a5690dafbede199f0a9d841759de828cd0967c3fe376e1155ab5c8fc
+archs=noarch
+
+do_install() {
+ vmkdir /etc/zzz.d/resume
+ vmkdir /etc/zzz.d/suspend
+ vinstall user-script /etc/zzz.d
+ vinstall hooks/resume/99-user-script /etc/zzz.d/resume
+ vinstall hooks/suspend/99-user-script /etc/zzz.d/suspend
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
` (3 preceding siblings ...)
2020-07-06 23:58 ` [PR PATCH] [Updated] " anjandev
@ 2020-07-07 0:00 ` anjandev
2020-07-07 0:00 ` anjandev
` (8 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: anjandev @ 2020-07-07 0:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
New review comment by anjandev on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#discussion_r450539266
Comment:
I agree with the bashisms but it seems the maintainer likes bashisms according to his blog.
I have opened an issue asking to change to runuser or chpst (https://github.com/bahamas10/zzz-user-hooks/issues/5).
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
` (4 preceding siblings ...)
2020-07-07 0:00 ` [PR REVIEW] " anjandev
@ 2020-07-07 0:00 ` anjandev
2020-07-07 0:01 ` [PR PATCH] [Updated] " anjandev
` (7 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: anjandev @ 2020-07-07 0:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 376 bytes --]
New review comment by anjandev on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#discussion_r450539266
Comment:
I agree with the comment about bashisms but it seems the maintainer likes bashisms according to his blog.
I have opened an issue asking to change to runuser or chpst (https://github.com/bahamas10/zzz-user-hooks/issues/5).
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PR PATCH] [Updated] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
` (5 preceding siblings ...)
2020-07-07 0:00 ` anjandev
@ 2020-07-07 0:01 ` anjandev
2020-07-11 20:23 ` [PR REVIEW] " ahesford
` (6 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: anjandev @ 2020-07-07 0:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
There is an updated pull request by anjandev against master on the void-packages repository
https://github.com/anjandev/void-packages zzz
https://github.com/void-linux/void-packages/pull/23430
New package: zzz-user-hooks-1.0.0
A patch file from https://github.com/void-linux/void-packages/pull/23430.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zzz-23430.patch --]
[-- Type: text/x-diff, Size: 1368 bytes --]
From f03dfb2d87095234238241393699f6aaa1f39f8a Mon Sep 17 00:00:00 2001
From: Anjandev Momi <anjan@momi.ca>
Date: Mon, 6 Jul 2020 14:52:38 -0700
Subject: [PATCH] New package: zzz-user-hooks-1.0.0
---
srcpkgs/zzz-user-hooks/template | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
create mode 100644 srcpkgs/zzz-user-hooks/template
diff --git a/srcpkgs/zzz-user-hooks/template b/srcpkgs/zzz-user-hooks/template
new file mode 100644
index 00000000000..089948d47a3
--- /dev/null
+++ b/srcpkgs/zzz-user-hooks/template
@@ -0,0 +1,23 @@
+# Template file for 'zzz-user-hooks'
+pkgname=zzz-user-hooks
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+depends="bash sudo"
+checkdepends="shellcheck"
+short_desc="Allow user scripts for logged in user using zzz suspend/resume"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="MIT"
+homepage="https://www.daveeddy.com/2018/10/01/run-user-scripts-on-suspend-and-wakeup-on-void-linux/"
+distfiles="https://github.com/bahamas10/zzz-user-hooks/archive/v${version}.tar.gz"
+checksum=bf29baf9a5690dafbede199f0a9d841759de828cd0967c3fe376e1155ab5c8fc
+archs=noarch
+
+do_install() {
+ vmkdir /etc/zzz.d/resume
+ vmkdir /etc/zzz.d/suspend
+ vinstall user-script /etc/zzz.d
+ vinstall hooks/resume/99-user-script /etc/zzz.d/resume
+ vinstall hooks/suspend/99-user-script /etc/zzz.d/suspend
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
` (6 preceding siblings ...)
2020-07-07 0:01 ` [PR PATCH] [Updated] " anjandev
@ 2020-07-11 20:23 ` ahesford
2020-07-11 21:54 ` [PR PATCH] [Updated] " anjandev
` (5 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: ahesford @ 2020-07-11 20:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 218 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#discussion_r453230484
Comment:
This can be bumpbed to 1.1.0 and the `sudo` dependency removed, right?
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PR PATCH] [Updated] New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
` (7 preceding siblings ...)
2020-07-11 20:23 ` [PR REVIEW] " ahesford
@ 2020-07-11 21:54 ` anjandev
2020-07-11 21:58 ` anjandev
` (4 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: anjandev @ 2020-07-11 21:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
There is an updated pull request by anjandev against master on the void-packages repository
https://github.com/anjandev/void-packages zzz
https://github.com/void-linux/void-packages/pull/23430
New package: zzz-user-hooks-1.0.0
A patch file from https://github.com/void-linux/void-packages/pull/23430.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zzz-23430.patch --]
[-- Type: text/x-diff, Size: 1375 bytes --]
From ca02735d15ebf1ed20a4129cac8d871534f19bee Mon Sep 17 00:00:00 2001
From: Anjandev Momi <anjan@momi.ca>
Date: Mon, 6 Jul 2020 14:52:38 -0700
Subject: [PATCH] New package: zzz-user-hooks-1.1.0
---
srcpkgs/zzz-user-hooks/template | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
create mode 100644 srcpkgs/zzz-user-hooks/template
diff --git a/srcpkgs/zzz-user-hooks/template b/srcpkgs/zzz-user-hooks/template
new file mode 100644
index 00000000000..7301509092f
--- /dev/null
+++ b/srcpkgs/zzz-user-hooks/template
@@ -0,0 +1,23 @@
+# Template file for 'zzz-user-hooks'
+pkgname=zzz-user-hooks
+version=1.1.0
+revision=1
+archs=noarch
+build_style=gnu-makefile
+depends="bash"
+checkdepends="shellcheck"
+short_desc="Allow user scripts for logged in user using zzz suspend/resume"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="MIT"
+homepage="https://www.daveeddy.com/2018/10/01/run-user-scripts-on-suspend-and-wakeup-on-void-linux/"
+distfiles="https://github.com/bahamas10/zzz-user-hooks/archive/v${version}.tar.gz"
+checksum=83fb98153b1906c85946efb18eaad52a95a297a36528f975ba006e650e8459bd
+
+do_install() {
+ vmkdir /etc/zzz.d/resume
+ vmkdir /etc/zzz.d/suspend
+ vinstall user-script 755 /etc/zzz.d
+ vinstall hooks/resume/99-user-script 755 /etc/zzz.d/resume
+ vinstall hooks/suspend/99-user-script 755 /etc/zzz.d/suspend
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
` (8 preceding siblings ...)
2020-07-11 21:54 ` [PR PATCH] [Updated] " anjandev
@ 2020-07-11 21:58 ` anjandev
2020-07-12 3:29 ` ahesford
` (3 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: anjandev @ 2020-07-11 21:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
New comment by anjandev on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#issuecomment-657136521
Comment:
Hey,
Andrew J. Hesford <notifications@github.com> writes:
> This can be bumpbed to 1.1.0 and the `sudo` dependency removed, right?
Sorry I have been busy. I updated to 1.1.0 and removed sudo as a
dependency. Please merge this if you think it's ready.
> The X11 and Wayland detection in the upstream project is a little hacky, but that mean it isn't useful or suitable for packaging.
What would be the ideal way to detect X11 or Wayland? I can notify the
maintainer of the better way.
Thanks,
Anjandev Momi
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
` (9 preceding siblings ...)
2020-07-11 21:58 ` anjandev
@ 2020-07-12 3:29 ` ahesford
2020-07-23 14:10 ` sgn
` (2 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: ahesford @ 2020-07-12 3:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 453 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#issuecomment-657169391
Comment:
I'm not sure of the best way to detect Wayland or X11. In my own use of `zzz` hooks, I avoid the issue altogether by creating triggers like `/run/zzz/will-sleep` and touch the trigger file on suspend. Any X11 or Wayland program that needs to run can just watch the trigger with inotify and act when appropriate.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
` (10 preceding siblings ...)
2020-07-12 3:29 ` ahesford
@ 2020-07-23 14:10 ` sgn
2020-07-23 14:33 ` ahesford
2020-07-23 14:34 ` [PR PATCH] [Merged]: " sgn
13 siblings, 0 replies; 14+ messages in thread
From: sgn @ 2020-07-23 14:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 181 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#issuecomment-663029666
Comment:
I guess no more complaints for this package?
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
` (11 preceding siblings ...)
2020-07-23 14:10 ` sgn
@ 2020-07-23 14:33 ` ahesford
2020-07-23 14:34 ` [PR PATCH] [Merged]: " sgn
13 siblings, 0 replies; 14+ messages in thread
From: ahesford @ 2020-07-23 14:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 154 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/23430#issuecomment-663041909
Comment:
None from me
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PR PATCH] [Merged]: New package: zzz-user-hooks-1.0.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23430@inbox.vuxu.org>
` (12 preceding siblings ...)
2020-07-23 14:33 ` ahesford
@ 2020-07-23 14:34 ` sgn
13 siblings, 0 replies; 14+ messages in thread
From: sgn @ 2020-07-23 14:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 167 bytes --]
There's a merged pull request on the void-packages repository
New package: zzz-user-hooks-1.0.0
https://github.com/void-linux/void-packages/pull/23430
Description:
^ permalink raw reply [flat|nested] 14+ messages in thread