Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0

Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0

[sgn]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23430#discussion_r450535872

Comment:
`depends="bash sudo"`

---
Below are not comment on template, but the code itself

- `bash`: It looks like they're using non-required bashism. With a quick skim over the code, the code could be rewritten in POSIX sh.
- `sudo`: I prefer `runuser` or `chpst` instead.

Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0

[sgn]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23430#discussion_r450534191

Comment:
Do not indent here. :)

Re: [PR PATCH] [Updated] New package: zzz-user-hooks-1.0.0

[anjandev]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

There is an updated pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages zzz
https://github.com/void-linux/void-packages/pull/23430

New package: zzz-user-hooks-1.0.0


A patch file from https://github.com/void-linux/void-packages/pull/23430.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zzz-23430.patch --]
[-- Type: text/x-diff, Size: 1346 bytes --]

From de08a4c4c64e33d24014d0ed15ecb7ebd98897c2 Mon Sep 17 00:00:00 2001
From: Anjandev Momi <anjan@momi.ca>
Date: Mon, 6 Jul 2020 14:52:38 -0700
Subject: [PATCH] New package: zzz-user-hooks-1.0.0

---
 srcpkgs/zzz-user-hooks/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/zzz-user-hooks/template

diff --git a/srcpkgs/zzz-user-hooks/template b/srcpkgs/zzz-user-hooks/template
new file mode 100644
index 00000000000..1915aee8012
--- /dev/null
+++ b/srcpkgs/zzz-user-hooks/template
@@ -0,0 +1,22 @@
+# Template file for 'zzz-user-hooks'
+pkgname=zzz-user-hooks
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+checkdepends="shellcheck"
+short_desc="Allow user scripts for logged in user using zzz suspend/resume"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="MIT"
+homepage="https://www.daveeddy.com/2018/10/01/run-user-scripts-on-suspend-and-wakeup-on-void-linux/"
+distfiles="https://github.com/bahamas10/zzz-user-hooks/archive/v${version}.tar.gz"
+checksum=bf29baf9a5690dafbede199f0a9d841759de828cd0967c3fe376e1155ab5c8fc
+archs=noarch
+
+do_install() {
+	vmkdir /etc/zzz.d/resume
+	vmkdir /etc/zzz.d/suspend
+	vinstall user-script /etc/zzz.d
+	vinstall hooks/resume/99-user-script /etc/zzz.d/resume
+	vinstall hooks/suspend/99-user-script /etc/zzz.d/suspend
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0

[anjandev]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

New review comment by anjandev on void-packages repository

https://github.com/void-linux/void-packages/pull/23430#discussion_r450539266

Comment:
I agree with the bashisms but it seems the maintainer likes bashisms according to his blog.

I have opened an issue asking to change to runuser or chpst (https://github.com/bahamas10/zzz-user-hooks/issues/5).

Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0

[anjandev]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

New review comment by anjandev on void-packages repository

https://github.com/void-linux/void-packages/pull/23430#discussion_r450539266

Comment:
I agree with the comment about bashisms but it seems the maintainer likes bashisms according to his blog.

I have opened an issue asking to change to runuser or chpst (https://github.com/bahamas10/zzz-user-hooks/issues/5).

Re: [PR PATCH] [Updated] New package: zzz-user-hooks-1.0.0

[anjandev]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

There is an updated pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages zzz
https://github.com/void-linux/void-packages/pull/23430

New package: zzz-user-hooks-1.0.0


A patch file from https://github.com/void-linux/void-packages/pull/23430.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zzz-23430.patch --]
[-- Type: text/x-diff, Size: 1368 bytes --]

From f03dfb2d87095234238241393699f6aaa1f39f8a Mon Sep 17 00:00:00 2001
From: Anjandev Momi <anjan@momi.ca>
Date: Mon, 6 Jul 2020 14:52:38 -0700
Subject: [PATCH] New package: zzz-user-hooks-1.0.0

---
 srcpkgs/zzz-user-hooks/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/zzz-user-hooks/template

diff --git a/srcpkgs/zzz-user-hooks/template b/srcpkgs/zzz-user-hooks/template
new file mode 100644
index 00000000000..089948d47a3
--- /dev/null
+++ b/srcpkgs/zzz-user-hooks/template
@@ -0,0 +1,23 @@
+# Template file for 'zzz-user-hooks'
+pkgname=zzz-user-hooks
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+depends="bash sudo"
+checkdepends="shellcheck"
+short_desc="Allow user scripts for logged in user using zzz suspend/resume"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="MIT"
+homepage="https://www.daveeddy.com/2018/10/01/run-user-scripts-on-suspend-and-wakeup-on-void-linux/"
+distfiles="https://github.com/bahamas10/zzz-user-hooks/archive/v${version}.tar.gz"
+checksum=bf29baf9a5690dafbede199f0a9d841759de828cd0967c3fe376e1155ab5c8fc
+archs=noarch
+
+do_install() {
+	vmkdir /etc/zzz.d/resume
+	vmkdir /etc/zzz.d/suspend
+	vinstall user-script /etc/zzz.d
+	vinstall hooks/resume/99-user-script /etc/zzz.d/resume
+	vinstall hooks/suspend/99-user-script /etc/zzz.d/suspend
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: zzz-user-hooks-1.0.0

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/23430#discussion_r453230484

Comment:
This can be bumpbed to 1.1.0 and the `sudo` dependency removed, right?

Re: [PR PATCH] [Updated] New package: zzz-user-hooks-1.0.0

[anjandev]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

There is an updated pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages zzz
https://github.com/void-linux/void-packages/pull/23430

New package: zzz-user-hooks-1.0.0


A patch file from https://github.com/void-linux/void-packages/pull/23430.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zzz-23430.patch --]
[-- Type: text/x-diff, Size: 1375 bytes --]

From ca02735d15ebf1ed20a4129cac8d871534f19bee Mon Sep 17 00:00:00 2001
From: Anjandev Momi <anjan@momi.ca>
Date: Mon, 6 Jul 2020 14:52:38 -0700
Subject: [PATCH] New package: zzz-user-hooks-1.1.0

---
 srcpkgs/zzz-user-hooks/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/zzz-user-hooks/template

diff --git a/srcpkgs/zzz-user-hooks/template b/srcpkgs/zzz-user-hooks/template
new file mode 100644
index 00000000000..7301509092f
--- /dev/null
+++ b/srcpkgs/zzz-user-hooks/template
@@ -0,0 +1,23 @@
+# Template file for 'zzz-user-hooks'
+pkgname=zzz-user-hooks
+version=1.1.0
+revision=1
+archs=noarch
+build_style=gnu-makefile
+depends="bash"
+checkdepends="shellcheck"
+short_desc="Allow user scripts for logged in user using zzz suspend/resume"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="MIT"
+homepage="https://www.daveeddy.com/2018/10/01/run-user-scripts-on-suspend-and-wakeup-on-void-linux/"
+distfiles="https://github.com/bahamas10/zzz-user-hooks/archive/v${version}.tar.gz"
+checksum=83fb98153b1906c85946efb18eaad52a95a297a36528f975ba006e650e8459bd
+
+do_install() {
+	vmkdir /etc/zzz.d/resume
+	vmkdir /etc/zzz.d/suspend
+	vinstall user-script 755 /etc/zzz.d
+	vinstall hooks/resume/99-user-script 755 /etc/zzz.d/resume
+	vinstall hooks/suspend/99-user-script 755 /etc/zzz.d/suspend
+	vlicense LICENSE
+}

Re: New package: zzz-user-hooks-1.0.0

[anjandev]

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

New comment by anjandev on void-packages repository

https://github.com/void-linux/void-packages/pull/23430#issuecomment-657136521

Comment:
Hey,

Andrew J. Hesford <notifications@github.com> writes:

> This can be bumpbed to 1.1.0 and the `sudo` dependency removed, right?

Sorry I have been busy. I updated to 1.1.0 and removed sudo as a
dependency. Please merge this if you think it's ready.

> The X11 and Wayland detection in the upstream project is a little hacky, but that mean it isn't useful or suitable for packaging.

What would be the ideal way to detect X11 or Wayland? I can notify the
maintainer of the better way.

Thanks,
Anjandev Momi

Re: New package: zzz-user-hooks-1.0.0

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/23430#issuecomment-657169391

Comment:
I'm not sure of the best way to detect Wayland or X11. In my own use of `zzz` hooks, I avoid the issue altogether by creating triggers like `/run/zzz/will-sleep` and touch the trigger file on suspend. Any X11 or Wayland program that needs to run can just watch the trigger with inotify and act when appropriate.

Re: New package: zzz-user-hooks-1.0.0

[sgn]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23430#issuecomment-663029666

Comment:
I guess no more complaints for this package?

Re: New package: zzz-user-hooks-1.0.0

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/23430#issuecomment-663041909

Comment:
None from me

Re: [PR PATCH] [Merged]: New package: zzz-user-hooks-1.0.0

[sgn]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

There's a merged pull request on the void-packages repository

New package: zzz-user-hooks-1.0.0
https://github.com/void-linux/void-packages/pull/23430

Description: