[PR PATCH] New package: ugdb-0.1.7.

[PR PATCH] New package: ugdb-0.1.7.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages ugdb
https://github.com/void-linux/void-packages/pull/23520

New package: ugdb-0.1.7.
This will fail the first CI round for armv6l, just want to grab some links to explain why it's broken.

A patch file from https://github.com/void-linux/void-packages/pull/23520.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ugdb-23520.patch --]
[-- Type: text/x-diff, Size: 1049 bytes --]

From d3d4a6643ff94d37afe014ba47b4839c2f5eb4d3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sat, 11 Jul 2020 04:57:25 -0300
Subject: [PATCH] New package: ugdb-0.1.7.

---
 srcpkgs/ugdb/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/ugdb/template

diff --git a/srcpkgs/ugdb/template b/srcpkgs/ugdb/template
new file mode 100644
index 00000000000..ae47d3e04ed
--- /dev/null
+++ b/srcpkgs/ugdb/template
@@ -0,0 +1,21 @@
+# Template file for 'ugdb'
+pkgname=ugdb
+version=0.1.7
+revision=1
+build_style=cargo
+hostmakedepends="pkg-config libgit2-devel"
+makedepends="libgit2-devel"
+short_desc="Alternative TUI for gdb"
+maintainer="Érico Nogueira <ericonr@disroot.org>"
+license="MIT"
+homepage="https://github.com/ftilde/ugdb"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=b71e344ef385d00b54338fcb98e0add628ff16e4ee6c0c8761f8788bb56a99d1
+
+pre_build() {
+	export LIBGIT2_SYS_USE_PKG_CONFIG=yes
+}
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: ugdb-0.1.7.

[q66]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/23520#discussion_r453182974

Comment:
how many times do i have to say not to use this thing

Re: [PR REVIEW] New package: ugdb-0.1.7.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23520#discussion_r453203759

Comment:
It only seems to be used in `build.rs`, so I figured it would be ok. Otherwise it tries to build `libgit2` just to include commit information into the program, which doesn't even exist in the tarball.

Re: [PR REVIEW] New package: ugdb-0.1.7.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23520#discussion_r453203759

Comment:
It only seems to be used in `build.rs`, so I figured it would be ok. Otherwise it tries to build `libgit2` just to include commit information into the program, which doesn't even exist in the tarball. I will see if I can move to a more up to date version of `libgit2-sys`. If that doesn't work, should I include `cmake` as a build time dep and let it build `libgit2`?

Re: [PR PATCH] [Updated] New package: ugdb-0.1.7.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages ugdb
https://github.com/void-linux/void-packages/pull/23520

New package: ugdb-0.1.7.
This will fail the first CI round for armv6l, just want to grab some links to explain why it's broken.

A patch file from https://github.com/void-linux/void-packages/pull/23520.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ugdb-23520.patch --]
[-- Type: text/x-diff, Size: 1127 bytes --]

From 980eac9e23cf1410fe2d111cd149b4e3ec4f1068 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sat, 11 Jul 2020 04:57:25 -0300
Subject: [PATCH] New package: ugdb-0.1.7.

---
 srcpkgs/ugdb/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/ugdb/template

diff --git a/srcpkgs/ugdb/template b/srcpkgs/ugdb/template
new file mode 100644
index 00000000000..4000d7456b8
--- /dev/null
+++ b/srcpkgs/ugdb/template
@@ -0,0 +1,23 @@
+# Template file for 'ugdb'
+pkgname=ugdb
+version=0.1.7
+revision=1
+build_style=cargo
+hostmakedepends="pkg-config libgit2-devel"
+makedepends="libgit2-devel"
+short_desc="Alternative TUI for gdb"
+maintainer="Érico Nogueira <ericonr@disroot.org>"
+license="MIT"
+homepage="https://github.com/ftilde/ugdb"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=b71e344ef385d00b54338fcb98e0add628ff16e4ee6c0c8761f8788bb56a99d1
+
+pre_configure() {
+	# use git2-rs version that uses the system library
+	vsed -i -e 's/"0.6"/"0.13.1"/' Cargo.toml
+	cargo update
+}
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: ugdb-0.1.7.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23520#discussion_r453206394

Comment:
Okay, I think I managed to fix it with a sed replacement instead. It's similar to the one used in `git-absord`. However, I seem to need to add `libgit2-devel` to `makedepends` as well, because otherwise the build system passes flags like `-m64` to gcc for the linking step. Should I report this as an error somewhere? It certainly seems like one.

Regarding char signedness, how do I indicate it? `arch="x86_64* i686*"` ? I couldn't find a `XBPS_*` flag for it.

Re: [PR REVIEW] New package: ugdb-0.1.7.

[q66]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/23520#discussion_r453208338

Comment:
you can't, they need to fix it

Re: [PR REVIEW] New package: ugdb-0.1.7.

[q66]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New review comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/23520#discussion_r453208338

Comment:
you can't, they need to fix it

as for libgit2-sys, just patch it out somehow, don't give people any indication that using that env var may be okay

Re: [PR REVIEW] New package: ugdb-0.1.7.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 4049 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23520#discussion_r453210054

Comment:
`vsed`ing the version seems to have done the trick.

Do you know of a test I could run to check how those pkg-config flags are being propagated across the build system?

```
The following warnings were emitted during compilation:

warning: cc1: sorry, unimplemented: 64-bit mode not compiled in
warning: cc1: sorry, unimplemented: 64-bit mode not compiled in

error: failed to run custom build command for `libz-sys v1.0.25`

Caused by:
  process didn't exit successfully: `/builddir/ugdb-0.1.7/target/release/build/libz-sys-cf7ed1fe02cbb4c6/build-script-build` (exit code: 1)
--- stdout
cargo:rerun-if-env-changed=LIBZ_SYS_STATIC
cargo:rerun-if-changed=build.rs
cargo:rerun-if-env-changed=ZLIB_NO_PKG_CONFIG
cargo:rerun-if-env-changed=PKG_CONFIG
cargo:rerun-if-env-changed=ZLIB_STATIC
cargo:rerun-if-env-changed=ZLIB_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-musl
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_musl
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-musl
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_musl
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-musl
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_musl
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
TARGET = Some("x86_64-unknown-linux-musl")
OPT_LEVEL = Some("3")
HOST = Some("x86_64-unknown-linux-musl")
CC_x86_64-unknown-linux-musl = None
CC_x86_64_unknown_linux_musl = None
HOST_CC = None
CC = Some("i686-linux-musl-gcc")
CFLAGS_x86_64-unknown-linux-musl = None
CFLAGS_x86_64_unknown_linux_musl = None
HOST_CFLAGS = None
CFLAGS = Some("-fstack-clash-protection -D_FORTIFY_SOURCE=2 -O2 -pipe -march=i686   -I/usr/i686-linux-musl/usr/include")
CRATE_CC_NO_DEFAULTS = None
DEBUG = Some("false")
CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
running: "i686-linux-musl-gcc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-fstack-clash-protection" "-D_FORTIFY_SOURCE=2" "-O2" "-pipe" "-march=i686" "-I/usr/i686-linux-musl/usr/include" "-I" "src/zlib" "-fvisibility=hidden" "-DSTDC" "-D_LARGEFILE64_SOURCE" "-D_POSIX_SOURCE" "-o" "/builddir/ugdb-0.1.7/target/release/build/libz-sys-4d4fdfddee6ecc41/out/build/src/zlib/adler32.o" "-c" "src/zlib/adler32.c"
cargo:warning=cc1: sorry, unimplemented: 64-bit mode not compiled in
exit code: 1
running: "i686-linux-musl-gcc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-fstack-clash-protection" "-D_FORTIFY_SOURCE=2" "-O2" "-pipe" "-march=i686" "-I/usr/i686-linux-musl/usr/include" "-I" "src/zlib" "-fvisibility=hidden" "-DSTDC" "-D_LARGEFILE64_SOURCE" "-D_POSIX_SOURCE" "-o" "/builddir/ugdb-0.1.7/target/release/build/libz-sys-4d4fdfddee6ecc41/out/build/src/zlib/compress.o" "-c" "src/zlib/compress.c"
cargo:warning=cc1: sorry, unimplemented: 64-bit mode not compiled in
exit code: 1

--- stderr


error occurred: Command "i686-linux-musl-gcc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-fstack-clash-protection" "-D_FORTIFY_SOURCE=2" "-O2" "-pipe" "-march=i686" "-I/usr/i686-linux-musl/usr/include" "-I" "src/zlib" "-fvisibility=hidden" "-DSTDC" "-D_LARGEFILE64_SOURCE" "-D_POSIX_SOURCE" "-o" "/builddir/ugdb-0.1.7/target/release/build/libz-sys-4d4fdfddee6ecc41/out/build/src/zlib/adler32.o" "-c" "src/zlib/adler32.c" with args "i686-linux-musl-gcc" did not execute successfully (status code exit code: 1).



warning: build failed, waiting for other jobs to finish...
error: build failed
```

Re: [PR PATCH] [Updated] New package: ugdb-0.1.7.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages ugdb
https://github.com/void-linux/void-packages/pull/23520

New package: ugdb-0.1.7.
This will fail the first CI round for armv6l, just want to grab some links to explain why it's broken.

A patch file from https://github.com/void-linux/void-packages/pull/23520.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ugdb-23520.patch --]
[-- Type: text/x-diff, Size: 1200 bytes --]

From f78156521b40667dd10e6e078f3d5155b8c128b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sat, 11 Jul 2020 04:57:25 -0300
Subject: [PATCH] New package: ugdb-0.1.7.

---
 srcpkgs/ugdb/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/ugdb/template

diff --git a/srcpkgs/ugdb/template b/srcpkgs/ugdb/template
new file mode 100644
index 00000000000..922eb8ce5e9
--- /dev/null
+++ b/srcpkgs/ugdb/template
@@ -0,0 +1,24 @@
+# Template file for 'ugdb'
+pkgname=ugdb
+version=0.1.7
+revision=1
+build_style=cargo
+hostmakedepends="pkg-config libgit2-devel"
+# libgit2-devel is necessary in makedepends to fix flags passed to cc1
+makedepends="libgit2-devel"
+short_desc="Alternative TUI for gdb"
+maintainer="Érico Nogueira <ericonr@disroot.org>"
+license="MIT"
+homepage="https://github.com/ftilde/ugdb"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=b71e344ef385d00b54338fcb98e0add628ff16e4ee6c0c8761f8788bb56a99d1
+
+pre_configure() {
+	# use git2-rs version that uses the system library
+	vsed -i -e 's/"0.6"/"0.13.1"/' Cargo.toml
+	cargo update
+}
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: ugdb-0.1.7.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23520#issuecomment-657221569

Comment:
Waiting on upstream taking my PR to fix the error.

Re: [PR PATCH] [Updated] New package: ugdb-0.1.7.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages ugdb
https://github.com/void-linux/void-packages/pull/23520

New package: ugdb-0.1.7.
This will fail the first CI round for armv6l, just want to grab some links to explain why it's broken.

A patch file from https://github.com/void-linux/void-packages/pull/23520.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ugdb-23520.patch --]
[-- Type: text/x-diff, Size: 910 bytes --]

From 6adfd58bc248659f200c388877a567b8ed84b97a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sat, 11 Jul 2020 04:57:25 -0300
Subject: [PATCH] New package: ugdb-0.1.8.

---
 srcpkgs/ugdb/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/ugdb/template

diff --git a/srcpkgs/ugdb/template b/srcpkgs/ugdb/template
new file mode 100644
index 00000000000..76570dcf7eb
--- /dev/null
+++ b/srcpkgs/ugdb/template
@@ -0,0 +1,15 @@
+# Template file for 'ugdb'
+pkgname=ugdb
+version=0.1.8
+revision=1
+build_style=cargo
+short_desc="Alternative TUI for gdb"
+maintainer="Érico Nogueira <ericonr@disroot.org>"
+license="MIT"
+homepage="https://github.com/ftilde/ugdb"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=000a0d1bcc848332d5786ca9c37fcba0ead5d5cf33b39ba7620fe3fd9e530b9c
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: ugdb-0.1.7.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23520#issuecomment-659029002

Comment:
Updated and fixed.

Re: [PR PATCH] [Merged]: New package: ugdb-0.1.8.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

There's a merged pull request on the void-packages repository

New package: ugdb-0.1.8.
https://github.com/void-linux/void-packages/pull/23520

Description:
This will fail the first CI round for armv6l, just want to grab some links to explain why it's broken.