From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: fatsort-1.6.2.605
Date: Sat, 11 Jul 2020 20:40:07 +0200 [thread overview]
Message-ID: <20200711184007.Jl1ljqYacQpMhHijtRciS8Cz4iPIVFL4JXpPIF_Gc2I@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23485@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/23485#discussion_r453222458
Comment:
This is only `nocross` because upstream requires you to generate a man page on the fly using `help2man` and the target executable can't be run on the host. You have two easy fixes to make this cross-compilable:
1. Place a pregenerated `fatsort.1` in the `files` subdirectory alongside the template, then add
```
cp ${FILESDIR}/fatsort.1 man
```
in either `post_patch` (see comment below) or `pre_build`.
2. Add `build_helper="qemu"` to the template and add the following snippet to `post_patch`:
```
if [ "$CROSS_BUILD}" ]; then
cat > src/fatsort.qemu <<-EOF
#!/bin/sh
qemu-${XBPS_TARGET_QEMU_MACHINE}-static ${wrksrc}/src/fatsort "\$@"
EOF
chmod 755 src/fatsort.qemu
vsed -i man/Makefile -e 's|../src/fatsort|../src/fatsort.qemu|'
fi
```
This will dynamically generate the man page as upstream intends but will use qemu to make it cross-compilable.
Whatever you do, you should also file an issue upstream to get them to ship a pregenerated `fatsort.1` since there is no reason we should be dynamically generating it with every build.
next prev parent reply other threads:[~2020-07-11 18:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 0:59 [PR PATCH] " tibequadorian
2020-07-11 18:40 ` [PR REVIEW] " ahesford
2020-07-11 18:40 ` ahesford [this message]
2020-07-11 18:40 ` ahesford
2020-07-11 19:56 ` [PR PATCH] [Updated] " tibequadorian
2020-07-11 20:22 ` [PR REVIEW] " tibequadorian
2020-07-11 20:22 ` tibequadorian
2020-07-11 20:22 ` tibequadorian
2020-07-11 20:47 ` Chocimier
2020-07-22 17:45 ` tibequadorian
2020-07-24 0:45 ` sgn
2020-07-24 2:15 ` ahesford
2020-07-25 4:44 ` sgn
2020-07-25 13:07 ` tibequadorian
2020-07-25 13:30 ` ahesford
2020-07-25 16:45 ` tibequadorian
2020-07-25 16:51 ` [PR PATCH] [Updated] " tibequadorian
2020-07-25 17:32 ` tibequadorian
2020-07-25 17:58 ` ahesford
2020-07-26 0:57 ` sgn
2020-07-26 3:52 ` ahesford
2020-07-26 3:57 ` sgn
2020-07-26 4:02 ` [PR PATCH] [Merged]: " sgn
2020-07-26 9:59 ` tibequadorian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200711184007.Jl1ljqYacQpMhHijtRciS8Cz4iPIVFL4JXpPIF_Gc2I@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).