From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: fatsort-1.6.2.605
Date: Sun, 26 Jul 2020 02:57:22 +0200 [thread overview]
Message-ID: <20200726005722.vze3ICFt9CZkJHV9gsh6opIVu4AszIAkrOTqLGst69E@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23485@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/23485#issuecomment-663922330
Comment:
- `printf(3)` is incorrect if help/version contains `%`,
either use `puts(3)` instead or
```cpp
printf("%s", $arg);
```
- Add a newline between include and main
- In case you don't know, we can quote EOF to save extra quoting in here doc.
```sh
if [ "$CROSS_BUILD" ]; then
hostmakedepends+=" tcc"
post_patch() {
cpp -dM src/fatsort.c | grep '#define INFO' > man/info.h
cat > man/fatsort.sh <<-'EOF'
#!/bin/sh
case $1 in
"--help") arg="INFO_OPTION_HELP" ;;
"--version") arg="INFO_OPTION_VERSION" ;;
esac
echo '#include "info.h"' "int main(){return printf(\"%s\", $arg) > 0;}" |
tcc -run -
EOF
chmod 755 man/fatsort.sh
vsed -i man/Makefile -e 's|../src/fatsort|./fatsort.sh|'
}
fi
```
next prev parent reply other threads:[~2020-07-26 0:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 0:59 [PR PATCH] " tibequadorian
2020-07-11 18:40 ` [PR REVIEW] " ahesford
2020-07-11 18:40 ` ahesford
2020-07-11 18:40 ` ahesford
2020-07-11 19:56 ` [PR PATCH] [Updated] " tibequadorian
2020-07-11 20:22 ` [PR REVIEW] " tibequadorian
2020-07-11 20:22 ` tibequadorian
2020-07-11 20:22 ` tibequadorian
2020-07-11 20:47 ` Chocimier
2020-07-22 17:45 ` tibequadorian
2020-07-24 0:45 ` sgn
2020-07-24 2:15 ` ahesford
2020-07-25 4:44 ` sgn
2020-07-25 13:07 ` tibequadorian
2020-07-25 13:30 ` ahesford
2020-07-25 16:45 ` tibequadorian
2020-07-25 16:51 ` [PR PATCH] [Updated] " tibequadorian
2020-07-25 17:32 ` tibequadorian
2020-07-25 17:58 ` ahesford
2020-07-26 0:57 ` sgn [this message]
2020-07-26 3:52 ` ahesford
2020-07-26 3:57 ` sgn
2020-07-26 4:02 ` [PR PATCH] [Merged]: " sgn
2020-07-26 9:59 ` tibequadorian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200726005722.vze3ICFt9CZkJHV9gsh6opIVu4AszIAkrOTqLGst69E@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).