From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: fatsort-1.6.2.605
Date: Sat, 25 Jul 2020 15:30:40 +0200 [thread overview]
Message-ID: <20200725133040.GhsrEp4U0foT0ZykTs1tMXsCrnfXGl93UtWTu26zt44@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23485@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/23485#issuecomment-663855855
Comment:
The qemu helper is a bit heavy handed just to dump the help output to a man page, but I don't have a real problem with it because it's "correct" in that it honors the upstream intentions. I *do* think you should complain upsream that they should ship a proper man page rather than relying on dynamic generation at build time.
The real issue is that @sgn improved the template by supporting `xbps-src check` and by using `make_install_args` to get the right installation behavior without resorting to patch the makefile. You should adapt those changes and make sure to mark the package broken for musl since it fails tests.
next prev parent reply other threads:[~2020-07-25 13:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 0:59 [PR PATCH] " tibequadorian
2020-07-11 18:40 ` [PR REVIEW] " ahesford
2020-07-11 18:40 ` ahesford
2020-07-11 18:40 ` ahesford
2020-07-11 19:56 ` [PR PATCH] [Updated] " tibequadorian
2020-07-11 20:22 ` [PR REVIEW] " tibequadorian
2020-07-11 20:22 ` tibequadorian
2020-07-11 20:22 ` tibequadorian
2020-07-11 20:47 ` Chocimier
2020-07-22 17:45 ` tibequadorian
2020-07-24 0:45 ` sgn
2020-07-24 2:15 ` ahesford
2020-07-25 4:44 ` sgn
2020-07-25 13:07 ` tibequadorian
2020-07-25 13:30 ` ahesford [this message]
2020-07-25 16:45 ` tibequadorian
2020-07-25 16:51 ` [PR PATCH] [Updated] " tibequadorian
2020-07-25 17:32 ` tibequadorian
2020-07-25 17:58 ` ahesford
2020-07-26 0:57 ` sgn
2020-07-26 3:52 ` ahesford
2020-07-26 3:57 ` sgn
2020-07-26 4:02 ` [PR PATCH] [Merged]: " sgn
2020-07-26 9:59 ` tibequadorian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200725133040.GhsrEp4U0foT0ZykTs1tMXsCrnfXGl93UtWTu26zt44@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).