* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
@ 2020-08-07 0:07 ` fosslinux
2020-08-07 8:26 ` MGlolenstine
` (21 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: fosslinux @ 2020-08-07 0:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
New comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-670250561
Comment:
Thanks for your PR!
https://travis-ci.org/github/void-linux/void-packages/jobs/715664522 as you can see here, there are some `xlint` erorrs. Would you mind fixing them?
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
2020-08-07 0:07 ` fosslinux
@ 2020-08-07 8:26 ` MGlolenstine
2020-08-07 8:40 ` MGlolenstine
` (20 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: MGlolenstine @ 2020-08-07 8:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
New comment by MGlolenstine on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-670398291
Comment:
On it!
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
2020-08-07 0:07 ` fosslinux
2020-08-07 8:26 ` MGlolenstine
@ 2020-08-07 8:40 ` MGlolenstine
2020-08-07 8:40 ` MGlolenstine
` (19 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: MGlolenstine @ 2020-08-07 8:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
New comment by MGlolenstine on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-670398291
Comment:
On it!
EDIT: I've been trying to find a license Discord uses, but was unable to.
it's set as "proprietary" in the file, but no SPDX is set. Now I've found this https://discord.com/terms , but I'm unsure on how to add it to the file.
[Here](https://github.com/void-linux/void-packages/blob/master/Manual.md#mandatory-variables) it states that it can be a `Public Domain`. Does that mean, that I can just insert the URL from above and we're set?
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (2 preceding siblings ...)
2020-08-07 8:40 ` MGlolenstine
@ 2020-08-07 8:40 ` MGlolenstine
2020-08-07 21:42 ` fosslinux
` (18 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: MGlolenstine @ 2020-08-07 8:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
New comment by MGlolenstine on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-670398291
Comment:
On it!
EDIT: I've been trying to find a license Discord uses, but was unable to.
it's set as "proprietary" in the file, but no SPDX is set. Now I've found this https://discord.com/terms , but I'm unsure on how to add it to the file.
[Here](https://github.com/void-linux/void-packages/blob/master/Manual.md#mandatory-variables) it states that it can be a `Public Domain`. Does that mean that I can just insert the URL from above and we're set?
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (3 preceding siblings ...)
2020-08-07 8:40 ` MGlolenstine
@ 2020-08-07 21:42 ` fosslinux
2020-08-07 21:43 ` fosslinux
` (17 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: fosslinux @ 2020-08-07 21:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
New comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-670724491
Comment:
The `custom:` speciefier indicates it is not SPDX. Use something along the lines of `custom:proprietary`.
The line wrap looks good, but maybe make it consistent. I.e., if you are going to split at (I think you did) 90 characters, split the next line at 90 characters too... keep all of the lines for that block the same length.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (4 preceding siblings ...)
2020-08-07 21:42 ` fosslinux
@ 2020-08-07 21:43 ` fosslinux
2020-08-07 21:54 ` ericonr
` (16 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: fosslinux @ 2020-08-07 21:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
New comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-670724491
Comment:
The `custom:` speciefier indicates it is not SPDX. Use something along the lines of `custom:proprietary`.
The line wrap looks good, but maybe make it consistent. I.e., if you are going to split at (I think you did) 90 characters, split the next line at 90 characters too... keep all of the lines for that block the same length.
Eg:
```
for item in DiscordPTB chrome_100_percent.pak chrome_200_percent.pak icudtl.dat libEGL.so \
libGLESv2.so libffmpeg.so locales natives_blob.bin resources resources.pak snapshot_blob.bin swiftshader v8_context_snapshot.bin; do
```
to
```
for item in DiscordPTB chrome_100_percent.pak chrome_200_percent.pak icudtl.dat libEGL.so \
libGLESv2.so libffmpeg.so locales natives_blob.bin resources resources.pak snapshot_blob.bin \
swiftshader v8_context_snapshot.bin; do
```
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (5 preceding siblings ...)
2020-08-07 21:43 ` fosslinux
@ 2020-08-07 21:54 ` ericonr
2020-08-07 22:00 ` MGlolenstine
` (15 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: ericonr @ 2020-08-07 21:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-670727828
Comment:
I believe "custom:Proprietary" is preferred. And line wraps around 80 columns, if possible.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (6 preceding siblings ...)
2020-08-07 21:54 ` ericonr
@ 2020-08-07 22:00 ` MGlolenstine
2020-08-08 17:45 ` MGlolenstine
` (14 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: MGlolenstine @ 2020-08-07 22:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
New comment by MGlolenstine on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-670729485
Comment:
I think "custom:Proprietary" had some problems with xlint and was throwing errors... I'll have to check out that tomorrow (it's midnight here) and I'm in for 80 char line wrap.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (7 preceding siblings ...)
2020-08-07 22:00 ` MGlolenstine
@ 2020-08-08 17:45 ` MGlolenstine
2020-08-08 18:28 ` ericonr
` (13 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: MGlolenstine @ 2020-08-08 17:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
New comment by MGlolenstine on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-670955236
Comment:
@ericonr This is the lint error I was talking about. I'm unsure what to put at the `vlicense` if anything.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (8 preceding siblings ...)
2020-08-08 17:45 ` MGlolenstine
@ 2020-08-08 18:28 ` ericonr
2020-08-08 18:30 ` MGlolenstine
` (12 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: ericonr @ 2020-08-08 18:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-670959395
Comment:
You might need to find an EULA or License Agreement. The spotify template, for example, has to do a similar dance.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (9 preceding siblings ...)
2020-08-08 18:28 ` ericonr
@ 2020-08-08 18:30 ` MGlolenstine
2020-08-08 18:32 ` ericonr
` (11 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: MGlolenstine @ 2020-08-08 18:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
New comment by MGlolenstine on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-670959555
Comment:
> You might need to find an EULA or License Agreement. The spotify template, for example, has to do a similar dance.
Would this do?
How should I format it in the file?
```
vlicense=https://discord.com/terms
```
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (10 preceding siblings ...)
2020-08-08 18:30 ` MGlolenstine
@ 2020-08-08 18:32 ` ericonr
2020-08-08 18:36 ` MGlolenstine
` (10 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: ericonr @ 2020-08-08 18:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-670959734
Comment:
I think that file would work, but you'd have to do something like https://github.com/void-linux/void-packages/blob/master/srcpkgs/spotify/template#L23 to pre-process it.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (11 preceding siblings ...)
2020-08-08 18:32 ` ericonr
@ 2020-08-08 18:36 ` MGlolenstine
2020-08-10 6:09 ` MGlolenstine
` (9 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: MGlolenstine @ 2020-08-08 18:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
New comment by MGlolenstine on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-670960105
Comment:
> I think that file would work, but you'd have to do something like https://github.com/void-linux/void-packages/blob/master/srcpkgs/spotify/template#L23 to pre-process it.
Oh wow, that looks complicated... It's pretty late here, so I'll take my time tomorrow and modify it...
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (12 preceding siblings ...)
2020-08-08 18:36 ` MGlolenstine
@ 2020-08-10 6:09 ` MGlolenstine
2020-08-10 19:06 ` FirstZero
` (8 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: MGlolenstine @ 2020-08-10 6:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
New comment by MGlolenstine on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-671178770
Comment:
Would this be ready for merge, or is there something still missing?
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (13 preceding siblings ...)
2020-08-10 6:09 ` MGlolenstine
@ 2020-08-10 19:06 ` FirstZero
2020-08-14 17:41 ` ericonr
` (7 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: FirstZero @ 2020-08-10 19:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
New comment by FirstZero on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-671533939
Comment:
Ideally you might want to squash rebase your commits into one. Other than that, this seems ready for review.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (14 preceding siblings ...)
2020-08-10 19:06 ` FirstZero
@ 2020-08-14 17:41 ` ericonr
2020-08-14 17:51 ` MGlolenstine
` (6 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: ericonr @ 2020-08-14 17:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-674187140
Comment:
You need to squash these commits before it can be merged.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (15 preceding siblings ...)
2020-08-14 17:41 ` ericonr
@ 2020-08-14 17:51 ` MGlolenstine
2020-08-14 17:56 ` MGlolenstine
` (5 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: MGlolenstine @ 2020-08-14 17:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
New comment by MGlolenstine on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-674191304
Comment:
Ugh... I guess that squash didn't work like I wanted it to. :sweat_smile:
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (16 preceding siblings ...)
2020-08-14 17:51 ` MGlolenstine
@ 2020-08-14 17:56 ` MGlolenstine
2020-08-20 22:42 ` chilledfrogs
` (4 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: MGlolenstine @ 2020-08-14 17:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 164 bytes --]
New comment by MGlolenstine on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-674192934
Comment:
This seems better.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (17 preceding siblings ...)
2020-08-14 17:56 ` MGlolenstine
@ 2020-08-20 22:42 ` chilledfrogs
2020-08-20 22:48 ` MGlolenstine
` (3 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: chilledfrogs @ 2020-08-20 22:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
New comment by chilledfrogs on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-677942795
Comment:
BTW, just a little detail, but they moved to https://discord.com/ recently-ish @MGlolenstine, might wanna update that in homepage (for the moment the old URL is still usable though so not a huge deal)
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (18 preceding siblings ...)
2020-08-20 22:42 ` chilledfrogs
@ 2020-08-20 22:48 ` MGlolenstine
2020-09-10 8:12 ` MGlolenstine
` (2 subsequent siblings)
22 siblings, 0 replies; 29+ messages in thread
From: MGlolenstine @ 2020-08-20 22:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
New comment by MGlolenstine on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-677944274
Comment:
> BTW, just a little detail, but they moved to https://discord.com/ recently-ish @MGlolenstine, might wanna update that in homepage (for the moment the old URL is still usable though so not a huge deal)
I've just updated the URL.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (19 preceding siblings ...)
2020-08-20 22:48 ` MGlolenstine
@ 2020-09-10 8:12 ` MGlolenstine
2020-09-10 9:39 ` fosslinux
2020-09-10 9:40 ` MGlolenstine
22 siblings, 0 replies; 29+ messages in thread
From: MGlolenstine @ 2020-09-10 8:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
New comment by MGlolenstine on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-690070729
Comment:
I've updated the package to 0.0.22.
Should I close this PR and create a new one, as the version changed or would it be ok, if I just changed the commit message and PR's title?
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (20 preceding siblings ...)
2020-09-10 8:12 ` MGlolenstine
@ 2020-09-10 9:39 ` fosslinux
2020-09-10 9:40 ` MGlolenstine
22 siblings, 0 replies; 29+ messages in thread
From: fosslinux @ 2020-09-10 9:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-690116231
Comment:
No, you should just change the commit message and the title.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: discord-ptb: update to 0.0.21
2020-08-06 22:28 [PR PATCH] " MGlolenstine
` (21 preceding siblings ...)
2020-09-10 9:39 ` fosslinux
@ 2020-09-10 9:40 ` MGlolenstine
22 siblings, 0 replies; 29+ messages in thread
From: MGlolenstine @ 2020-09-10 9:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
New comment by MGlolenstine on void-packages repository
https://github.com/void-linux/void-packages/pull/24117#issuecomment-690116845
Comment:
Should commit message contain every change or just the "discord-ptb: update to 0.0.22"?
^ permalink raw reply [flat|nested] 29+ messages in thread