[PR PATCH] popt: update to 1.18.

[PR PATCH] popt: update to 1.18.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

There is a new pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages popt
https://github.com/void-linux/void-packages/pull/24436

popt: update to 1.18.


A patch file from https://github.com/void-linux/void-packages/pull/24436.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-popt-24436.patch --]
[-- Type: text/x-diff, Size: 1339 bytes --]

From 782307764a390306024872ef2ed077a5ba5dfd47 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sun, 23 Aug 2020 18:54:11 +0300
Subject: [PATCH] popt: update to 1.18.

---
 srcpkgs/popt/template | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/popt/template b/srcpkgs/popt/template
index c8d29d603be..6049055b10a 100644
--- a/srcpkgs/popt/template
+++ b/srcpkgs/popt/template
@@ -1,16 +1,20 @@
 # Template file for 'popt'
 pkgname=popt
-version=1.16
-revision=7
+version=1.18
+revision=1
 build_style=gnu-configure
+hostmakedepends="autoconf tar automake libtool gettext-devel"
 short_desc="Command line option parsing library"
 maintainer="Orphaned <orphan@voidlinux.org>"
-homepage="http://rpm5.org"
 license="MIT"
-#distfiles="http://rpm5.org/files/$pkgname/$pkgname-$version.tar.gz"
-distfiles="https://fossies.org/linux/misc/popt-1.16.tar.gz"
-checksum=e728ed296fe9f069a0e005003c3d6b2dde3d9cad453422a10d6558616d304cc8
+homepage="https://rpm.org/"
+changelog="https://github.com/rpm-software-management/popt/releases/tag/popt-1.18-release"
+distfiles="http://ftp.rpm.org/popt/releases/popt-1.x/popt-${version}.tar.gz"
+checksum=5159bc03a20b28ce363aa96765f37df99ea4d8850b1ece17d1e6ad5c24fdc5d1
 
+pre_configure() {
+	./autogen.sh
+}
 
 post_install() {
 	vlicense COPYING

Re: [PR REVIEW] popt: update to 1.18.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24436#discussion_r475859325

Comment:
I'm not thrilled about this Github release page serving as the changelog, not least because it will get out of sync if somebody forgets to update the version and we generally don't want to replace the static version with `$version` or anything like that. Might be better just to drop the changelog until upstream updates the in-repo `CHANGES` file.

Re: [PR REVIEW] popt: update to 1.18.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24436#discussion_r475860081

Comment:
This doesn't really seem like the right home page because the package is only mentioned in passing in the "NEWS" section. I'd advocate either https://github.com/rpm-software-management/popt or http://ftp.rpm.org/popt/ which the Github repo links as the home page.

Re: [PR PATCH] [Updated] popt: update to 1.18.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages popt
https://github.com/void-linux/void-packages/pull/24436

popt: update to 1.18.


A patch file from https://github.com/void-linux/void-packages/pull/24436.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-popt-24436.patch --]
[-- Type: text/x-diff, Size: 1245 bytes --]

From a97a03affff1a4797b2e8bb40dd398962b780c2c Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sun, 23 Aug 2020 18:54:11 +0300
Subject: [PATCH] popt: update to 1.18.

---
 srcpkgs/popt/template | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/popt/template b/srcpkgs/popt/template
index c8d29d603be..e7eabf2b1f0 100644
--- a/srcpkgs/popt/template
+++ b/srcpkgs/popt/template
@@ -1,16 +1,19 @@
 # Template file for 'popt'
 pkgname=popt
-version=1.16
-revision=7
+version=1.18
+revision=1
 build_style=gnu-configure
+hostmakedepends="autoconf tar automake libtool gettext-devel"
 short_desc="Command line option parsing library"
 maintainer="Orphaned <orphan@voidlinux.org>"
-homepage="http://rpm5.org"
 license="MIT"
-#distfiles="http://rpm5.org/files/$pkgname/$pkgname-$version.tar.gz"
-distfiles="https://fossies.org/linux/misc/popt-1.16.tar.gz"
-checksum=e728ed296fe9f069a0e005003c3d6b2dde3d9cad453422a10d6558616d304cc8
+homepage="https://rpm.org/"
+distfiles="http://ftp.rpm.org/popt/releases/popt-1.x/popt-${version}.tar.gz"
+checksum=5159bc03a20b28ce363aa96765f37df99ea4d8850b1ece17d1e6ad5c24fdc5d1
 
+pre_configure() {
+	./autogen.sh
+}
 
 post_install() {
 	vlicense COPYING

Re: [PR REVIEW] popt: update to 1.18.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/24436#discussion_r476275288

Comment:
Done!

Re: [PR REVIEW] popt: update to 1.18.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 788 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/24436#discussion_r476282834

Comment:
I disagree :)
popt development was done under the umbrella of rpm5.org and now it is under the umbrella of the rpm developers at rpm.org. The previous homepage was rpm5.org, the current homepage should be rpm.org. Your first proposal is  actually a repo page in the rpm gh organisation, which is linked from **rpm.org**, the second is a directory in the **rpm.org** ftp server. I may be confused (it is known to happen :P) but I usually try to find a proper http site for the project and if that is missing, I default to the repo. Having a more general web site as home page is not unprecedented (see all packages belonging to certan DEs).

Re: [PR REVIEW] popt: update to 1.18.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24436#discussion_r476360629

Comment:
That's a reasonable view.

Re: [PR PATCH] [Merged]: popt: update to 1.18.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

There's a merged pull request on the void-packages repository

popt: update to 1.18.
https://github.com/void-linux/void-packages/pull/24436

Description: