[PR PATCH] newsboat: update to 2.21.

[PR PATCH] newsboat: update to 2.21.

[jbenden]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

There is a new pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages newsboat-2.21
https://github.com/void-linux/void-packages/pull/25270

newsboat: update to 2.21.
Newsboat update to 2.21

Tested locally and functions.
Signed-off-by: Joseph Benden <joe@benden.us>

A patch file from https://github.com/void-linux/void-packages/pull/25270.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newsboat-2.21-25270.patch --]
[-- Type: text/x-diff, Size: 1444 bytes --]

From ad5e605d9cdf7acbec4780e78a0270b0e828eac5 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Fri, 2 Oct 2020 01:03:58 -0700
Subject: [PATCH] newsboat: update to 2.21.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/newsboat/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index 2de75817d2c..3ae5f8bbdf9 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -1,7 +1,7 @@
 # Template file for 'newsboat'
 pkgname=newsboat
-version=2.19
-revision=2
+version=2.21
+revision=1
 build_style=configure
 build_helper="rust"
 configure_script="./config.sh"
@@ -16,7 +16,7 @@ license="MIT"
 homepage="https://newsboat.org/"
 changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md"
 distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz"
-checksum=ba484c825bb903daf6d33d55126107b59e41111b455d368362208f1825403d1b
+checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31
 
 do_check() {
 	make test
@@ -25,7 +25,7 @@ do_check() {
 
 post_install() {
 	vlicense LICENSE
-	vsconf doc/example-bookmark-plugin.sh bookmark-plugin.sh
+	vsconf doc/examples/example-bookmark-plugin.sh bookmark-plugin.sh
 	mv "${DESTDIR}/usr/share/doc/newsboat/examples/config" \
 		"${DESTDIR}/usr/share/examples/newsboat"
 	vcopy contrib usr/share/examples/newsboat

Re: newsboat: update to 2.21.

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/25270#issuecomment-702912588

Comment:
#24742

Re: [PR PATCH] [Closed]: newsboat: update to 2.21.

[jbenden]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

There's a closed pull request on the void-packages repository

newsboat: update to 2.21.
https://github.com/void-linux/void-packages/pull/25270

Description:
Newsboat update to 2.21

Tested locally and functions.
Signed-off-by: Joseph Benden <joe@benden.us>

Re: newsboat: update to 2.21.

[Minoru]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

New comment by Minoru on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#issuecomment-703303194

Comment:
Thanks! We've had a few reports about problems with musl builds, but unfortunately never gotten to the bottom of the matter. I copied your output to newsboat/newsboat#1216, maybe someone will look at it after all ._.

Re: newsboat: update to 2.21.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#issuecomment-703294602

Comment:
Tests fail when building in an x86_64-musl environment. Running tests is neither part of travis nor buildbot.

Reproduce:
```
./xbps-src zap && ./xbps-src binary-bootstrap x86_64-musl
./xbps-src -j 1 -Q pkg newsboat
```
Full log: https://termbin.com/yuj5 (might not be available after a while)

Re: newsboat: update to 2.21.

[Minoru]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New comment by Minoru on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#issuecomment-702924244

Comment:
> do you care that some test fail?

I am Newsboat's maintainer, so I do :) Can I view the whole output somewhere? I don't see tests being run in the Travis logs.

Re: newsboat: update to 2.21.

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#issuecomment-699496948

Comment:
> > Strange, all tests actually passed on my machine.
> > ```
> > All tests passed (22485 assertions in 495 test cases)
> > ```
> > 
> > 
> > 2.21 is running without any issues so far, so I guess this should be fine.
> 
> did you build with `XBPS_CHECK_PKGS=yes` in etc/conf ?

Yes

Re: newsboat: update to 2.21.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#issuecomment-698243745

Comment:
> Strange, all tests actually passed on my machine.
> 
> ```
> All tests passed (22485 assertions in 495 test cases)
> ```
> 
> 2.21 is running without any issues so far, so I guess this should be fine.

did you build with `XBPS_CHECK_PKGS=yes` in etc/conf ?

Re: newsboat: update to 2.21.

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#issuecomment-697338294

Comment:
> do you care that some test fail?
> 
> ```
> test cases:   495 |   492 passed | 3 failed
> assertions: 22478 | 22472 passed | 6 failed
> 
> => ERROR: newsboat-2.21_1: do_check: 'TERM=$TERM TMPDIR=/dev/shm ./test' exited with 6
> => ERROR:   in do_check() at srcpkgs/newsboat/template:23
> => ERROR: newsboat-2.21_1: do_check: '( cd test && TERM=$TERM TMPDIR=/dev/shm ./test )' exited with 1
> => ERROR:   in do_check() at srcpkgs/newsboat/template:23
> ```

Strange, all tests actually passed on my machine.
```
All tests passed (22485 assertions in 495 test cases)
```
2.21 is running without any issues so far, so I guess this should be fine.

Re: newsboat: update to 2.21.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#issuecomment-697295985

Comment:
do you care that some test fail?
```
test cases:   495 |   492 passed | 3 failed
assertions: 22478 | 22472 passed | 6 failed

=> ERROR: newsboat-2.21_1: do_check: 'TERM=$TERM TMPDIR=/dev/shm ./test' exited with 6
=> ERROR:   in do_check() at srcpkgs/newsboat/template:23
=> ERROR: newsboat-2.21_1: do_check: '( cd test && TERM=$TERM TMPDIR=/dev/shm ./test )' exited with 1
=> ERROR:   in do_check() at srcpkgs/newsboat/template:23
```